Log topic on ethereum side #1404
Merged
+66
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
approved these changes
Mar 6, 2025
This was referenced Mar 7, 2025
|
Some tests failed which requires test fixture from local setup. @vgeddes You can leave it to me, I'll update the relayer and the text fixture. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #1404 +/- ##
=====================================
Coverage ? 78.73%
=====================================
Files ? 23
Lines ? 884
Branches ? 133
=====================================
Hits ? 696
Misses ? 163
Partials ? 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Tested this PR alongside vgeddes/polkadot-sdk#35 using a local setup. The outbound smoke test works as expected. I think we can merge these two PRs now. |
yrong
added a commit
that referenced
this pull request
Apr 2, 2025
* Contracts V2 (#1300) * Ethereum Relayer V2 (#1341) * v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * comments * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Clean up interfaces * Make WETH address configurable * Autowrap ether * auto-unwrap ether * Add view keyword * off-chain part * off-chain changes * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Apply suggestions from code review Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * add foundry setting * relayer progress * fixes * adds xcm * register token v2 * clean up register token smoketest * fmt * merge damage * fix tests * send token and relayer fixes * relayer cleanup and transact * send token to penpal smoke test * syntax error * adds penpal test to ci * merge damage fixes --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Parachain Relayer V2 (#1321) * v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * Parachain relayer V2 * Rename to PendingOrder * Decode compact int * comments * Improve doc * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Remove unused * Submit delivery proof * Rename to InboundMessageV2 * Mark as view function * Filter with reward address * Clean up interfaces * Make WETH address configurable * Autowrap ether * V2 smoke tests (#1327) * Update contracts for smoke tests * Remove unused * Decode test * Update subxt * Register PNA with OutbountQueueV2 * Fix storage key * Comment out config * Revert contract changes * Fix function * Regenerate binds & update package path * Format * Format * Add todo * Update bindings * Update script * auto-unwrap ether * Update smoke tests * Add view keyword * More refactoring * Verify V2 digest for commitment * Call Contract with value * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Fix smoke test for V2 * Fix test * Fix unlock WETH * Sync with contract * Fix smoke test * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Apply suggestions from code review Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * Fix breaking tests * Fix tests * Filter order by rewardAddress to handle own delivery proof * Fix test * Add ofac check --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix V2 tests (#1378) * Fix smoke tests * Add smoke tests * Prefund transfer ENA * Create agent (#1388) * Create agent on Ethereum * Add test * Fix forge test * Revamp smoke test * Update go bindings * Add register relay token back * Fix transfer pna * Remove obsolete code * Update contracts/src/v2/Types.sol Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> * Update foundry.toml * Rename follow the naming scheme * Fix smoke test * Fix function name --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> * Fix test coverage reports (#1390) * Gateway should no longer build token registration XCM (#1381) * Rather build register token on BH * Add comments * adds metadata fields to register token * Revert "adds metadata fields to register token" This reverts commit 90cbff5. * update tests * Cleanup * Update bindings * remove kusama as supported network --------- Co-authored-by: claravanstaden <claravanstaden64@gmail.com> Co-authored-by: ron <yrong1997@gmail.com> * Improve smoke tests (#1396) * Rather build register token on BH * Add comments * adds metadata fields to register token * Revert "adds metadata fields to 8000 register token" This reverts commit 90cbff5. * update tests * Cleanup * Update bindings * Fix smoke test send token to destination chain * Rename path * Add send pna * Check amount --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: claravanstaden <claravanstaden64@gmail.com> * cherry-pick token changes from main * Revert "cherry-pick token changes from main" This reverts commit 9731690. * Improve ERC20 implementation (#1384) * Add more docs * Log topic on ethereum side (#1404) * Log topic on ethereum side * Fix test * Update relayer --------- Co-authored-by: ron <yrong1997@gmail.com> * Delete obsolete code * improve comments * cleanups after static analysis * Remove handlers for deprecated V1 commands * format code * format comments * Refactor agent creation code * Add test for foreign token registration * Add tests for mint foreign token * Improve docs * Update bindings * Merge from V1 (#1422) * Add support for ether (#1409) * Upgrade gateway on Sepolia for westend (#1407) * Log gateway codehash * Upgrade Gateway on Westend-Sepolia * Update indexer endpoint & Cleanup (#1411) * Ban lido token (#1412) * Fix hardcoded url (#1414) * Register Polkadot Native Assets in Control Tool (#1405) * added function to register tokens * fmt * fix build errors * clean up * more assets * fix message * more tokens * Update control/preimage/src/commands.rs --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Force rebuild (#1418) * Update with V1 bindings * Remove channel config * Remove channel * Remove topic id from InboundMessageDispatched * Format codes (#1416) * Generate delivery receipt * Revert "Remove topic id from InboundMessageDispatched" This reverts commit 7e77f49. modified: smoketest/src/helper.rs modified: web/packages/test/scripts/build-binary.sh * Fix script * Clean up unused code * Cleanup * Minor fix * Fix binding * Change storage location * Fix template --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Merge updates from V1 (#1429) * Add support for ether (#1409) * Upgrade gateway on Sepolia for westend (#1407) * Log gateway codehash * Upgrade Gateway on Westend-Sepolia * Update indexer endpoint & Cleanup (#1411) * Ban lido token (#1412) * Fix hardcoded url (#1414) * Register Polkadot Native Assets in Control Tool (#1405) * added function to register tokens * fmt * fix build errors * clean up * more assets * fix message * more tokens * Update control/preimage/src/commands.rs --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Force rebuild (#1418) * Format codes (#1416) * remove equilibrium and its stable coin (#1421) * Hot fix (#1424) * Update Bifrost RPC endpoint * Update package * Update geth to v.15.5 in order to support decoding of SetCodeTx (#1426) * update geth to v.15.5 in order to support decoding of SetCodeTx * update go to 1.23.0 * update Go version in CI * fix breaking test * Cleanup --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com> * For V1 compatibility (#1428) * Merge recent changes from V1 * Fix smoke tests * Update go.work.sum * Improve smoke tests --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed this.