8000 Issues with next version of ggplot2 · Issue #41 · SchlossLab/schtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Issues with next version of ggplot2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
8000
thomasp85 opened this issue Oct 11, 2022 · 0 comments · Fixed by #42
Closed

Issues with next version of ggplot2 #41

thomasp85 opened this issue Oct 11, 2022 · 0 comments · Fixed by #42
Assignees
@kelly-sovacool
Labels
bug an unexpected problem or unintended behavior

Comments

@thomasp85
Copy link

Hi

We are preparing the next release of ggplot2 and our reverse dependency checks show that your package is failing with the new version. Looking into it we see that this is caused by our move to linewidth in stroke aesthetics and elements. Your unit tests are testing your theme by comparing it to prespecified values and e.g. element_line is now using linewidth instead of size internally.

You can install the release candidate of ggplot2 using devtools::install_github('tidyverse/ggplot2@v3.4.0-rc') to test this out.

We plan to submit ggplot2 by the end of October and hope you can have a fix ready before then

Kind regards
Thomas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelly-sovacool kelly-sovacool

Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests in advance of next ggplot2 release SchlossLab/schtools
2 participants
@thomasp85 @kelly-sovacool
0