8000 Test that the plot prints without warnings by kelly-sovacool · Pull Request #303 · SchlossLab/mikropml · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test that the plot prints without warnings #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2022
Merged

Test that the plot prints without warnings #303

merged 4 commits into from
Oct 13, 2022

Conversation

kelly-sovacool
Copy link
Member
@kelly-sovacool kelly-sovacool commented Oct 11, 2022 •
edited
Loading

Change(s) made

  • Added a unit test to make sure the plot will print without warnings or error messages.
  • Currently, printing a box plot fails with tidyverse/ggplot2@v3.4.0-rc. Their unit tests also fail with the same problem, so I'm confident it'll be fixed before the release. (also see #41)

Checklist

(Strikethrough any points that are not applicable.)

  • [ ] Write unit tests for any new functionality or bug fixes.
  • [ ] Update docs if there are any API changes:
    • [ ] roxygen comments
    • [ ] vignettes
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit. This is always required before the PR can be merged.

@kelly-sovacool kelly-sovacool requested review from a team and courtneyarmour and removed request for a team October 13, 2022 03:49
@kelly-sovacool kelly-sovacool marked this pull request as ready for review October 13, 2022 19:46
@kelly-sovacool kelly-sovacool merged commit 2b07e51 into main Oct 13, 2022
@kelly-sovacool kelly-sovacool deleted the test-print-ggplot branch October 13, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneyarmour courtneyarmour courtneyarmour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3A16
Development

Successfully merging this pull request may close these issues.
2 participants
@kelly-sovacool @courtneyarmour
0