8000 remove SVFFileSystem by bjjwwang · Pull Request #1638 · SVF-tools/SVF · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

remove SVFFileSystem #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025
Merged

remove SVFFileSystem #1638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7d9f91
remove SVFFileSystem
Jan 23, 2025
979b23f
Revert "remove SVFFileSystem"
Jan 23, 2025
b9307f8
refactor "remove SVFFileSystem"
Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions svf-llvm/lib/SVFIRBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
#include "SVF-LLVM/LLVMUtil.h"
#include "SVF-LLVM/SymbolTableBuilder.h"
#include "SVFIR/PAGBuilderFromFile.h"
#include "SVFIR/SVFFileSystem.h"
#include "SVFIR/SVFModule.h"
#include "SVFIR/SVFValue.h"
#include "Util/CallGraphBuilder.h"
Expand Down Expand Up @@ -172,7 +171,7 @@
// dump SVFIR as JSON
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should comment out rather than removing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should comment out rather than removing

sure

if (!Options::DumpJson().empty())
{
SVFIRWriter::writeJsonToPath(pag, Options::DumpJson());
assert(false && "please implement SVFIRWriter::writeJsonToPath");

Check warning on line 174 in svf-llvm/lib/SVFIRBuilder.cpp

View check run for this annotation

Codecov / codecov/patch

svf-llvm/lib/SVFIRBuilder.cpp#L174 

Added line #L174 was not covered by tests
}

double endTime = SVFStat::getClk(true);
Expand Down
5 changes: 1 addition & 4 deletions svf-llvm/tools/LLVM2SVF/llvm2svf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
#include "SVF-LLVM/SVFIRBuilder.h"
#include "Util/CommandLine.h"
#include "Util/Options.h"
#include "SVFIR/SVFFileSystem.h"


using namespace std;
Expand Down Expand Up @@ -61,12 +60,10 @@
LLVMModuleSet::preProcessBCs(moduleNameVec);
}

SVFModule* svfModule = LLVMModuleSet::buildSVFModule(moduleNameVec);
const std::string jsonPath = replaceExtension(moduleNameVec.front());
// PAG is borrowed from a unique_ptr, so we don't need to delete it.
const SVFIR* pag = SVFIRBuilder(svfModule).build();

SVFIRWriter::writeJsonToPath(pag, jsonPath);
assert(false && "Please implement SVFIRWriter::writeJsonToPath");

Check warning on line 66 in svf-llvm/tools/LLVM2SVF/llvm2svf.cpp

View check run for this annotation

Codecov / codecov/patch

svf-llvm/tools/LLVM2SVF/llvm2svf.cpp#L66 

Added line #L66 was not covered by tests
SVFUtil::outs() << "SVF IR is written to '" << jsonPath << "'\n";
LLVMModuleSet::releaseLLVMModuleSet();
return 0;
Expand Down
3 changes: 1 addition & 2 deletions svf-llvm/tools/WPA/wpa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "WPA/WPAPass.h"
#include "Util/CommandLine.h"
#include "Util/Options.h"
#include "SVFIR/SVFFileSystem.h"


using namespace llvm;
Expand All @@ -49,7 +48,7 @@

if (Options::ReadJson())
{
pag = SVFIRReader::read(moduleNameVec.front());
assert(false && "please implement SVFIRReader::read");

Check warning on line 51 in svf-llvm/tools/WPA/wpa.cpp

View check run for this annotation

Codecov / codecov/patch

svf-llvm/tools/WPA/wpa.cpp#L51 

Added line #L51 was not covered by tests
}
else
{
Expand Down
Loading
Loading
0