remove SVFFileSystem #1638
Merged
remove SVFFileSystem #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1638 +/- ##
==========================================
+ Coverage 63.24% 63.73% +0.48%
==========================================
Files 247 245 -2
Lines 27518 26017 -1501
Branches 4537 4506 -31
==========================================
- Hits 17405 16582 -823
+ Misses 10113 9435 -678
|
yuleisui
reviewed
Jan 23, 2025
svf-llvm/tools/LLVM2SVF/llvm2svf.cpp
Outdated
| @@ -61,12 +61,12 @@ int main(int argc, char** argv) | |||
| LLVMModuleSet::preProcessBCs(moduleNameVec); | |||
| } | |||
|
|
|||
| SVFModule* svfModule = LLVMModuleSet::buildSVFModule(moduleNameVec); | |||
| //SVFModule* svfModule = LLVMModuleSet::buildSVFModule(moduleNameVec); | |||
There was a problem hiding this comment.
because unused var would cause compile error.
There was a problem hiding this comment.
Why unused? Which variable?
yuleisui
reviewed
Jan 23, 2025
| @@ -169,11 +169,6 @@ SVFIR* SVFIRBuilder::build() | |||
| loopAnalysis.build(pag->getICFG()); | |||
| } | |||
|
|
|||
| // dump SVFIR as JSON | |||
There was a problem hiding this comment.
Should comment out rather than removing
There was a problem hiding this comment.
Should comment out rather than removing
sure
added 2 commits
January 23, 2025 22:22
This reverts commit f7d9f91.
Geoffrey1014
pushed a commit
to Geoffrey1014/SVF
that referenced
this pull request
Jan 27, 2025
* remove SVFFileSystem * Revert "remove SVFFileSystem" This reverts commit f7d9f91. * refactor "remove SVFFileSystem" --------- Co-authored-by: bjjwwang <bjjwwang@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.