10000 Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 by nickm01 · Pull Request #942 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2020
Merged

Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1d5e0a
update docs - mention veiwDidAppear will not be called automatically …
nickm01 Dec 30, 2019
8514d3a
Apply suggestions from code review
ikesyo Oct 8, 2020
b330944
[CI] Fix running Danger on PRs from forked repos
ikesyo Oct 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- run: bundle install
- run: bundle exec danger
env:
Expand Down
6 changes: 3 additions & 3 deletions Documentation/en-us/TestingApps.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ presented within the app. When testing a `UIViewController`, however, you'll
need to trigger these yourself. You can do so in one of three ways:

1. Accessing `UIViewController.view`, which triggers things like `UIViewController.viewDidLoad()`.
2. Use `UIViewController.beginAppearanceTransition()` to trigger most lifecycle events.
2. Use `UIViewController.beginAppearanceTransition()` and `UIViewController.endAppearanceTransition()` to trigger most lifecycle events. Note - as of iOS SDK 13.0, this no longer triggers `UIViewController.viewDidAppear()`.
3. Directly calling methods like `UIViewController.viewDidLoad()` or `UIViewController.viewWillAppear()`.

```swift
Expand Down Expand Up @@ -47,7 +47,7 @@ class BananaViewControllerSpec: QuickSpec {

describe("the view") {
beforeEach {
// Method #2: Triggers .viewDidLoad(), .viewWillAppear(), and .viewDidAppear() events.
// Method #2: Triggers .viewDidLoad() and .viewWillAppear() events.
viewController.beginAppearanceTransition(true, animated: false)
viewController.endAppearanceTransition()
}
Expand Down Expand Up @@ -94,7 +94,7 @@ describe(@"-viewDidLoad", ^{

describe(@"the view", ^{
beforeEach(^{
// Method #2: Triggers .viewDidLoad(), .viewWillAppear(), and .viewDidAppear() events.
// Method #2: Triggers .viewDidLoad() and .viewWillAppear() events.
[viewController beginAppearanceTransition:YES animated:NO];
[viewController endAppearanceTransition];
});
Expand Down
0