8000 Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 by nickm01 · Pull Request #942 · Quick/Quick · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2020
Merged

Update docs - vieiwDidAppear not be called automatically in iOS SDK 13.0 #942

merged 3 commits into from
Oct 11, 2020

Conversation

nickm01
Copy link
Contributor
@nickm01 nickm01 commented Dec 30, 2019 •
edited
Loading

iOS SDK 13.0 (Xcode 11) does not call UIViewController.viewDidAppear() anymore when calling viewController.beginAppearanceTransition() and UIViewController.endAppearanceTransition() when testing views directly. This looks like a behavior change not directly related to Quick, but think the docs need to be updated.

See #941.

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@nickm01 nickm01 force-pushed the doc-correct-view-didAppear branch 3 times, most recently from e19ab0b to c595dd3 Compare December 30, 2019 22:27
ikesyo
ikesyo reviewed Apr 1, 2020
View reviewed changes
ikesyo
ikesyo reviewed Apr 1, 2020
View reviewed changes
@ikesyo ikesyo linked an issue Oct 8, 2020 that may be closed by this pull request
[documentation] iOS 13 no longer seems to trigger viewDidAppear when calling endAppearanceTransition in unit tests #941
Closed
1 task
@ikesyo ikesyo force-pushed the doc-correct-view-didAppear branch from 0254564 to 045915c Compare October 11, 2020 11:51
@ikesyo ikesyo force-pushed the doc-correct-view-didAppear branch from 045915c to b330944 Compare October 11, 2020 12:00
@ikesyo
Copy link
Member
ikesyo commented Oct 11, 2020

Thanks for the improvement! 😃

@ikesyo ikesyo merged commit 00ff94d into Quick:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[documentation] iOS 13 no longer seems to trigger viewDidAppear when calling endAppearanceTransition in unit tests
2 participants
@nickm01 @ikesyo
0