remove 'import posthog' #255
Conversation
There was a problem hiding this comment.
PR Summary
Updates import statements throughout the codebase to use specific function imports instead of the global posthog package import, improving maintainability and preventing circular dependencies.
- Modifies
posthog/sentry/posthog_integration.pyto import specific functions (capture,host) instead of the globalposthogpackage - Updates
posthog/scopes.pyto directly importcapture_exceptionrather than accessing it throughposthog.capture_exception - Removes
sedcommands from Makefile that were previously handlingposthog/posthoganalyticsimport swapping - Bumps version to 4.6.2 to reflect the import statement cleanup
5 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| rm -rf posthog | ||
| python setup_analytics.py sdist bdist_wheel | ||
| twine upload dist/* | ||
| mkdir posthog |
There was a problem hiding this comment.
logic: Removing and recreating 'posthog' directory between operations could lead to issues if twine upload fails. Consider moving directory operations after successful upload.
| @@ -39,7 +39,7 @@ def new_context(fresh=False): | |||
| raise ValueError("Something went wrong") | |||
|
|
|||
| """ | |||
| import posthog | |||
There was a problem hiding this comment.
would be cool if we can have ruff forbid this in future
There was a problem hiding this comment.
Agreed. ChatGPT is down right now and I'm having trouble googling for the right rule. Will double back
CHANGELOG.md
Outdated
There was a problem hiding this comment.
oh.. @daibhin i updated setup instructions in the readme
you need to run a command to setup the precommit hooks and then ruff will autorun on commit for you
Follow on from #254
That PR had the intended effect of replacing
import posthogwithimport posthoganalytics. I failed to realise that everywhereposthog.{method_name}was called also needed replacing. Going to try this simpler approach of never importing the entire package