fix: makefile import #254
Merged
fix: makefile import #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
reviewed
Jun 9, 2025
There was a problem hiding this comment.
oh this script is really testing my patience this week
There was a problem hiding this comment.
PR Summary
Fixed critical import handling in posthoganalytics package by updating the Makefile's release_analytics target to properly handle direct import posthog statements.
- Added new sed replacement commands in Makefile to handle plain
import posthog->import posthoganalyticsconversion - Version bumped from 4.6.0 to 4.6.1 in
posthog/version.pyfor this bugfix - Updated CHANGELOG.md to document fix for posthoganalytics package import issue
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an error when trying to use the new context scopes feature because we call
import posthog. This fails because the Makefile doesn't replace the call withimport posthoganalytics