8000 Calibration card and PV input styling by DevonRD · Pull Request #1695 · PhotonVision/photonvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Calibration card and PV input styling #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2025
Merged

Calibration card and PV input styling #1695

merged 3 commits into from
Jan 8, 2025

Conversation

DevonRD
Copy link
Contributor
@DevonRD DevonRD commented Jan 8, 2025 •
edited
Loading

Images are before and after comparison.
Does the following:

  • Fixes several styling issues with pv-* input elements, including top padding, vertical alignment, and allocated input width
    image
    image

  • Conforms the calibration details modal to overall styling and spacing standards
    image
    image
    (left the blank table there on empty calibrations to give the user a sense of what they might see if they don't have any)

@DevonRD DevonRD requested a review from a team as a code owner January 8, 2025 21:02
mcm001
mcm001 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor
@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretttyyyyyy

@DevonRD DevonRD merged commit e40c8fb into PhotonVision:main Jan 8, 2025
34 checks passed
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
@DevonRD @mcm001
Calibration card and PV input styling (PhotonVision#1695)
14a1bcb 
Images are before and after comparison.
Does the following:
- Fixes several styling issues with pv-* input elements, including top
padding, vertical alignment, and allocated input width

![image](https://github.com/user-attachments/assets/70d37e65-e0cd-4c71-8ea1-941ec2175850)

![image](https://github.com/user-attachments/assets/031d008d-3cce-4ed2-bc88-5fbecf20c94f)

- Conforms the calibration details modal to overall styling and spacing
standards

![image](https://github.com/user-attachments/assets/18281551-f924-4e12-9ad4-d2ec470dbc70)

![image](https://github.com/user-attachments/assets/db772325-7650-467d-8521-252c7d38601f)
(left the blank table there on empty calibrations to give the user a
sense of what they might see if they don't have any)
@mcm001 mcm001 mentioned this pull request Mar 16, 2025
Closed
@mcm001 mcm001 mentioned this pull request Mar 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DevonRD @mcm001
0