Fix #748 - add libopencv-core4.5 for aarch64 systems. #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled. Move the "is a package installed" code into a function.
The libphotonvision.so on Raspberry pi depends on libopencv-core4.5. The code here installs that package on all aarch64 systems, as there was not an obvious way to install on only Raspberry pi systems. Fixes PhotonVision#748.
mcm001
approved these changes
Jan 18, 2023
| @@ -50,13 +54,24 @@ else | |||
| fi | |||
|
|
|||
| echo "Installing the JDK..." | |||
| if [ $(dpkg-query -W -f='${Status}' openjdk-11-jdk-headless 2>/dev/null | grep -c "ok installed") -eq 0 ]; | |||
| if ! package_is_installed openjdk-11-jdk-headless | |||
There was a problem hiding this comment.
Technically we only need the JRE, but that's an issue for later
MrRedness
pushed a commit
to MrRedness/photonvision
that referenced
this pull request
Feb 8, 2023
…otonVision#749) * Add and use a function in install.sh to determine if package is installed. Move the "is a package installed" code into a function. * Install libopencv-core4.5 on aarch64, which is likely raspberry pi. The libphotonvision.so on Raspberry pi depends on libopencv-core4.5. The code here installs that package on all aarch64 systems, as there was not an obvious way to install on only Raspberry pi systems. Fixes PhotonVision#748. Co-authored-by: Scott Moser <smoser@brickies.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its not perfect, but I think this is a better over-all solution than PhotonVision/photonvision-docs#265