-
Notifications
You must be signed in to change notification settings - Fork 28
Add support to add custom end-effector attachments for Panda, UR5, and Fetch #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like there's a build failure with some of the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cleanup comments, but looks mostly good. Thanks for tidying up the prototype!
resources/README.md
Outdated
## Attachments | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be empty?
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
I had no idea noexcept could make an explicitly defaulted function become implicitly deleted...
c037338
to
56470cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes it would be nice to include before merge, but LGTM overall.
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
This PR adds the functionality for custom end-effector attachments for the Panda, UR5, and Fetch robots. Attachments are specified as collections of spheres at a fixed offset from the end-effector of the robot. Both this offset and the collection of spheres can be set at runtime.
An example script (
scripts/attachments.py
) is provided to demonstrate how to create an attachment, attach a colliding sphere, and plan while avoiding collisions between the attachment and the environment.