8000 Add support to add custom end-effector attachments for Panda, UR5, and Fetch by zkingston · Pull Request #18 · KavrakiLab/vamp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support to add custom end-effector attachments for Panda, UR5, and Fetch #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jun 26, 2024

Conversation

zkingston
Copy link
Contributor

This PR adds the functionality for custom end-effector attachments for the Panda, UR5, and Fetch robots. Attachments are specified as collections of spheres at a fixed offset from the end-effector of the robot. Both this offset and the collection of spheres can be set at runtime.

An example script (scripts/attachments.py) is provided to demonstrate how to create an attachment, attach a colliding sphere, and plan while avoiding collisions between the attachment and the environment.

@wbthomason
Copy link
Collaborator

Looks like there's a build failure with some of the use of std::optional on old GCC? I'll look into it in more depth tomorrow.

Copy link
Collaborator
@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup comments, but looks mostly good. Thanks for tidying up the prototype!

Comment on lines 13 to 16
## Attachments



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be empty?

zkingston and others added 4 commits June 25, 2024 09:03
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
zkingston and others added 12 commits June 25, 2024 09:04
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
I had no idea noexcept could make an explicitly defaulted function
become implicitly deleted...
Copy link
Collaborator
@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes it would be nice to include before merge, but LGTM overall.

zkingston and others added 4 commits June 26, 2024 15:56
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
Co-authored-by: Wil Thomason <wbthomason@users.noreply.github.com>
@zkingston zkingston merged commit df6120a into main Jun 26, 2024
7 checks passed
@zkingston zkingston deleted the feat/attachments branch June 26, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0