8000 transform totalbounds to 4326 before trying to guess utm by savente93 · Pull Request #1154 · Deltares/hydromt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

transform totalbounds to 4326 before trying to guess utm #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2025

Conversation

savente93
Copy link
Contributor
@savente93 savente93 commented Apr 2, 2025

Issue addressed

Fixes #1120

Explanation

to guess the nearest UTM crs the bounds need to be provided in 4326. Previously the bounds were provided in the region crs. To avoid having to reproject twice, we transform the bounds "manually"

General Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation
  • Updated changelog.rst

Data/Catalog checklist

  • data/catalogs/predefined_catalogs.yml has not been modified.
  • None of the old data_catalog.yml files have been changed
  • data/changelog.rst has been updated
  • new file uses LF line endings (done automatically if you used update_versions.py)
  • New file has been tested locally
  • Tests have been added using the new file in the test suite

Additional Notes (optional)

Add any additional notes or information that may be helpful.

Copy link
sonarqubecloud bot commented Apr 2, 2025

Copy link
Contributor
@dalmijn dalmijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@savente93 savente93 merged commit 9fc8c40 into main Apr 2, 2025
25 checks passed
@savente93 savente93 deleted the fix-utm-parsing branch April 2, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in parsing crs="utm" in hydromt.model.processes.grid.create_grid_from_region
2 participants
0