8000 potential (very small) fixes for issues #1120 and #1121 by roeldegoede · Pull Request #1122 · Deltares/hydromt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

potential (very small) fixes for issues #1120 and #1121 #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

roeldegoede
Copy link
Contributor
@roeldegoede roeldegoede commented Feb 20, 2025

Code that locally solved the raised issues. Before finalizing, I thought let's share it first to see whethet it makes any sense

@roeldegoede roeldegoede marked this pull request as draft February 20, 2025 14:29
@roeldegoede roeldegoede changed the title potential (very small) fixes for issues #1119 and #1120 potential (very small) fixes for issues #1120 and #1121 Mar 28, 2025
@savente93
Copy link
Contributor

Thanks for the suggested implementations Roel. I've taken your suggestions and split them into #1154 so that I could add a test and some docs (I didn't want to mess with you fork) #1119 was previously fixed in #1145. As soon as this gets reviewed we'll merge it and then you should be good.

@savente93
Copy link
Contributor

I'll be closing this PR as I've merged your solutions across other PRs

@savente93 savente93 closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0