update citation #300
Merged
update citation #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not crazy about using the universal DOI link to get to the Zenodo page. Perhaps we could use this: https://zenodo.org/search?page=1&size=20&q=conceptrecid:%221210316%22&sort=-version&all_versions ? Other ideas? |
|
#296 is relevant |
kandersolar
reviewed
Dec 1, 2021
There was a problem hiding this comment.
I'm not crazy about using the universal DOI link to get to the Zenodo page. Perhaps we could use this: https://zenodo.org/search?page=1&size=20&q=conceptrecid:%221210316%22&sort=-version&all_versions ?
Works for me.
Thoughts on adding linked DOIs for each of the "underlying workflow" references? Would be nice to be able to click a link instead of having to search the title.
- Robust PV degradation: 10.1109/JPHOTOV.2017.2779779
- Quantifying soiling loss: 10.1109/JPHOTOV.2017.2784682
- Overcoming communication outages: 10.1109/PVSC45281.2020.9300635
- Performance comparison of clipping detection: already listed
kandersolar
approved these changes
Dec 2, 2021
mdeceglie
added a commit
that referenced
this pull request
Dec 22, 2021
* update citation (#300) * update sphinx citation * less specific * update readme with new citation * capitalize Zenodo * further capitalization * Add DOI links to supporting refs * DOI fix * even more doi fixing * Converted dat file to json file to remove XGBoost versioning issues. (#304) * Converted dat file to json file. * Updated the xgboost versions to no latest version restriction. * Updated the model loading for xgb to handle multiple XGB versions. * debugging mac os XGB error?? * bumped xgb to lower version to handle mac OS * update versioning. * more xgboost version updates... * updated the workflows script to remove rdtools pip install. * dropped xgboost version down * updated the XGB model pull with os.path.join() * fixed pep8 issues. * Removed the joblib requirement per @kanderso's request. * Regenerated the old model and saved as a json. * run notebook for cell numbering Co-authored-by: Perry <kperry@nrel.gov> Co-authored-by: Michael Deceglie <Michael.Deceglie@nrel.gov> * Update changelog * double backticks in 2.1.1 log * add cell 2 back in * adjust changelog * add PR to a changelog entry Co-authored-by: Kirsten Perry <70228568+kperrynrel@users.noreply.github.com> Co-authored-by: Perry <kperry@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes are covered by testsCode changes have been evaluated for compatibility/integration with TrendAnalysisNew functions added to__init__.pyAPI.rst is up to date, along with other sphinx docs pagesExample notebooks are rerun and differences in results scrutinizedUpdated changelog