fix: classic currency again #384
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Packaged ZIP filesRPGLootFeed ZIP (with libs) (377680 ➡️ 377602, -0.02%) 🟢 Last Updated: 6/11/2025, 9:33:39 PM (UTC) |
d42c0ce to
a2472bc
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
546d01d to
77a7a28
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
77a7a28 to
b134a53
Compare
b134a53 to
a620c32
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses classic currency display issues and updates key currency processing logic. It adds a new stub for GetCurrencyLink in the WoWGlobals mocks, refactors pattern extraction in AddonMethods, revises the Currency module’s logging and parsing behavior, and expands Makefile targets for testing.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| RPGLootFeed_spec/_mocks/WoWGlobals/Functions.lua | Adds a stub for GetCurrencyLink for generating test currency links. |
| RPGLootFeed/utils/AddonMethods.lua | Removes legacy fallback logic in pattern segment extraction. |
| RPGLootFeed/Features/_Internals/LootDisplayProperties.lua | Adds debug logging for filtered elements. |
| RPGLootFeed/Features/Money.lua | Adds a debug log branch for zero money change. |
| RPGLootFeed/Features/Currency/Currency.lua | Refactors logging, pattern extraction, and processing of currency changes. |
| Makefile | Introduces new targets to run tests on specific files or patterns. |
Comments suppressed due to low confidence (4)
RPGLootFeed/utils/AddonMethods.lua:149
- Ensure that the removal of the fallback branch for cases when midStart is nil does not adversely affect locale strings that do not contain a number.
midPattern = string.sub(localeString, preEnd + 1, midStart - 1)
RPGLootFeed/Features/Currency/Currency.lua:251
- Update the function's documentation to reflect that it now returns only the quantityChange (a number) instead of a currency link and quantity pair.
function Currency:ParseCurrencyChangeMessage(msg)
RPGLootFeed/Features/Currency/Currency.lua:309
- Confirm that overriding currencyInfo.quantity with the parsed quantityChange when it is zero is the intended behavior and does not inadvertently alter the expected currency state.
if currencyInfo.quantity == 0 then
RPGLootFeed/Features/Currency/Currency.lua:269
- [nitpick] Verify that switching from G_RLF:LogDebug to self:LogDebug consistently throughout the module maintains the intended logging behavior and parameter order.
local currencyId = G_RLF:ExtractCurrencyID(msg)
|
🎉 This PR is included in version 1.24.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.