[pull] master from sourcegraph:master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `go test -race ./...`, a race condition is reported for a fake implementation of a filesystem for TestCheckAndStore. A mutex lock has been added into the structure functions and test to avoid the error report. Fixes #107
A special checker has been implemented that runs external commands via os.Exec. This opens up the possibility of implementing more complex, protocol-aware checks, without necessarily implementing a custom checker in Go code.
With the upgrade to a recent go version, we're upgrading to use go modules. Makefile was added to provide the proper build commands, test commands and disable cached test output with -count=1.
In order to support building with CGO_ENABLED=0, build tags were added to the sql filesystem implementation. Sqlite requires cgo, and it now needs to be explicitly enabled with `-tags sql` option at build time. Fixes #102
Tcpchecker tests were failing due to expired self signed certificates. This commit adds new certificates, a Makefile for regenerating them, and adds test output in case of similar certificate errors. Fixes #108
Fixes and improvements
The Go standard library net/http.Request struct exposes a special header, which takes effect when issuing http requests. The Host header isn't honored, so I set this Host field from a Host header if present. Closes #79
- separated types into submodule, - defined interfaces into separate go file, - defined error messages in errors.go, - split checks into /check/[name] packages, - split storage into /storage/[name] packages, - split notifiers into /notifier/[name] packages, - test cleanups, move test data into relevant packages No new features have been added, the code base has just been cleaned up to be more readable, and that individual subpackages contain their implementations. With this change, new notifiers and checks can be added, without enroaching into the main checkup package.
<
8000
div class="d-flex flex-md-row flex-column">
The notifier functions are set up to return errors. The slack notifier only issued log calls, but swallowed the error for handling in checkup runs.
I added a Type field and Type functions on checks, notifiers and storage interfaces, to avoid awkward type casting/type detection from json data and go structs
This commit fixes the issue of inconsistent type detection over storage (had 'provider'), notifier (had 'name') and check (had 'type') - not it always uses 'type'. This commit also adds support for multiple checkers via in checkup.json.
Refactoring for better separation of concerns
On GitHub Pages the files are often so good cached that old / stale data is still retrieved and not the latest version of `index.json`. Even a reload with the "disable cache" option enabled in the network settings of the browser developer tools does not help in most cases. Thus we have to bust the cache for every load by adding a timestamp in this case. There are also other solutions but these would affect all AJAX calls and this solution busts the cache for only the `index.json` file.
LSIF Indexing Campaign
Using golangci-lint several errors have been reported and fixed, updating deprecated API usage, unchecked errors, or ineffectual assignments.
- bump go dependency to 1.14 - run server by default - add docker-compose.yml file - bundle statuspage in docker image
EPIC: Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers
* New Application Insights storage plugin * Update Application Insights storage plugin - Change healthy status message to "Up" - Add support for retries - Add tests - Add documentation * Fixes PR comments - Use builtin functions and check Id - Rename TelemetryClient to client - Make max timeout configurable when retries disabled - Fix typo * Add test for valid InstrumentationKey * Make telemetryConfig private
- Change time.Duration fields to ints - Remove duplicate code
Adding '[ci skip]' made sense in the original implementation, when CI
was not often used to act on a status repo. In the age of GitHub
Actions, it would be helpful to be able to control whether this string
is appended.
The current implementation leaves "[ci skip]" enabled for all users,
and the user can optionally change it by adding this setting to their
storage configuration:
"commit_message_suffix": "user-defined-string"
If the user sets the suffix to a single space (" "), then it will be
disabled.
chore: use scip-go instead of lsif-go for precise indexing in CI
In order to be a Maintainer, the GitHub Storage implementation must respond to `Maintain()`. Unlike all the other implementations, the GitHub implementation's Maintain() method was on the pointer receiver. This fix should allow the GitHub Storage implementation to be a Maintainer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )
This change is