8000 EPIC: Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers by titpetric · Pull Request #130 · sourcegraph/checkup · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

EPIC: Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers #130

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 6, 2020
Merged

EPIC: Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers #130

merged 25 commits into from
Jul 6, 2020

Conversation

titpetric
Copy link
Contributor
@titpetric titpetric commented Jun 26, 2020 •
edited
Loading

Due to issues with SQLite (CGO, long builds), we now have:

  • sqlite3 storage provider (opt-in with make build-sqlite3)
  • postgres storage provider (built-in)
  • mysql storage provider (built-in, new)

The postgres and mysql storage providers have go-native drivers which don't require CGO, which also means fast build times and wider database support. The current sql implementation is deprecated (but not outright disabled, which will be the next step after some time). The current sql implementation also doesn't work on postgresql due to invalid SQL query placeholders.

Additionally, a full integration test has been added for both postgres and mysql databases, using Drone CI. To run the test suite, you should install drone-cli locally, and run drone exec. Both storage drivers are integration tested against a real database now.

Other minor changes:

  • mailgun value for to changes from string to []string, for multiple recipients,
  • updated README.md with latest documentation for the new storage providers,
  • minor documentation updates to README for mailgun, some godoc link names, and features

PTAL @beyang

titpetric added 22 commits June 26, 2020 14:06
@titpetric
checkup: deprecate sql backend
d8eb1b9
@titpetric
checkup: add postgres storage backend
ad74b2d
@titpetric
checkup: add sqlite storage backend
def0b3f
@titpetric
checkup: add drone CI integration tests, update makefile, go.sum
234dda0
@titpetric
checkup: add mysql storage backend
e57ac81
@titpetric
checkup: clean up postgres connection string code
80fa4cc
@titpetric
checkup: add mysql integration test drone service
939ad0c
@titpetric
checkup: enable storage back-ends for mysql, postgresql and sqlite, u…
0089c2f 
…pdate go.mod
@titpetric
storage/sqlite: rename to sqlite3 to match driver name/version
1bdafab
@titpetric
notifier/mailgun: update 'to' recipients to a list of addresses
4468729
@titpetric
storage/postgres: throw away verbose config in favor of a dsn config …
d0527fb 
…parameter
@titpetric
checkup: update README.md documentation for checks, storage (new), ma…
a572549 
…ilgun change
@titpetric
fix: trim possible trailing slash in status page config url
f045704
@titpetric
checkup: immediately run first check when starting checkup
c32c77f
@titpetric
storage/fs: create output folder for storage
fadbf8c
@titpetric
checkup: don't swallow output logs anymore
91f5139
@titpetric
checkup/cmd: add serve command to setup/serve checks from configured …
09488d4 
…storage
@titpetric < 8000 /a>
statuspage: add storage.type to configure storage driver from config
2301dcb
@titpetric
statuspage: create an instance of storage driver based on config
a9736ea
@titpetric
statuspage: load both fs and s3 storage drivers now
094dbb0
@titpetric
checkup: update readme with recent statuspage changes
0b9428d
@titpetric
tests: fix test for checks, checks now run immediately
d0eed6b
@titpetric
Copy link
Contributor Author

Additional changes after initial PR:

  • Checkup: with new storage providers, I added a serve command to load/serve checks from a range of providers (fs, sqlite3, postgres, mysql),
  • Checkup every checks - first check runs immediately. Before it waited before running the first check.
  • Statuspage: enable both FS and S3 drivers and use configuration to load the appropriate one (more friendly configuration)
  • Statuspage: set up reasonable defaults for config.js with new caddy serve,
  • Update README for all

This was referenced Jun 26, 2020
Closed
Closed
@titpetric titpetric changed the title Feature/pgsql sqlite split Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers Jun 28, 2020
@titpetric
checkup: improve dockerfile
96ab470 
- bump go dependency to 1.14
- run server by default
- add docker-compose.yml file
- bundle statuspage in docker image
@titpetric titpetric requested a review from beyang June 29, 2020 07:05
@titpetric titpetric changed the title Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers EPIC: Split sql to sqlite/postgresql, Add mysql storage, Discord notifications, Local server for storage providers Jun 29, 2020
@titpetric titpetric merged commit 0624503 into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyang beyang beyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titpetric @beyang
0