8000 Fixing Kubelet Exec Probe Timeouts · Issue #1972 · kubernetes/enhancements · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Kubelet Exec Probe Timeouts #1972

Open
andrewsykim opened this issue Sep 8, 2020 · 52 comments
Open

Fixing Kubelet Exec Probe Timeouts #1972

andrewsykim opened this issue Sep 8, 2020 · 52 comments
Assignees
@tallclair
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@andrewsykim
Copy link
Member
andrewsykim commented Sep 8, 2020 •
edited by SergeyKanzhelev
Loading

Enhancement Description

  • One-line enhancement description (can be used as a release note):

Fix kubelet exec probe timeouts not being respected.

@tallclair

previously:

SIG Node

  • Enhancement target (which target equals to which milestone):
    • Stable release target v1.33

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 8, 2020
@andrewsykim
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2020
@andrewsykim andrewsykim mentioned this issue Sep 8, 2020
Merged
@kikisdeliveryservice
Copy link
Member

Hi @andrewsykim

Enhancements lead here 👋

Just to be sure: this is intended to go directly to stable in 1.20?

Thanks!
Kirsten

@SergeyKanzhelev
Copy link
Member

Just to be sure: this is intended to go directly to stable in 1.20?

That's the plan we discussed at SIG Node meeting

@kikisdeliveryservice
Copy link
Member

Perfect - thanks for the update @SergeyKanzhelev !

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 14, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Sep 14, 2020
@kendallroden
Copy link
kendallroden commented Sep 28, 2020 •
edited
Loading

Hi @SergeyKanzhelev, wanted to check in on the status of this enhancement. In order for this to be considered for the 1.20 release, the KEP needs to be fully completed and merged by the Enhancements Freeze on 10/6.

Feel free to reach out with any questions or updates!

Thanks,

Kendall
1.20 Enhancements Team

@SergeyKanzhelev
Copy link
Member

thank you for the ping. I must have an update tomorrow.

@kendallroden
Copy link

Hey @SergeyKanzhelev!

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks so much,

Kendall

@SergeyKanzhelev SergeyKanzhelev mentioned this issue Oct 14, 2020
Merged
@kcmartin
Copy link

Hello @SergeyKanzhelev , 1.20 Docs shadow here.

Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@SergeyKanzhelev
Copy link
Member

I will look at it this week

@SergeyKanzhelev SergeyKanzhelev mentioned this issue Oct 22, 2020
Merged
@SergeyKanzhelev
Copy link
Member

Started: kubernetes/website#24692

@kcmartin
Copy link
kcmartin commented Nov 2, 2020 •
edited
Loading

Hi @SergeyKanzhelev

Thanks for creating the docs PR!

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

Hi @SergeyKanzhelev

kubernetes/kubernetes#94115 has merged and this is done for code freeze. Marking as done unless there is some other work in progress.

Thanks!
Kirsten

@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 7, 2021
@annajung
Copy link
Contributor
annajung commented Jan 7, 2021

Hi @SergeyKanzhelev 1.21 Enhancement Lead here.

Can you update the kep.yaml to reflect a status of implemented:

enhancements/keps/sig-node/1972-kubelet-exec-probe-timeouts/kep.yaml

Line 8 in 35069fd

status: implementable

Once that merges, we can close out this issue.

@SergeyKanzhelev SergeyKanzhelev mentioned this issue Jan 8, 2021
Merged
This was referenced Jan 19, 2021
Merged
Closed
@zoetrope zoetrope mentioned this issue Jan 25, 2021
Closed
5 tasks
@annajung
Copy link
Contributor

Hi, I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

@SergeyKanzhelev SergeyKanzhelev mentioned this issue Mar 9, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 2, 2023
@vaibhav2107
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 1, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 25, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-cl 8000 osed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlory carlory mentioned this issue Oct 11, 2024
Closed
@sftim
Copy link
Contributor
sftim commented Oct 12, 2024

/reopen
This was closed as "Not Planned" but is also generally available. Some cleanup is needed; at a minimum, to close the issue as implemented.

@k8 8000 s-ci-robot k8s-ci-robot reopened this Oct 12, 2024
@k8s-ci-robot
Copy link
Contributor

@sftim: Reopened this issue.

In response to this:

/reopen
This was closed as "Not Planned" but is also generally available. Some cleanup is needed; at a minimum, to close the issue as implemented.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor
sftim commented Oct 12, 2024

In kubernetes/kubernetes#127995 I mentioned:

Hmm, I'd have used a beta or deprecated gate for that rather than GA (for example: LegacyExecProbeBehavior, off by default, later removed). Using a Legacy* or Insecure* feature gate makes it obvious what we recommend people do (ie, not to enable these gates).

There is possibly a lesson to identify here.

@SergeyKanzhelev
Copy link
Member

There is possibly a lesson to identify here.

Yes, we are trying to avoid straight to GA KEPs. Bug fixes with the feature gate have a much less impact.

@carlory carlory mentioned this issue Nov 7, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
@SergeyKanzhelev
Copy link
Member

/reopen
/remove-lifecycle rotten

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Nov 15, 2024
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 15, 2024
@SergeyKanzhelev
Copy link
Member

As per: kubernetes/kubernetes#127995 (comment)

/assign @tallclair

/unassign @jackfrancis
/unassign @SergeyKanzhelev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tallclair tallclair

Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0