[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

dom_walden (Dom Walden)
Test Engineer for Community Tech and Trust and Safety Product

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2018, 4:33 PM (318 w, 5 d)
Availability
Available
LDAP User
Dom Walden
MediaWiki User
DWalden (WMF) [ Global Accounts ]

Recent Activity

Fri, Nov 29

dom_walden moved T378622: Restrict Special:GlobalContributions tag filtering to software defined tags from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

I can filter on tags.

Fri, Nov 29, 1:41 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), CheckUser-GlobalContributions, Trust and Safety Product Team
dom_walden moved T378155: Special:GlobalContributions ignores namespace in links from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

I see that we are displaying and linking to local namespaces correctly, even custom ones.

Fri, Nov 29, 11:59 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Temporary accounts (Create/update essential tools/anti-abuse management), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Patch-For-Review, Trust and Safety Product Team, CheckUser-GlobalContributions

Thu, Nov 28

dom_walden moved T377721: Custom reason text input inappropriately removing spaces from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

I can no longer reproduce the bug.

Thu, Nov 28, 12:54 PM · MW-1.44-notes (1.44.0-wmf.6; 2024-12-03), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)

Wed, Nov 27

dom_walden added a comment to T374196: Text misaligned when switching directionality using CodeMirror in 2017 Source Editor.

I wasn't able to repro with or without the 2017 editor. If could file a bug that'd be awesome. Thanks Dom!!

Wed, Nov 27, 1:49 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Community-Tech (Jackal (not a fox) Fox), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
dom_walden created T380983: textarea loses focus after disabling syntax highlighting.
Wed, Nov 27, 1:47 PM · VisualEditor, Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
dom_walden added a comment to T379215: Codex Special:Block: Reset form after saving block.

@dom_walden looks like the issue you found has magically been fixed. Can you confirm please?

Wed, Nov 27, 1:35 PM · Patch-For-Review, MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)

Tue, Nov 26

dom_walden moved T378685: Autoblock may not be created if user is not in local actor table or localuser from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

I cannot reproduce the bug for either named and temporary accounts.

Tue, Nov 26, 11:15 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), CheckUser, GlobalBlocking, Trust and Safety Product Team
dom_walden moved T378350: Global block may not be created if expired block has not been pruned from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

Thanks. I cannot reproduce the original bug nor T378350#10331103.

Tue, Nov 26, 11:01 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), GlobalBlocking, Trust and Safety Product Team
dom_walden moved T378353: Autoblock expiry always set to 24 hours when updating from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

@dom_walden Thanks for finding this. I have reproduced this but in a way that I think means that it is the intended behaviour. I say this because:

  • We do not extend the expiry of global autoblocks when the parent global block has their expiry lengthened. This is the expected behaviour as this matches what is done for local autoblocks.
  • When an IP is then retroactively autoblocked it updates the expiry such that the expiry for the last used IP address will be 24 hours.

This means that it appears that the block modification has updated the expiry for one of the global autoblocks to 24 hours while leaving the others intact.

Tue, Nov 26, 10:50 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Team, GlobalBlocking
dom_walden moved T374196: Text misaligned when switching directionality using CodeMirror in 2017 Source Editor from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

Thanks. I cannot reproduce that bug anymore.

Tue, Nov 26, 10:02 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Community-Tech (Jackal (not a fox) Fox), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
dom_walden created T380840: "Uncaught TypeError: view is null" second time I enable syntax highlighting.
Tue, Nov 26, 9:51 AM · Patch-For-Review, VisualEditor, Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
dom_walden moved T376754: Codex Special:Block: require confirmation for "hide username" and for self-blocking from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

Hide username

Tue, Nov 26, 9:34 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Actual multiblocks), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Community-Tech (Jackal (not a fox) Fox)
dom_walden moved T362718: Admins should be able to set a page(s) level block from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

I can confirm the acceptance criteria appear to be met.

Tue, Nov 26, 9:20 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden moved T376744: Codex Special:Block: all accordions should indicate number of entries from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

What we have done appears consistent with acceptance criteria:

Tue, Nov 26, 8:24 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden added a comment to T379537: The menu links in active blocks table are sometimes for the wrong user.

This looks like it was fixed as part of T379162, where the target field was changed to treat blur as the same as selecting a value from the dropdown.

I don't think there's anything else remaining, and I can't reproduce this bug now.

Tue, Nov 26, 8:11 AM · Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)

Mon, Nov 25

dom_walden moved T377725: Block log table does not show hidden blocks from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

We now have a separate table called "Suppressed block log", which appears to only return suppressed block creations and modifications.

Mon, Nov 25, 4:13 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox), Codex Special:Block
dom_walden added a comment to T379106: Remove API call for CentralAuth token from CheckUserApiRequestAggregator.

@dom_walden Does this fix issues you were seeing with getting Special:GlobalContributions to work locally?

Mon, Nov 25, 2:23 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Temporary accounts (Create/update essential tools/anti-abuse management)
dom_walden added a comment to T379049: How should infobox handle pagination in Special:Contributions for temporary accounts?.

IP Info isn't a table so it doesn't have pagination? Is the issue that we need to explain that the IP Infobox is showing information for the last used IP address of a temp account?

Mon, Nov 25, 2:01 PM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Trust and Safety Product Team, IP Info

Wed, Nov 20

dom_walden updated Other Assignee for T379215: Codex Special:Block: Reset form after saving block, removed: dom_walden.
Wed, Nov 20, 7:23 AM · Patch-For-Review, MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)

Tue, Nov 19

dom_walden updated Other Assignee for T362718: Admins should be able to set a page(s) level block, added: dom_walden.
Tue, Nov 19, 4:27 PM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden added a comment to T379215: Codex Special:Block: Reset form after saving block.

@HMonroy I am finding that if I load an existing block (Special:Block/<target>) which already has page and/or namespaces set, then when I submit the block the page and namespace input and block type radio is not reset.

Tue, Nov 19, 10:24 AM · Patch-For-Review, MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden moved T378551: Create a way to unprotect an abuse filter from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

I have run this against a few filters. Protected, public filters become public filters. Protected, private filters become private. Unprotected filters are unchanged.

Tue, Nov 19, 7:48 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Temporary accounts (Create/update essential tools/anti-abuse management), Trust and Safety Product Team, AbuseFilter
dom_walden moved T377765: Do not allow protecting abuse filters if PII variables are not used from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.
  • Remove the "protect" checkbox from the form. (This means a filter can't be protected without protected variables.)
  • After clicking save, show a warning with a "protect" checkbox if the filter contains protected variables
  • Without checking this box, it is impossible to save the filter
Tue, Nov 19, 7:35 AM · Patch-For-Review, Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Trust and Safety Product Team, AbuseFilter

Mon, Nov 18

dom_walden moved T380085: Special:PasswordReset can be submitted with the username as a temporary account from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

Temporary accounts lead to a validation error ~2024-10 isn't a valid username.

Mon, Nov 18, 2:34 PM · MW-1.43-notes, Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Temporary accounts (Update MediaWiki Core to introduce temp accounts), Trust and Safety Product Team
dom_walden moved T375505: Temp accounts Grafana Dashboard: Rate of temporary account creation from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)) board.

I see:

  • Rate of temporary account autocreation (which appears to be a total across all wikis)
  • Rate of temporary account autocreation by wiki, account type (looks very similar to the previous graph but broken down by wiki)
  • Rate of account creation by wiki (I am not sure what this is showing me, the number of account creations are lower than in the previous two graphs)
Mon, Nov 18, 2:28 PM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment)
dom_walden added a comment to T378353: Autoblock expiry always set to 24 hours when updating.

@Dreamy_Jazz Should all the parent's autoblocks be updated at the same time? I find that if I have two autoblocks and update the parent block's expiry to be longer than that of the autoblocks, only one autoblock gets its expiry updated (although other fields are updated on all autoblocks).

Mon, Nov 18, 2:14 PM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Team, GlobalBlocking
dom_walden added a comment to T378350: Global block may not be created if expired block has not been pruned.

@Dreamy_Jazz If the autoblock is not pruned as well when re-creating the expired parent block, then the gb_autoblock_parent_id is not updated (but the gb_expiry is). If you then delete the parent block, the autoblock remains.

Mon, Nov 18, 1:19 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), GlobalBlocking, Trust and Safety Product Team
dom_walden moved T345818: Store client hint mapping rows for login events from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I see client hints being stored for both failed and successfully logins.

Mon, Nov 18, 9:18 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), FY2024-25 WE4.2, Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, http-client-hints (Release 2 (iteration, increase data collection coverage)), CheckUser, Google-Chrome-User-Agent-Deprecation

Fri, Nov 15

dom_walden moved T326934: Investigate what is needed to update FlaggedRevs extension for Temporary accounts from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

QA Notes (for r1078969, r1079298)
...

Fri, Nov 15, 10:24 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Team, FlaggedRevs, Temporary accounts
dom_walden moved T356105: Instrument data sources used in IPInfo from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

Opening IPInfo popups and infoboxes on testwiki, I see requests made to https://intake-analytics.wikimedia.org/v1/events.

Fri, Nov 15, 8:55 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Team, IP Info

Thu, Nov 14

dom_walden added a project to T378525: Use cross-wiki permissions checks to determine what a user should see in Special:GlobalContributions: CheckUser-GlobalContributions.
Thu, Nov 14, 2:43 PM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), CheckUser-GlobalContributions, MW-1.44-notes (1.44.0-wmf.3; 2024-11-12)
dom_walden moved T379639: Special:RenameUser suggests temporary account usernames in the 'Current username' username dropdown from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I don't see temp account name suggested on Special:RenameUser.

Thu, Nov 14, 2:40 PM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Temporary accounts (Update MediaWiki Core to introduce temp accounts), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team
dom_walden moved T379638: Special:EmailUser suggests temporary account usernames in the user dropdown from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I no longer see temp users in the suggestions dropdown on Special:EmailUser.

Thu, Nov 14, 2:38 PM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Temporary accounts (Update MediaWiki Core to introduce temp accounts), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team
dom_walden updated the task description for T379910: "Expectation (writes <= 0) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 1) in trx #6506f74e40: role-primary: INSERT INTO `logging` (log_type,log_action,log_timestamp,log_actor,log_namespace,log_title,log_page,log_params,log_comment_id) VALUES '?'" (Special:AbuseLog/<log id>).
Thu, Nov 14, 12:59 PM · AbuseFilter, Trust and Safety Product Team
dom_walden created T379910: "Expectation (writes <= 0) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 1) in trx #6506f74e40: role-primary: INSERT INTO `logging` (log_type,log_action,log_timestamp,log_actor,log_namespace,log_title,log_page,log_params,log_comment_id) VALUES '?'" (Special:AbuseLog/<log id>).
Thu, Nov 14, 12:57 PM · AbuseFilter, Trust and Safety Product Team
dom_walden moved T304944: IPInfo popup obscured by "Compare selected revisions" button on revision history on Minerva from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

The IPInfo popup now appears above the "Compare selected revisions" button.

Thu, Nov 14, 12:01 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.44-notes (1.44.0-wmf.1; 2024-10-29), Trust and Safety Product Team, MinervaNeue, IP Info
dom_walden moved T379083: TransactionProfiler warnings when user sees the value of a protected variable using the 'abuselog' query API from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

Making an API request to action=query&list=abuselog I no longer see the TransactionProfiler warnings.

Thu, Nov 14, 11:57 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, AbuseFilter
dom_walden moved T378340: TransactionProfiler warnings when using Special:IPInfo from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I submitted a Special:IPInfo request with the agreement checkbox checked. I did not see a TransactionProfiler warning in the logs.

Thu, Nov 14, 11:33 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, IP Info
dom_walden moved T378178: Remove account autocomplete from Special:GlobalContributions from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I don't see autocomplete anymore, nor are API requests made in the background.

Thu, Nov 14, 10:38 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser-GlobalContributions
dom_walden created T379894: "(no username available)" shown twice for hidden revisions.
Thu, Nov 14, 9:23 AM · CheckUser-GlobalContributions, Trust and Safety Product Team
dom_walden added a comment to T379107: Show a warning in Special:GlobalContributions if a permissions lookup at an external wiki fails.

I also notice that sometimes the These results may be incomplete because you do not have the right to view IP addresses used by temporary accounts at every wiki. is shown twice, presumably if there are multiple wikis you don't have permissions for.

Thu, Nov 14, 9:23 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Temporary accounts (Create/update essential tools/anti-abuse management)

Wed, Nov 13

dom_walden created T379766: Expectation (writes <= 0) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 1).
Wed, Nov 13, 3:07 PM · CheckUser-GlobalContributions, Trust and Safety Product Team

Tue, Nov 12

dom_walden moved T378111: Special:IPContributions and Special:GlobalContributions should show an error for large IP range targets from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I now see an error message when entering a CIDR range larger than 16 for IPv4 and 32 for IPv6. The two error messages you see are consistent.

Tue, Nov 12, 2:02 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Temporary accounts (Blockers to minor pilot wiki deployment), CheckUser-GlobalContributions
dom_walden moved T375503: Temp accounts Grafana Dashboard: Rate of page deletions from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

We now have a chart for "Rate of page deletions".

Tue, Nov 12, 1:54 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Temporary accounts (Blockers to minor pilot wiki deployment)
dom_walden moved T375501: Temp accounts Grafana Dashboard: Rate of reverts & rollbacks from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I see that we now have a chart called "Revert rate" which has some data in it.

Tue, Nov 12, 1:53 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.27; 2024-10-15), Temporary accounts (Blockers to minor pilot wiki deployment)
dom_walden added a comment to T374196: Text misaligned when switching directionality using CodeMirror in 2017 Source Editor.

I cannot reproduce the misalignment issues from the description.

Tue, Nov 12, 11:09 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Community-Tech (Jackal (not a fox) Fox), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
dom_walden added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

@dom_walden @Bhsd Could I get you to test the scenarios where you saw misalignment once more? It for sure isn't completely resolved, but r1087618 should have helped.

Tue, Nov 12, 10:39 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
dom_walden created T379607: "View full log" link in the Suppressed blocks table links to type=block, should be suppress.
Tue, Nov 12, 10:04 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden added a comment to T376744: Codex Special:Block: all accordions should indicate number of entries.

@dmaza I find that sometimes after clearing the target input (by pressing the x or deleting the input) the log tables clear but the counts remain.

Tue, Nov 12, 9:13 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden updated Other Assignee for T376744: Codex Special:Block: all accordions should indicate number of entries, added: dom_walden.
Tue, Nov 12, 7:17 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)

Mon, Nov 11

dom_walden added a comment to T377725: Block log table does not show hidden blocks.

@Samwilson A couple of things I have noticed from testing so far:

  • letype=suppress will not just include blocks. It will also include things like suppressing a page. If you suppress the page User:<target>, in Special:Block/<target> the Suppressed blocks table will include a row for the suppression of that page.
  • The Target column is always blank for me.
Mon, Nov 11, 3:52 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox), Codex Special:Block
dom_walden moved T368062: Populate table component with active blocks from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

I have seen we have an "Active blocks" table which includes the current block. I have tested for named users, temp users, IPs and IP ranges.

Mon, Nov 11, 1:59 PM · Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden renamed T379554: Incorrect escaping of temporary usernames in some errors messages from Incorrect escaping of temporary usernames in the "...is already blocked" message to Incorrect escaping of temporary usernames in some errors messages.
Mon, Nov 11, 1:35 PM · Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)
dom_walden created T379554: Incorrect escaping of temporary usernames in some errors messages.
Mon, Nov 11, 1:20 PM · Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)
dom_walden created T379537: The menu links in active blocks table are sometimes for the wrong user.
Mon, Nov 11, 10:07 AM · Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)

Thu, Nov 7

dom_walden moved T378586: After saving, refresh block log tables from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.

I see the block log being updated every time I submit a block successfully.

Thu, Nov 7, 3:13 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)

Wed, Nov 6

dom_walden renamed T379167: Some UI components overlap the Vector 2022 menus from Overlapping Vector 2022 menus to Some UI components overlap the Vector 2022 menus.
Wed, Nov 6, 3:19 PM · Design-System-Team, Multiblocks (Implement Codex Special:Block), Community-Tech
dom_walden created T379167: Some UI components overlap the Vector 2022 menus.
Wed, Nov 6, 3:18 PM · Design-System-Team, Multiblocks (Implement Codex Special:Block), Community-Tech
dom_walden created T379162: Invalid value "" for user parameter "user".
Wed, Nov 6, 2:36 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)
dom_walden updated Other Assignee for T368062: Populate table component with active blocks, added: dom_walden.
Wed, Nov 6, 11:44 AM · Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)
dom_walden updated Other Assignee for T378586: After saving, refresh block log tables, added: dom_walden.
Wed, Nov 6, 11:43 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech (Jackal (not a fox) Fox), Multiblocks (Implement Codex Special:Block)
dom_walden added a comment to T362718: Admins should be able to set a page(s) level block.

Did we want a limit to the number of pages a user can enter? In the OOUI Special:Block form the limit is 10 pages. I don't remember the reason this number was chosen. @MusikAnimal

Wed, Nov 6, 11:32 AM · MW-1.44-notes (1.44.0-wmf.4; 2024-11-19), Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox)

Tue, Nov 5

dom_walden updated the task description for T379049: How should infobox handle pagination in Special:Contributions for temporary accounts?.
Tue, Nov 5, 11:42 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Trust and Safety Product Team, IP Info
dom_walden moved T376788: Audit extensions and configs that might need testing before minor pilot wikis release from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

Reviewing the Special:Version and configs of the proposed wikis, I came up with this list and include any testing I did:

Tue, Nov 5, 10:26 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Temporary accounts (Blockers to minor pilot wiki deployment)
dom_walden moved T349715: Show IPInfo infobox on Special:Contributions for temporary accounts from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I have looked at the infobox on Special:Contributions for temporary accounts and for IP addresses.

Tue, Nov 5, 9:45 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), IP Info, MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Temporary accounts (Blockers to minor pilot wiki deployment)
dom_walden created T379049: How should infobox handle pagination in Special:Contributions for temporary accounts?.
Tue, Nov 5, 9:42 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), Trust and Safety Product Team, IP Info
dom_walden moved T349716: Show IPInfo popup for temporary accounts from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I have checked that the correct IP is being looked up for revisions, archived revisions and log entries (for the performer).

Tue, Nov 5, 9:06 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), IP Info, Temporary accounts (Blockers to minor pilot wiki deployment)

Mon, Nov 4

dom_walden moved T376885: TypeError: Argument 2 passed to MediaWiki\Extension\AbuseFilter\ProtectedVarsAccessLogger::logViewProtectedVariableValue() must be of the type string, null given from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I cannot reproduce this exception for either the autocreateaccount or createaccount actions.

Mon, Nov 4, 9:28 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment), AbuseFilter, Trust-and-Safety
dom_walden added a comment to T378111: Special:IPContributions and Special:GlobalContributions should show an error for large IP range targets.

@Tchanders I am finding for IPv6 that if I enter, for example, /16 I am told The IP range exceeds its maximum range. Allowed range: /19.

Mon, Nov 4, 8:56 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Temporary accounts (Blockers to minor pilot wiki deployment), CheckUser-GlobalContributions
dom_walden moved T378810: Namespace select is blank from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I see the namespace select populated with what appear to be the correct namespaces in a few different special pages, including Special:Contributions, Special:Export (with $wgExportFromNamespaces) and Special:MovePage. When submitting the form with a namespace selected it appeared to return results from that namespace.

Mon, Nov 4, 8:27 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-HTMLForm, Trust and Safety Product Team
dom_walden added a comment to T377722: "Editing their own talk page" option should be hidden if block is partial or User_talk namespace not restricted.

I'm assuming that the description didn't mean to have "not" and say, that when the block is partial and selecting the "User_talk" namespace, "Editing their own talk page" should be hidden since they are being blocked for all User_talk namespace, which includes their own talk page, right?

Yep! That's my understanding too. @dom_walden are we thinking about this correctly, or are things backwards?

Mon, Nov 4, 6:52 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Community-Tech (Jackal (not a fox) Fox), Multiblocks, Codex Special:Block

Fri, Nov 1

dom_walden moved T376612: Implement Global Contributions as a central page on Meta and implement redirects from other projects from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I see that https://test.wikipedia.org/wiki/Special:GlobalContributions/127.0.0.1 redirects to https://meta.wikimedia.org/wiki/Special:GlobalContributions/127.0.0.1.

Fri, Nov 1, 2:09 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.44-notes (1.44.0-wmf.1; 2024-10-29), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment), CheckUser-GlobalContributions, Stewards-and-global-tools
dom_walden moved T377584: Temporarily restrict local access to Special:GlobalContributions from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I see that on https://meta.wikimedia.org/wiki/Special:ListGroupRights the rights checkuser-temporary-account and checkuser-temporary-account-no-preference do not appear at all.

Fri, Nov 1, 2:00 PM · Temporary accounts, Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), CheckUser-GlobalContributions, Trust and Safety Product Team
dom_walden moved T369610: Give the `abusefilter-access-protected-vars` right to global maintainers from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

On testwiki:

  • sysop has abusefilter-access-protected-vars but does not have abusefilter-protected-vars-log
  • checkuser has abusefilter-protected-vars-log but does not have abusefilter-access-protected-vars
Fri, Nov 1, 1:56 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment), Trust and Safety Product Team, AbuseFilter
dom_walden moved T373318: CannotCreateActorException: Cannot create an actor for an IP user when temporary accounts are enabled from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I did not see an exception when importing an article which had an IP edit which added a category.

Fri, Nov 1, 1:53 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.26; 2024-10-08), Temporary accounts (Blockers to minor pilot wiki deployment), Wikimedia-production-error
dom_walden added a comment to T378179: Restrict namespace filtering on Special:GlobalContributions to common namespaces.

Change #1084130 merged by jenkins-bot:

[mediawiki/core@master] Support 'include' parameter in namespace select inputs

https://gerrit.wikimedia.org/r/1084130

Fri, Nov 1, 1:23 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser-GlobalContributions
dom_walden created T378810: Namespace select is blank.
Fri, Nov 1, 1:21 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-HTMLForm, Trust and Safety Product Team
dom_walden moved T377829: Hide auto-promotions into the local 'checkuser-temporary-account-viewer' group in Special:RecentChanges from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I don't see an RC entry when I set:

  • $wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ]; or
  • $wgAutopromoteOnceRCExcludedGroups = [ 'checkuser-temporary-account-viewer', 'captain' ];
Fri, Nov 1, 1:12 PM · Temporary accounts (Create/update essential tools/anti-abuse management), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser
dom_walden moved T373524: Support temporary account-related logs from other extensions in CheckUser from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

While testing T365743, I saw AbuseFilter logs being recorded in the CheckUser temporary account log on my local docker environment.

Fri, Nov 1, 11:49 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Trust and Safety Product Team, Temporary accounts, CheckUser
dom_walden moved T377553: MediaWiki:Abusefilter-edit-protected message is misleading from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

Moving to Done as this is just a copy change to en.json.

Fri, Nov 1, 11:41 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Voice & Tone, AbuseFilter
dom_walden moved T378179: Restrict namespace filtering on Special:GlobalContributions to common namespaces from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

The namespaces listed are:

all
(Main)
Talk
User
User talk
Mediawiki
Mediawiki talk
File
File talk
MediaWiki
MediaWiki talk
Template
Template talk
Help
Help talk
Category
Category talk
Fri, Nov 1, 11:40 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser-GlobalContributions
dom_walden added a comment to T377829: Hide auto-promotions into the local 'checkuser-temporary-account-viewer' group in Special:RecentChanges.

@mszabo I have in my LocalSettings.php:

$wgAutopromoteOnce = [
	'onEdit' => [
		'checkuser-temporary-account-viewer' => [ APCOND_EDITCOUNT, 0 ],
	]
];
$wgAutopromoteRCExcludedGroups = [ 'checkuser-temporary-account-viewer' ];
$wgAutopromoteOnceLogInRC = true;
Fri, Nov 1, 11:34 AM · Temporary accounts (Create/update essential tools/anti-abuse management), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser
dom_walden added a comment to T378178: Remove account autocomplete from Special:GlobalContributions.

@mszabo I see that Special:GlobalContributions still makes the API request api.php?action=query&format=json&list=allusers&auprefix=<search>&aulimit=10&auexcludenamed=1&auexcludetemp=1. If it is excluding temp and named users, I assume this will never return anything. Should we just stop making the request at all and save some bandwidth?

Fri, Nov 1, 10:18 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Trust and Safety Product Team, CheckUser-GlobalContributions
dom_walden moved T378032: ParamValidator rejects temporary usernames where the local account does not exist from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I used the API to globally block a temp and named user which did not exist on the local wiki.

Fri, Nov 1, 8:30 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Action-API, Trust and Safety Product Team, Temporary accounts

Oct 31 2024

dom_walden moved T378447: TypeError: Argument 1 passed to MediaWiki\Extension\GlobalBlocking\Services\GlobalBlockLookup::getAutoblockReason() must be an instance of stdClass, bool given from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I cannot reproduce the bug in the description.

Oct 31 2024, 3:36 PM · MW-1.44-notes (1.44.0-wmf.1; 2024-10-29), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Patch-For-Review, Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), GlobalBlocking, Trust and Safety Product Team
dom_walden moved T378563: Error: Call to undefined method MediaWiki\Extension\GlobalBlocking\GlobalBlock::getParentBlockId() from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I cannot reproduce the exception from the description, and autoblocks do correctly block account creations.

Oct 31 2024, 1:57 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Blocks, GlobalBlocking, Trust and Safety Product Team
dom_walden moved T377855: API list=globalblocks can reveal IP of autoblock if username and IP are included in the bgtargets parameter from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I can no longer reproduce this bug.

Oct 31 2024, 10:09 AM · SecTeam-Processed, Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), Temporary accounts (Blockers to minor pilot wiki deployment), Trust and Safety Product Team, GlobalBlocking, Security, Security-Team
dom_walden moved T378085: /wiki/Special:GlobalBlock Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'commonswiki' from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I cannot reproduce the bug.

Oct 31 2024, 10:09 AM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.44-notes (1.44.0-wmf.1; 2024-10-29), Trust and Safety Product Team, CheckUser, GlobalBlocking
dom_walden created T378685: Autoblock may not be created if user is not in local actor table or localuser.
Oct 31 2024, 9:30 AM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), CheckUser, GlobalBlocking, Trust and Safety Product Team

Oct 30 2024

dom_walden added a comment to T378563: Error: Call to undefined method MediaWiki\Extension\GlobalBlocking\GlobalBlock::getParentBlockId().

@Dreamy_Jazz I think this change means autoblocks won't block account creation, even when they should.

Oct 30 2024, 2:26 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Blocks, GlobalBlocking, Trust and Safety Product Team
dom_walden updated the task description for T378563: Error: Call to undefined method MediaWiki\Extension\GlobalBlocking\GlobalBlock::getParentBlockId().
Oct 30 2024, 8:19 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Blocks, GlobalBlocking, Trust and Safety Product Team
dom_walden updated the task description for T378563: Error: Call to undefined method MediaWiki\Extension\GlobalBlocking\GlobalBlock::getParentBlockId().
Oct 30 2024, 8:17 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Blocks, GlobalBlocking, Trust and Safety Product Team
dom_walden created T378563: Error: Call to undefined method MediaWiki\Extension\GlobalBlocking\GlobalBlock::getParentBlockId().
Oct 30 2024, 7:06 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MediaWiki-Blocks, GlobalBlocking, Trust and Safety Product Team

Oct 29 2024

dom_walden added a comment to T378353: Autoblock expiry always set to 24 hours when updating.

I have found a circumstance where an autoblock whose parent has been pruned (because it has a shorter expiry) can lead to an exception: T378447.

Oct 29 2024, 9:03 AM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Team, GlobalBlocking
dom_walden created T378447: TypeError: Argument 1 passed to MediaWiki\Extension\GlobalBlocking\Services\GlobalBlockLookup::getAutoblockReason() must be an instance of stdClass, bool given.
Oct 29 2024, 9:01 AM · MW-1.44-notes (1.44.0-wmf.1; 2024-10-29), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Patch-For-Review, Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), GlobalBlocking, Trust and Safety Product Team

Oct 28 2024

dom_walden created T378353: Autoblock expiry always set to 24 hours when updating.
Oct 28 2024, 2:10 PM · Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Trust and Safety Product Team, GlobalBlocking
dom_walden moved T377385: Update the 'globalblock' API to allow enabling global autoblocking for global user blocks from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I wrote a script to create a number of global blocks with different block params and checking that an autoblock is always created (with exceptions that are consistent with local autoblocks).

Oct 28 2024, 1:54 PM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment), GlobalBlocking, Trust and Safety Product Team
dom_walden added projects to T378350: Global block may not be created if expired block has not been pruned: Trust and Safety Product Team, GlobalBlocking.
Oct 28 2024, 12:04 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), GlobalBlocking, Trust and Safety Product Team
dom_walden created T378350: Global block may not be created if expired block has not been pruned.
Oct 28 2024, 12:04 PM · MW-1.44-notes (1.44.0-wmf.5; 2024-11-25), Trust and Safety Product Sprint (Sprint Gong (November 18 - December 6)), GlobalBlocking, Trust and Safety Product Team
dom_walden moved T377390: Prevent the 'globalblock' API modifying global autoblocks from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15) board.

I have not been able to modify a global autoblock.

Oct 28 2024, 11:30 AM · Trust and Safety Product Sprint (Sprint Accordion October 28 - November 15), MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), Temporary accounts (Blockers to minor pilot wiki deployment), GlobalBlocking, Trust and Safety Product Team