[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Disable Add Link backend on hywwiki
Closed, ResolvedPublic

Description

As of now, hywwiki has Add Link backend enabled, and the refreshLinkRecommendations job is trying to populate its pool:

[urbanecm@mwmaint1002 /var/log/mediawiki/mediawiki_job_growthexperiments-refreshLinkRecommendations-s3]$ grep -h -F hywwiki syslog.log* | head
Jul 11 07:24:29 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:  Refreshing link recommendations...
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:    processing topic biography...
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      500 new tasks needed
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      fetching 500 tasks...
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      checking candidate Սարգիս_Արարատեան... There was a problem during the HTTP request: 400 Bad Request
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      checking candidate Էրեբունի_թանգարան_եւ_երեգան_թանգարան... There was a problem during the HTTP request: 400 Bad Request
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      checking candidate Աղաւնոյ_Գիւղ... There was a problem during the HTTP request: 400 Bad Request
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      checking candidate 1676_թուական... There was a problem during the HTTP request: 400 Bad Request
Jul 11 07:24:30 mwmaint1002 mediawiki_job_growthexperiments-refreshLinkRecommendations-s3[8417]: hywwiki:      checking candidate Սամուէլ_Ակոբ_Ուլուչեան... There was a problem during the HTTP request: 400 Bad Request
[urbanecm@mwmaint1002 /var/log/mediawiki/mediawiki_job_growthexperiments-refreshLinkRecommendations-s3]$

Those attempts fail, because hywwiki does not have add link models (they did not pass recall and precision thresholds; see T309263 and T308134#8548734). Since the models are unavailable for hywwiki, there is no point in trying to populate the task pool, since it is not going to be available in the near future. For this reason, we should disable Add Link backend on hywwiki.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

According to my tests, hywwiki is the only (content) wiki where models are not available, but backend is enabled:

1urbanecm@wmf3345 mediawiki-config % grep wgGENewcomerTasksLinkRecommendationsEnabled tests/data/config-cache/conf-production-* | grep true | cut -d: -f 1 | cut -d '-' -f 4 | cut -d. -f 1 > enabled_be.txt
2urbanecm@wmf3345 mediawiki-config % wget -O model_available.txt 'https://analytics.wikimedia.org/published/datasets/one-off/research-mwaddlink/wikis.txt'
3urbanecm@wmf3345 mediawiki-config % sort model_available.txt > t && mv t model_available.txt
4urbanecm@wmf3345 mediawiki-config % sort enabled_be.txt > t && mv t enabled_be.txt
5urbanecm@wmf3345 mediawiki-config % diff -u enabled_be.txt model_available.txt
6--- enabled_be.txt 2024-07-19 23:44:44
7+++ model_available.txt 2024-07-19 23:44:35
8@@ -2,6 +2,7 @@
9 acewiki
10 adywiki
11 afwiki
12+akwiki
13 alswiki
14 amwiki
15 angwiki
16@@ -97,7 +98,6 @@
17 htwiki
18 huwiki
19 hywiki
20-hywwiki
21 iawiki
22 idwiki
23 iewiki
24@@ -165,15 +165,19 @@
25 mznwiki
26 nahwiki
27 napwiki
28+nawiki
29 nds_nlwiki
30 ndswiki
31 newiki
32 newwiki
33 nlwiki
34 nnwiki
35+novwiki
36 nowiki
37 nqowiki
38+nrmwiki
39 nsowiki
40+nvwiki
41 nywiki
42 ocwiki
43 olowiki
44@@ -232,7 +236,6 @@
45 szlwiki
46 tawiki
47 tcywiki
48-testwiki
49 tetwiki
50 tewiki
51 tgwiki
52urbanecm@wmf3345 mediawiki-config %

testwiki also has no models, but it uses simplewiki's model, so it does not count. We have a couple of wikis that have models, but do not have add link enabled.

However, the opposite problem is much more frequent it appears. I filled T370559: Review wikis that have Add Link models but do not have Add Link enabled to review that.

KStoller-WMF moved this task from Inbox to Up Next on the Growth-Team board.

Change #1057970 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [Growth] hywwiki: Disable Add link backend

https://gerrit.wikimedia.org/r/1057970

Change #1057970 merged by jenkins-bot:

[operations/mediawiki-config@master] [Growth] hywwiki: Disable Add link backend

https://gerrit.wikimedia.org/r/1057970

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:02:33Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:16:43Z] <urbanecm@deploy1003> sync-world aborted: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]] (duration: 14m 10s)

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:17:06Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-30T12:58:42Z] <urbanecm@deploy1003> Started scap sync-world: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-30T13:21:13Z] <urbanecm@deploy1003> Finished scap: Backport for [[gerrit:1057970|[Growth] hywwiki: Disable Add link backend (T370558)]], [[gerrit:1058117|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]], [[gerrit:rODNS10581164f3e4|refreshLinkRecommendations: Work even when link-recommendation is disabled (T371316)]] (duration: 22m 31s)

[urbanecm@mwmaint1002 ~]$ mwscript extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php --wiki=hywwiki
Disabled
[urbanecm@mwmaint1002 ~]$

All done now.