[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T369085

Cannot upload! – TypeError: Cannot read properties of undefined (reading 'dataValueType')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • I cannot upload
  • Notice that not a single input field is shown on the description step of the upload wizard
  • Notice the following error on the JavaScript console
jQuery.Deferred exception: Cannot read properties of undefined (reading 'dataValueType') TypeError: Cannot read properties of undefined (reading 'dataValueType')
    at https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:246:115
    at Array.forEach (<anonymous>)
    at mw.UploadWizardDetails.buildInterface (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:246:16)
    at mw.UploadWizardDetails.attach (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:251:280)
    at https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:73:794
    at Array.forEach (<anonymous>)
    at uw.controller.Details.load (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:73:650)
    at uw.controller.Step.moveNext (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:64:383)
    at Array.<anonymous> (https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.uploadWizard&skin=vector-2022&version=1ytu7:67:925)
    at mightThrow (https://commons.wikimedia.org/w/load.php?lang=de&modules=jquery%2Coojs-ui-core&skin=vector-2022&version=1d0dx:45:648)

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

  • MediaWiki 1.43.0-wmf.11 (7df99f2) 2024-06-24T20:36:14
  • Upload Wizard 1.5.0 (a8c7f4a) 2024-06-24T17:59:10

Other information (browser name/version, screenshots, etc.):

Regression of T361053?
Regression of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/1047126?

commons.wikimedia.org_wiki_special_uploadWizard_campaign=Schallaburg2024-at&fields%5B%5D=Q37940540.png (1×1 px, 301 KB)

Details

SubjectRepoBranchLines +/-
Handle campaigns where wikibase is not enabledmediawiki/extensions/UploadWizardwmf/1.43.0-wmf.12+1 -1
Handle campaigns where wikibase is not enabledmediawiki/extensions/UploadWizardmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

simon04 created this task.Jul 2 2024, 5:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2024, 5:20 PM
simon04 added a parent task: T361053: [XL] Improve the Depicts field interaction in the upload wizard.Jul 2 2024, 5:20 PM
Herzi.Pinki triaged this task as High priority.Jul 2 2024, 9:43 PM

We are running our annual photo competition WikiDaheim (starting with July, 1st), which is highly based on a working UW.

Aklapper removed a parent task: T361053: [XL] Improve the Depicts field interaction in the upload wizard.Jul 2 2024, 9:50 PM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".
Aklapper added a project: Wikimedia-production-error.
Herzi.Pinki added a comment.Jul 2 2024, 9:59 PM

https://commons.wikimedia.org/wiki/special:uploadWizard?campaign=wlm-at&fields%5B%5D=56784&fields%5B%5D=47.067016/15.446529&captionlang=de&caption=F%C3%BCrst+Dietrichstein%27sches+Stiftungshaus+%28BDA-HERIS-ID%3A+51185%29%2C+Schl%C3%B6gelgasse+9%2C+Graz&descriptionlang=de&description=F%C3%BCrst+Dietrichstein%27sches+Stiftungshaus&categories=F%C3%BCrst+Dietrichstein%27sches+Stiftungshaus%2C+Graz works in FF, but does not work in Chrome.

gerritbot added a comment.Jul 3 2024, 8:53 AM

Change #1051695 had a related patch set uploaded (by Cparle; author: Cparle):

[mediawiki/extensions/UploadWizard@master] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051695

gerritbot added a project: Patch-For-Review.Jul 3 2024, 8:53 AM
gerritbot added a comment.Jul 3 2024, 8:55 AM

Change #1051695 abandoned by Cparle:

[mediawiki/extensions/UploadWizard@master] Handle campaigns where wikibase is not enabled

Reason:

wrong branch

https://gerrit.wikimedia.org/r/1051695

gerritbot added a comment.Jul 3 2024, 8:57 AM

Change #1051696 had a related patch set uploaded (by Matthias Mullie; author: Cparle):

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.12] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051696

Cparle subscribed.Jul 3 2024, 9:07 AM

Good catch @simon04 thank you! Fix scheduled for deployment at 1300UTC

gerritbot added a comment.Jul 3 2024, 9:08 AM

Change #1051696 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.12] Handle campaigns where wikibase is not enabled

https://gerrit.wikimedia.org/r/1051696

Lucas_Werkmeister_WMDE subscribed.Jul 3 2024, 9:10 AM

Are you already deploying the backport now? Otherwise it shouldn’t have been merged yet IIUC.

Stashbot added a comment.Jul 3 2024, 9:18 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:18:56Z] <mlitn@deploy1002> Started scap sync-world: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]]

Stashbot added a comment.Jul 3 2024, 9:21 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:21:29Z] <mlitn@deploy1002> mlitn: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jul 3 2024, 9:31 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-03T09:31:56Z] <mlitn@deploy1002> Finished scap: Backport for [[gerrit:1051696|Handle campaigns where wikibase is not enabled (T369085)]] (duration: 12m 59s)

Cparle added a comment.Jul 3 2024, 9:35 AM

Ok deployed early. Should be fixed now @simon04 @Herzi.Pinki

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.12; 2024-07-02).Jul 3 2024, 10:00 AM
Herzi.Pinki added a comment.Jul 5 2024, 4:52 AM

as far as I can judge, everything is back to normal. Thanks

Cparle closed this task as Resolved.Jul 5 2024, 8:43 AM
Cparle claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2024, 8:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits