[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Update requireLogin() for temp users on ContentTranslation extension
Closed, ResolvedPublic

Description

In T344276, we want to make sure the SpecialPage::requireLogin() function is used in accordance with the introduction of temporary users. As for now, we want to treat temporary users just like anonymous or IP users.

Request:
Should requireLogin() be available to temporary users?
If yes, no update is needed.
If not, requireNamedUser must return true instead.

Notes:
RequireLogin was found in the following files:
includes/Special/SpecialContentTranslation.php
Code Search Link

Event Timeline

ngkountas changed the task status from Open to In Progress.Oct 11 2023, 6:35 PM
ngkountas claimed this task.

Change 965464 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Use "requireNamedUser" instead of "requireLogin"

https://gerrit.wikimedia.org/r/965464

Change 965464 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX Special Page: Use "requireNamedUser" instead of "requireLogin"

https://gerrit.wikimedia.org/r/965464

This task doesn't include any UI change and cannot be verified with screencasts, etc. However, the fix has been deployed for about a month now, and things continue to work as expected. This task can be closed as done.