[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Zebra: Completely remove any A/B test-related code
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: Confirm with Olga that a future A/B test is not needed before removing this code.

Context
Last time we removed A/B test code in config and Vector, it caused the edit button to disappear. We want to test thoroughly before removing completed Zebra A/B test code this time around.

Success Criteria

  • Completely remove default Zebra AB Test configuration lines in mediawiki config and beta config
  • Completely remove Zebra A/B test -related lines in Vector
  • Test in Beta for any misfires or JS errors
  • Run pixel - make sure all green
  • Merge to prod

*Jon's note: $wgVectorZebraDesign would be kept. Code relating to VectorWebABTestEnrollment wouldn't

QA

  • check HTML of page with ?vectorzebradesign=0 - HTML element should have vector-feature-zebra-design-disabled class
  • check HTML of page with ?vectorzebradesign=1 - HTML element should have vector-feature-zebra-design-enabled class

QA Results - Beta

ACStatusDetails
1T339957#9339679
2T339957#9339679

QA Results - Prod

ACStatusDetails
1T339957#9343373
2T339957#9343373

Event Timeline

KSarabia-WMF renamed this task from Completely remove default A/B test configuration to Completely remove any Zebra A/B test-related code.Jun 20 2023, 5:47 PM
KSarabia-WMF updated the task description. (Show Details)
Edtadros triaged this task as Medium priority.Jun 22 2023, 5:19 PM
Edtadros set the point value for this task to 2.Jun 22 2023, 5:35 PM
Jdlrobson renamed this task from Completely remove any Zebra A/B test-related code to Zebra: Completely remove any A/B test-related code.Jun 23 2023, 5:53 PM

Change 973875 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove Zebra A/B test code

https://gerrit.wikimedia.org/r/973875

Change 973875 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove Zebra A/B test code

https://gerrit.wikimedia.org/r/973875

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: check HTML of page with ?vectorzebradesign=0 - HTML element should have vector-feature-zebra-design-disabled class

screenshot 218.png (646×1 px, 230 KB)

✅ AC2: check HTML of page with ?vectorzebradesign=1 - HTML element should have vector-feature-zebra-design-enabled class

screenshot 219.png (585×1 px, 171 KB)

Mabualruz claimed this task.
Mabualruz updated the task description. (Show Details)

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: check HTML of page with ?vectorzebradesign=0 - HTML element should have vector-feature-zebra-design-disabled class

screenshot 265.png (1×1 px, 509 KB)

✅ AC2: check HTML of page with ?vectorzebradesign=1 - HTML element should have vector-feature-zebra-design-enabled class

screenshot 266.png (1×1 px, 511 KB)