[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

[L] Search preview - Open images in commons widget in Multimedia Viewer
Closed, ResolvedPublic

Description

Currently the images on commons widget open to a new page with image and other information about it. This ticket is to open the image in a MultimediaViewer instead for better image viewing experience.

  • Open images clicked on from commons widget in multimedia viewer on desktop and mobile.

Event Timeline

Can we open the commons images in media viewer instead of going to the main page? @matthiasmullie @SimoneThisDot

Hi Sneha, I am not sure if you remember the discussion we had a few months ago regarding this topic, but the media viewer is an actual part of commons and it is not something we can re-use out of the box...

This does not mean that we CANNOT show an image preview, but it just means that we would have to rewrite something similar to the media viewer. This is not a big work (just a normal ticket), but I am telling you to let you know that you have the flexibility to design it as you wish as it will be build from scratch.

Note: MultimediaViewer is deployed on nearly all wikis, so we could use it. I don't think it picks up on dynamically added content, so we'd have to invoke it ourselves; and I wouldn't be surprised if we'd also have to make some changes to the MultimediaViewer extension itself, but I'm pretty sure it could work.

Is this something we can do a spike on for milestone 4? @CBogen
If we can use MultimediaViewer it will be a better experience in viewing the image.

Sneha renamed this task from Search preview - Explore other destinations for opening image in commons widget to Search preview - Open images in commons widget in Multimedia Viewer.Jan 10 2023, 10:14 PM
Sneha updated the task description. (Show Details)
Sneha updated the task description. (Show Details)
CBogen renamed this task from Search preview - Open images in commons widget in Multimedia Viewer to [L] Search preview - Open images in commons widget in Multimedia Viewer.Jan 11 2023, 5:50 PM

Estimating as a large, but noting that if we need to make significant changes to the MultimediaViewer extension itself, making this ticket balloon, we should re-evaluate whether we want to move forward.

Change 901210 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search preview - Open images in commons widget in Multimedia Viewer

https://gerrit.wikimedia.org/r/901210

Change 901210 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search preview - Open images in commons widget in Multimedia Viewer

https://gerrit.wikimedia.org/r/901210

@SimoneThisDot - betalabs doesn't offer many good examples of quick search preview with Related images, and so far I found only one that works:
CORRECT behavior

However, this example won't work: search=cats&quickView=Cat will display six images in Related images (each of them can be opened by the right-click in a different tab).
But clicking on any image wouldn't produce any actions - not opening MultimediaViewer nor redirecting anywhere. I did not see anything unusual in the Console/Network tabs nor in the links themselves. Do you think it's a bug or just one of the betalabs deficieincies?

Yes, I can see the issue there! :)

In the cat example you shared, 2 of the images are not loading (are actually failing to load as you can see from the screenshot). This is preventing us from triggering an update event required for the multimedia viewer to be loaded.

I am going to work on a fix for this now.

Change 907872 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Search preview - Open images in commons widget in Multimedia Viewer

https://gerrit.wikimedia.org/r/907872

Change 907872 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search preview - Open images in commons widget in Multimedia Viewer

https://gerrit.wikimedia.org/r/907872

Change 907872 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Search preview - Open images in commons widget in Multimedia Viewer

https://gerrit.wikimedia.org/r/907872

Checked - the fix is in place.
Testing notes: on production check

  • multiple images
  • single image
  • pagination of images in Multimedia Viewer widget

@SimoneThisDot - currently (wmf.11) the related images have a hand pointer, but they are not clickable.
In betalabs it's not possible to check - related images are not loaded due to Failed to load resource: net::ERR_CERT_DATE_INVALID.

Update:

  • the related images open in multimedia viewers on beta
  • the fix is not yet in production (checked wmf.13)

Checked in betalabs (after the fixes done in T338564) - works as expected.

Checked in wmf.15 - works on mobile.

@matthiasmullie On the desktop clicking on an image in Related images does not produce any effect. On betalabs it works, so I'm leaving the task in Verify on Production column for now for monitoring.

Change 934524 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/MultimediaViewer@master] Handle translated special page names

https://gerrit.wikimedia.org/r/934524

Change 934524 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Handle translated special page names

https://gerrit.wikimedia.org/r/934524

Etonkovidova updated the task description. (Show Details)

Checked on wmf.16 - works as expected.