[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

[M] Provide a quick view turn on/off preference setting.
Closed, ResolvedPublic

Description

Problem
The introduction of quick view may hinder some editor experiences. Due to lack of research and feedback on quick view from the community we are not sure if quick view will come in the way of any of the editor's current workflows or may have some odd quirks that need fixing, or if it will interfere with assistive technology, or if it will prove to be a problem for people with limited connectivity etc as mentioned in this slack thread. As this was designed with the readers in mind, we cannot fully anticipate any dissatisfaction this may cause to editors.

Solution
Quick view will be turned on by default. However, a quick view turn on/off to be made available in the settings for advanced users who wish to turn it off. Users will need to be informed about this setting which will be covered in this ticket.

Position and copy for the setting in desktop preferences

Special_Search (37).png (729×1 px, 99 KB)

Additional acceptance criteria:

new AC:

  • Change the words of the configuration subheading to "Preview the contents of the page and related content."

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
CBogen renamed this task from Provide a quick view turn on/off preference setting. to [M] Provide a quick view turn on/off preference setting..Jul 27 2022, 4:53 PM
Sneha updated the task description. (Show Details)
Sneha updated the task description. (Show Details)

Change 826300 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Provide a quick view turn on/off preference setting.

https://gerrit.wikimedia.org/r/826300

Change 826300 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Provide a quick view turn on/off preference setting.

https://gerrit.wikimedia.org/r/826300

CBogen subscribed.

Blocked until the QuickView extension is deployed to beta cluster and this can be tested.

@SimoneThisDot I added three more acceptance criteria to this ticket:

Please let me know if I should move this back to Doing, thanks!

Change 838120 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikimediaEvents@master] Provide a quick view turn on/off preference setting.

https://gerrit.wikimedia.org/r/838120

Change 838120 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Provide a quick view turn on/off preference setting.

https://gerrit.wikimedia.org/r/838120

The additional AC has been completed:

  • Preference changes should be tracked via WikimediaEvents

The other 2 AC remaining are actually the required action for a production release, so this ticket is blocked until we are ready to release.

cc: @CBogen

Blocked on the SearchVue deploy for testing and translation

Since our scope has been reduced (we are not showing any related pages from interwiki links in this milestone) and since we are now using the copy "related images" for commons (earlier my understanding was that it may go to categories page on commons), I think the copy here needs to be addressed.

Currently the copy under the option says "Preview the contents of the article and related pages"

This should be changed to "Preview the contents of the article and related content."

The word pages is too specific. Content covers a variety of content that can be added in quick view.

@SimoneThisDot @CBogen can this be easily fixed as part of this ticket?

Yes, I can do it for you tomorrow morning.|

Moved the task to To Do.

@Sneha when you have some time, can you update the screenshot with the correct wording (just for QA reason not for development).

new AC:

  • Change the words of the configuration subheading to "Preview the contents of the article and related content."
Sneha updated the task description. (Show Details)

thanks @SimoneThisDot all updated in the ticket

Change 838767 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Update config subheading

https://gerrit.wikimedia.org/r/838767

Note: the current text is:

"Preview the contents of the page and related pages"
(not: "Preview the contents of the article and related pages")

That means the proposed new text includes 2 changes:

"Preview the contents of the article and related content"


Changing "related pages" to "related content" is not a problem.
That change has been merged now.


Changing "contents of the page" to "contents of the article", however, is potentially an issue.
"article" is a very specific term that refers to pages within the main namespace, on wikipedias.
While technically correct for our current MVP deployment targets, it will no longer be correct if at some later point we want to consider expanding to other namespaces or other wikis.

Calling articles pages, while perhaps not the best term, is still correct; not the other way around.
And while it might not confuse too many people on English Wikipedia, there could be a lot more nuance in other languages or projects (e.g. Wikidata has "items" instead of "articles", Wiktionary has "entries", Wikiquote, Wikispecies & Wikivoyage stick with "page", Commons has "gallery", Wikibooks has "book", ...)
If we have any plans/hopes of deploying this more widely in the future, we should stick with "pages" in generic descriptions (like this one in Preferences)
Or make note of this so it doesn't end up being forgotten at that point.

Note: for descriptions within the QuickView panel, we can be (and already are) more flexible: we know exactly what namespace we're opening quickview for, and we're already showing "article" for main namespace, or "pages" for elsewhere (even though this is not yet a scenario that can be triggered) - and even that is sketchy once we start to consider other projects

Changing "contents of the page" to "contents of the article" has not yet happened. I think we ought to discuss the future of this extension before settling on restrictive verbiage.

Except for the currently ignored change in verbiage (see T311667#8290517), this is done. I have updated the AC to reflect the current status quo of "Preview the contents of the page and related content".
Moving to blocked until this can be tested.

If we've had a discussion about using the more restrictive verbiage & want to pursue it after all, please create a new ticket.

okay in the settings we can be all-encompassing as long as we are specific on the search page which we already are. I will update the image with the correct copy.

Change 838767 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Update config subheading

https://gerrit.wikimedia.org/r/838767

Etonkovidova subscribed.

Checked in enwiki betalabs - works as expected; the finished AC in the task descriptions are updated.

Screen Shot 2022-10-23 at 12.27.29 PM.png (708×1 px, 124 KB)


Notes to follow up:

  • ruwiki betalabs has thubmnails enabled but not QuickView. Since it's only one of three target wikis present in betalabs maybe enabling QuickView would be a good idea?
  • ruwiki betalabs has thubmnails enabled but not QuickView. Since it's only one of three target wikis present in betalabs maybe enabling QuickView would be a good idea?

I agree. @matthiasmullie Can you enable QuickView on beta in ru, pt, and id?

Yes, this is definitely a blocker for deployment. @matthiasmullie now that QuickView is deployed on beta, can @Sannita
start working with the ambassadors on translations?

can @Sannita start working with the ambassadors on translations?

I asked PT and ID ambassador to start translating the message, deadline is set by Friday 28 EOD.

Change 849025 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[operations/mediawiki-config@master] [SearchVue] Enable on ruwiki (beta)

https://gerrit.wikimedia.org/r/849025

I agree. @matthiasmullie Can you enable QuickView on beta in ru, pt, and id?

I can enable it on ru beta; there is no pt & id.

Yes, this is definitely a blocker for deployment. @matthiasmullie now that QuickView is deployed on beta, can @Sannita
start working with the ambassadors on translations?

Certainly; I think all tasks that require messages, have already been completed.

Portuguese translation is ready. Indonesian and Russian are ongoing.

All translations are done.

Etonkovidova closed this task as Resolved.EditedNov 30 2022, 9:27 PM

Portuguese translation is ready. Indonesian and Russian are ongoing.

Checked in wmf.10 for ruwiki, ptwiki, and idwiki - the translation is in place, thx, @Sannita. The functionality works as expected.

@Sneha - ptwiki adds special css to Special:Search, so the page looks slightly different and that default look is consistent for all the skins and for all users - anon or logged in.

default
Screen Shot 2022-11-30 at 1.16.56 PM.png (1×2 px, 688 KB)
with safemode=1
Screen Shot 2022-11-30 at 1.16.25 PM.png (1×2 px, 609 KB)

I agree. @matthiasmullie Can you enable QuickView on beta in ru, pt, and id?

I can enable it on ru beta; there is no pt & id.

Thx, @matthiasmullie.

Are we able to default it to white background or is it controlled by community?

Are we able to default it to white background or is it controlled by community?

It's controlled by community. There are ways to override it (not always though) - should I file a task for it? Or we need evaluate how difficult it might be to override the communities' defaults?

Re-opened the task due to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SearchVue/+/838767/ not yet being deployed.

The translations are in place - MediaWiki:Searchvue-help, but not displayed in on Special:Preferences#mw-prefsection-searchoptions

The following spec is done only in betalabs:

  • Change the words of the configuration subheading to "Preview the contents of the page and related content."

Re-opened the task due to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SearchVue/+/838767/ not yet being deployed.

The translations are in place - MediaWiki:Searchvue-help, but not displayed in on Special:Preferences#mw-prefsection-searchoptions

The following spec is done only in betalabs:

  • Change the words of the configuration subheading to "Preview the contents of the page and related content."

It looks like this was merged on Oct 6, any idea why it's not been deployed? @SimoneThisDot @matthiasmullie

We're not deploying search previews until next week.

Change 849025 merged by jenkins-bot:

[operations/mediawiki-config@master] [SearchVue] Enable on ruwiki (beta)

https://gerrit.wikimedia.org/r/849025

Checked after deployment (wmf.17) to ruwiki, ptwiki, and idwiki - all works/looks according to the specs.