[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

[L] Quick View: Add search results snippet to QuickView panel
Closed, ResolvedPublic

Description

This story is one part of all the contents that go in the quick view mentioned in T306898

This ticket is to add the existing search results snippet to the QuickView panel. In T307052 we will explore how to extend that snippet, but this is just to add the existing snippet as a first prototype.

Acceptance Criteria:

  • Add the same snippet from search results into the QuickView panel for that result
  • Add "Go to full article" link that opens the full article in the same window. The quick view panel (if it was previously open before navigating to an article) should stay open when user return to search results using browser back button.

Link to quick view in figma

Event Timeline

CBogen renamed this task from Quick View: Add search results snippet to QuickView panel to [L] Quick View: Add search results snippet to QuickView panel.Jun 29 2022, 4:56 PM

FYI there's a lot of discussion about restoring JS state after coming back in T284021 where that was implemented in search. There are even more tickets to be found on Phab when searching for tasks with mediasearch history.

Change 825735 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Quick View: Add search results snippet to QuickView panel

https://gerrit.wikimedia.org/r/825735

@matthiasmullie I have opened a path and implemented restore using the URI query params, but I am happy to change it to use localStorage as we did in mediaSearch.

The advantages of using the URI is that it will save multiple states, so people will be able to go back more than once to see previously opened QuickView (like google does)

Change 825735 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Quick View: Add search results snippet to QuickView panel

https://gerrit.wikimedia.org/r/825735

Change 830735 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/SearchVue@master] Quick View: Add search results snippet to QuickView panel

https://gerrit.wikimedia.org/r/830735

Change 830735 merged by jenkins-bot:

[mediawiki/extensions/SearchVue@master] Quick View: Add search results snippet to QuickView panel

https://gerrit.wikimedia.org/r/830735

Blocked until the QuickView extension is deployed to beta cluster and this can be tested.

Etonkovidova subscribed.

Checked after deployment (wmf.17) to ruwiki, ptwiki, and idwiki - all works/looks according to the specs.

Screen Shot 2023-01-05 at 4.43.36 PM.png (1×1 px, 1 MB)