[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T299022

Move webservice consumers to namespace and use service injection
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

These are present under the webservices folder.

Details

Due Date
Mar 31 2022, 6:29 PM
SubjectRepoBranchLines +/-
WebService: Further fixes for strict typesmediawiki/extensions/Translatemaster+3 -3
TranslationWebService: Actually return the service object in factorymediawiki/extensions/Translatemaster+2 -0
TranslationQueryResponse: Remove factory method and use constructormediawiki/extensions/Translatemaster+9 -16
Add type hints and strict types for non MT webservice classesmediawiki/extensions/Translatemaster+47 -55
Remove file comments from MediaWiki\Extension\Translate\WebServicemediawiki/extensions/Translatemaster+46 -121
Add type hints and strict types to MT webservices under namespacemediawiki/extensions/Translatemaster+135 -124
TranslationWebService: Use ObjectFactory and inject HttpServiceFactorymediawiki/extensions/Translatemaster+129 -43
Move webservice consumers to WebService namespacemediawiki/extensions/Translatemaster+81 -41
Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Jan 12 2022, 5:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2022, 5:54 AM
abi_ added a parent task: T193166: Adopt PSR-4 namespaces in Translate and modernize code.Jan 12 2022, 5:55 AM
Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Feb 14 2022, 11:39 AM
Nikerabbit set the point value for this task to 4.Mar 1 2022, 8:17 AM
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.Mar 1 2022, 9:32 AM
Nikerabbit lowered the priority of this task from Medium to Low.Mar 1 2022, 9:39 AM
Wangombe claimed this task.Mar 8 2022, 7:32 AM
Wangombe moved this task from Priority: Localization infrastructure to In Progress on the Language-Team (Language-2022-January-March) board.Mar 14 2022, 9:56 AM
gerritbot added a comment.Mar 14 2022, 2:23 PM

Change 770507 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/extensions/Translate@master] Move webservice consumers to namespace

https://gerrit.wikimedia.org/r/770507

gerritbot added a project: Patch-For-Review.Mar 14 2022, 2:23 PM
Wangombe added a comment.EditedMar 14 2022, 6:08 PM

T193166 | Convert Translate to PSR-4 has a patch 724782 with classes that depend on some of the work done for this task such as MachineTranslationAid.php, QueryAggregatorAwareTranslationAid.php, TranslationAidsActionApi.php & TTMServerAid.php . As a result, I think the build for this task will always fail without making necessary updates to the aforementioned classes. I have made updates to the classes but haven't committed the changes since I don't believe they are part of the scope for this task. Could you advise on the best way to approach this?

gerritbot added a comment.Mar 17 2022, 11:46 AM

Change 771574 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationWebService: Use ObjectFactory and inject HttpServiceFactory

https://gerrit.wikimedia.org/r/771574

gerritbot added a comment.Mar 31 2022, 7:51 AM

Change 770507 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Move webservice consumers to WebService namespace

https://gerrit.wikimedia.org/r/770507

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Mar 31 2022, 8:00 AM
abi_ claimed this task.Apr 4 2022, 6:21 AM
abi_ added a subscriber: Wangombe.

I'm currently working on this.

gerritbot added a comment.Apr 4 2022, 6:45 AM

Change 776675 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Remove file comments from MediaWiki\Extension\Translate\WebService

https://gerrit.wikimedia.org/r/776675

gerritbot added a comment.Apr 4 2022, 7:14 AM

Change 776718 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add type hints and strict types to web services under namespace

https://gerrit.wikimedia.org/r/776718

gerritbot added a comment.Apr 4 2022, 7:30 AM

Change 776722 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Add type hints and strict types for remaining WebServices

https://gerrit.wikimedia.org/r/776722

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2022-January-March) board.Apr 4 2022, 7:48 AM
Pginer-WMF edited projects, added Language-Team (Language-2022-April-June); removed Language-Team (Language-2022-January-March).Apr 4 2022, 8:25 AM
Pginer-WMF moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.
Tacsipacsi subscribed.Apr 4 2022, 12:08 PM
gerritbot added a comment.Apr 7 2022, 9:17 AM

Change 778246 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationQueryResponse: Remove factory method and use constructor

https://gerrit.wikimedia.org/r/778246

gerritbot added a comment.Apr 7 2022, 10:16 AM

Change 771574 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationWebService: Use ObjectFactory and inject HttpServiceFactory

https://gerrit.wikimedia.org/r/771574

gerritbot added a comment.Apr 7 2022, 10:17 AM

Change 776675 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Remove file comments from MediaWiki\Extension\Translate\WebService

https://gerrit.wikimedia.org/r/776675

gerritbot added a comment.Apr 7 2022, 10:17 AM

Change 776718 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add type hints and strict types to MT webservices under namespace

https://gerrit.wikimedia.org/r/776718

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.7; 2022-04-11); removed MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 7 2022, 11:00 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.Apr 8 2022, 7:02 AM
gerritbot added a comment.Apr 10 2022, 1:21 PM

Change 776722 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add type hints and strict types for non MT webservice classes

https://gerrit.wikimedia.org/r/776722

gerritbot added a comment.Apr 10 2022, 1:21 PM

Change 778246 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslationQueryResponse: Remove factory method and use constructor

https://gerrit.wikimedia.org/r/778246

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2022, 1:30 PM
gerritbot added a comment.Apr 11 2022, 9:30 AM

Change 778991 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslationWebService: Actually return the service object

https://gerrit.wikimedia.org/r/778991

gerritbot added a project: Patch-For-Review.Apr 11 2022, 9:30 AM
gerritbot added a comment.Apr 11 2022, 11:37 AM

Change 778991 merged by Wangombe:

[mediawiki/extensions/Translate@master] TranslationWebService: Actually return the service object in factory

https://gerrit.wikimedia.org/r/778991

Maintenance_bot removed a project: Patch-For-Review.Apr 11 2022, 12:31 PM
gerritbot added a comment.Apr 11 2022, 1:19 PM

Change 779028 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] WebService: Further fixes for strict types

https://gerrit.wikimedia.org/r/779028

gerritbot added a project: Patch-For-Review.Apr 11 2022, 1:19 PM
gerritbot added a comment.Apr 11 2022, 4:47 PM

Change 779028 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] WebService: Further fixes for strict types

https://gerrit.wikimedia.org/r/779028

abi_ closed this task as Resolved.Apr 19 2022, 3:52 AM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.

Tested on translatewiki.net

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits