Remove ParserOutput::addOutputHook()
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cscott
	Oct 1 2021, 9:39 PM

Description

To facilitate refactoring of ParserOutput, it would be helpful to remove ::addOutputHook(). See T287216#7392138 for more discussion.

Details

Subject	Repo	Branch	Lines +/-
Remove ParserOutput::addOutputHook() and related code	mediawiki/core	master	+5 -164
Emit deprecation warnings for ParserOutput::addOutputHook()	mediawiki/core	master	+5 -0
Deprecate the ParserOutputHook functionality	mediawiki/core	master	+19 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T305161 Hard-deprecate and remove @deprecated methods from ParserOutput
		Resolved		cscott	T292321 Remove ParserOutput::addOutputHook()

Event Timeline

cscott created this task.Oct 1 2021, 9:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2021, 9:39 PM

cscott added a parent task: T287216: ParserOutput should implement ContentMetadataCollector.Oct 1 2021, 9:40 PM

cscott mentioned this in T287216: ParserOutput should implement ContentMetadataCollector.Oct 1 2021, 9:45 PM

Reedy added a project: MediaWiki-Parser.Oct 2 2021, 6:02 PM

There's only 2 usages of this feature in extensions, none of them are deployed.

In LanguageSelector extension this is used to instruct a JS module to be added to OutputPage if a languageselector tag is used on a page. We can just add the module directly in the tag hook without all this mess.

Krinkle moved this task from Backlog to ParserOutput on the MediaWiki-Parser board.Oct 13 2021, 7:55 PM

Can also be done in the OutputPageParserOutput hook, which I think is going to be the preferred place to put this sort of finalization.

Change 760994 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate the ParesrOutputHook functionality

https://gerrit.wikimedia.org/r/760994

gerritbot added a project: Patch-For-Review.Feb 8 2022, 4:13 PM

Change 760994 merged by jenkins-bot:

[mediawiki/core@master] Deprecate the ParserOutputHook functionality

https://gerrit.wikimedia.org/r/760994

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.26; 2022-03-14).Mar 8 2022, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2022, 10:10 PM

cscott edited parent tasks, added: T305161: Hard-deprecate and remove @deprecated methods from ParserOutput; removed: T287216: ParserOutput should implement ContentMetadataCollector.Mar 31 2022, 3:22 PM