[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T285433

Replace Z23/Nothings with Z24/voids (instances of Z21/Unit) in Orchestrator and Validator
Closed, ResolvedPublic
Actions

Description

Also ensure that all validators for Unit are only looking for instances of Z21 (I believe we currently allow both in many places).

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (5c8c897)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (2575d10)mediawiki/extensions/WikiLambdamaster+1 -1
Drop makeResultEnvelope and makeUnitmediawiki/services/function-schematamaster+13 -81
Update function-schemata sub-module to HEAD (2575d10)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (2575d10)mediawiki/services/function-orchestratormaster+1 -1
Drop validatesAsUnit(), not used anywhere any moremediawiki/services/function-schematamaster+1 -16
Update function-schemata sub-module to HEAD (49ff68e)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (49ff68e)mediawiki/services/function-evaluatormaster+1 -1
Use withVoid=true in calls to normalize and canonicalizemediawiki/services/function-orchestratormaster+48 -30
Update function-schemata sub-module to HEAD (49ff68e)mediawiki/services/function-orchestratormaster+1 -1
Finish replacing Z23s with Z24s in function-schematamediawiki/services/function-schematamaster+68 -27
Replace Z23s with Z24s in function evaluatormediawiki/services/function-evaluatormaster+41 -41
Use makeResultEnvelopeWithVoid in orchestratormediawiki/services/function-orchestratormaster+2 -2
Replace Z23s with Z24s in function-orchestratormediawiki/services/function-orchestratormaster+69 -59
Update function-schemata sub-module to HEAD (4fdbbf4)mediawiki/extensions/WikiLambdamaster+1 -1
Update function-schemata sub-module to HEAD (4fdbbf4)mediawiki/services/function-evaluatormaster+1 -1
Update function-schemata sub-module to HEAD (4fdbbf4)mediawiki/services/function-orchestratormaster+0 -0
Update function-schemata sub-module to HEAD (4fdbbf4)mediawiki/services/function-orchestratormaster+1 -1
Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21smediawiki/services/function-evaluatormaster+42 -27
Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21smediawiki/services/function-orchestratormaster+13 -14
definitions: Rename validator function & implementation for Z21mediawiki/services/function-schematamaster+17 -17
[BREAKING CHANGE] Replace Z23s with Z24s in function-schematamediawiki/services/function-schematamaster+59 -31
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdforrester-WMF moved this task from To triage: Un-phased work to Phase η – Generic types on the Abstract Wikipedia team board.Sep 14 2021, 8:07 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
Jdforrester-WMF added a subtask: T287195: Function model: Z21 should be updated to be the null value of Unit.
Jdforrester-WMF added a subtask: T287968: Create a makeUnit() Method in `function-schemata`.Sep 15 2021, 9:22 PM
Jdforrester-WMF added a parent task: T291038: Function model: updates to the data model to implement generic types.
Jdforrester-WMF added a subtask: T276721: ZObject model: Don’t make Z23/nothing’s Z1K1/type itself.
DVrandecic closed subtask T276721: ZObject model: Don’t make Z23/nothing’s Z1K1/type itself as Resolved.Oct 9 2021, 2:26 AM
Jdforrester-WMF closed subtask T287195: Function model: Z21 should be updated to be the null value of Unit as Resolved.Oct 13 2021, 4:45 PM
Jdforrester-WMF closed subtask T287968: Create a makeUnit() Method in `function-schemata` as Resolved.Oct 13 2021, 4:49 PM
DVrandecic triaged this task as Medium priority.Oct 20 2021, 4:35 PM
DVrandecic moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase η – Generic types) board.Nov 3 2021, 4:38 PM
Jdforrester-WMF removed a parent task: T291038: Function model: updates to the data model to implement generic types.Mar 1 2022, 8:09 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team (Phase η – Generic types).Mar 1 2022, 8:11 PM
cmassaro added a project: Abstract Wikipedia Fix-It tasks.Mar 21 2022, 3:30 PM
cmassaro updated the task description. (Show Details)
DMartin-WMF changed the task status from Open to In Progress.Mar 29 2022, 5:09 PM
DMartin-WMF claimed this task.
Jdforrester-WMF renamed this task from Replace Z23s with instances of Z21s in Orchestrator and Validator to Replace Z23s with Z21s (instances of Z24) in Orchestrator and Validator.Mar 31 2022, 4:17 PM
gengh subscribed.Apr 1 2022, 8:13 AM

Currently we have the following discordance between the meaning of Z21, Z23 and Z24:

In documentation page:
Z21: Unit (Type).
Z23: Nothing (Type).
Z24: void (Unit).

In function-schemata data definitions:
Z21: void (Unit).
Z23: Nothing (Type).
Z24: Unit (Type).

In function-schemata normal and canonical yamls:
Z21: Unit (Type).
Z23: Nothing (Type).
Z24: void (Unit).

In WikiLambda:
Z23: Nothing (Type).

In function-schemata utils.js:
Z23: Unit (Type).

In function-schemata schema.js:
Z23: Unit (Type).

gerritbot added a comment.Apr 3 2022, 5:19 PM

Change 776354 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Replace Z23s with Z21s (instances of Z24) in function-schemata

https://gerrit.wikimedia.org/r/776354

gerritbot added a project: Patch-For-Review.Apr 3 2022, 5:19 PM
gerritbot added a comment.Apr 3 2022, 10:25 PM

Change 776397 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Rename validator function & implementation for Z21

https://gerrit.wikimedia.org/r/776397

gerritbot added a comment.Apr 3 2022, 11:29 PM

Change 776441 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Replace Z23s with Z21s (instances of Z24) in function-orchestrator

https://gerrit.wikimedia.org/r/776441

gerritbot added a comment.Apr 4 2022, 2:01 AM

Change 776461 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-evaluator@master] Replace Z23s with Z21s (instances of Z24) in function-evaluator

https://gerrit.wikimedia.org/r/776461

gerritbot added a comment.Apr 4 2022, 7:15 PM

Change 776354 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] [BREAKING CHANGE] Replace Z23s with Z24s in function-schemata

https://gerrit.wikimedia.org/r/776354

Jdforrester-WMF mentioned this in rMSFS5e9990d56a24: [BREAKING CHANGE] Replace Z23s with Z24s in function-schemata.Apr 4 2022, 7:16 PM
gerritbot added a comment.Apr 4 2022, 7:20 PM

Change 776397 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] definitions: Rename validator function & implementation for Z21

https://gerrit.wikimedia.org/r/776397

Jdforrester-WMF mentioned this in rMSFS3db774b36ef4: definitions: Rename validator function & implementation for Z21.Apr 4 2022, 7:21 PM
gerritbot added a comment.Apr 4 2022, 7:40 PM

Change 776441 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21s

https://gerrit.wikimedia.org/r/776441

Jdforrester-WMF mentioned this in rMSFOfefbabdb3857: Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21s.Apr 4 2022, 7:41 PM
gerritbot added a comment.Apr 4 2022, 7:45 PM

Change 776990 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (3db774b)

https://gerrit.wikimedia.org/r/776990

gerritbot added a comment.Apr 4 2022, 7:49 PM

Change 776461 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21s

https://gerrit.wikimedia.org/r/776461

Jdforrester-WMF mentioned this in rMSFEd81a41924d57: Update function-schemata sub-module to HEAD (3db774b) and replace Z23s with Z21s.Apr 4 2022, 7:49 PM
gerritbot added a comment.Apr 8 2022, 4:49 PM

Change 778562 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (7aabc4a)

https://gerrit.wikimedia.org/r/778562

gerritbot added a comment.Apr 8 2022, 5:06 PM

Change 778565 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fdbbf4)

https://gerrit.wikimedia.org/r/778565

gerritbot added a comment.Apr 8 2022, 5:06 PM

Change 778566 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (4fdbbf4)

https://gerrit.wikimedia.org/r/778566

gerritbot added a comment.Apr 8 2022, 5:11 PM

Change 778562 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (4fdbbf4)

https://gerrit.wikimedia.org/r/778562

Jdforrester-WMF mentioned this in rMSFOd389e16e316f: Update function-schemata sub-module to HEAD (4fdbbf4).Apr 8 2022, 5:11 PM
gerritbot added a comment.Apr 8 2022, 5:20 PM

Change 776990 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (4fdbbf4)

https://gerrit.wikimedia.org/r/776990

gerritbot added a comment.Apr 8 2022, 5:22 PM

Change 778565 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (4fdbbf4)

https://gerrit.wikimedia.org/r/778565

Jdforrester-WMF mentioned this in rMSFE84f518a132c9: Update function-schemata sub-module to HEAD (4fdbbf4).Apr 8 2022, 5:22 PM
gerritbot added a comment.Apr 8 2022, 5:23 PM

Change 778566 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (4fdbbf4)

Reason:

Sorry, this is now a no-op!

https://gerrit.wikimedia.org/r/778566

gerritbot added a comment.Apr 13 2022, 5:24 AM

Change 779748 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Replace Z23s with Z24s in function-orchestrator

https://gerrit.wikimedia.org/r/779748

gerritbot added a comment.Apr 13 2022, 12:58 PM

Change 779748 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Replace Z23s with Z24s in function-orchestrator

https://gerrit.wikimedia.org/r/779748

DMartin-WMF mentioned this in rMSFO486fce06f1eb: Replace Z23s with Z24s in function-orchestrator.Apr 13 2022, 12:59 PM
gerritbot added a comment.Apr 14 2022, 5:02 PM

Change 780904 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-evaluator@master] Replace Z23s with Z24s in function evaluator

https://gerrit.wikimedia.org/r/780904

gerritbot added a comment.Apr 15 2022, 7:21 AM

Change 781605 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Use makeResultEnvelopeWithVoid in orchestrator

https://gerrit.wikimedia.org/r/781605

gerritbot added a comment.Apr 15 2022, 7:44 AM

Change 781645 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-schemata@master] Finish replacing Z23s with Z24s in function-schemata

https://gerrit.wikimedia.org/r/781645

gerritbot added a comment.Apr 15 2022, 10:13 PM

Change 781605 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Use makeResultEnvelopeWithVoid in orchestrator

https://gerrit.wikimedia.org/r/781605

DMartin-WMF mentioned this in rMSFOb4a5b8260389: Use makeResultEnvelopeWithVoid in orchestrator.Apr 15 2022, 10:14 PM
gerritbot added a comment.Apr 19 2022, 1:19 PM

Change 780904 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Replace Z23s with Z24s in function evaluator

https://gerrit.wikimedia.org/r/780904

DMartin-WMF mentioned this in rMSFE0cb10aa3b485: Replace Z23s with Z24s in function evaluator.Apr 19 2022, 1:19 PM
DMartin-WMF added a comment.Apr 19 2022, 11:09 PM

For future reference, https://gerrit.wikimedia.org/r/781605 added argument withVoid to function-schemata methods normalize and canonicalize. Setting withVoid = true causes these methods to use Z24 / void in their result envelopes. The default value of withVoid is false. When it's time for cleanup, we can change that default to be true.

gerritbot added a comment.Apr 20 2022, 4:45 PM

Change 784732 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/services/function-orchestrator@master] Use -withVoid=true in calls to normalize and canonicalize

https://gerrit.wikimedia.org/r/784732

gerritbot added a comment.Apr 21 2022, 7:13 PM

Change 781645 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Finish replacing Z23s with Z24s in function-schemata

https://gerrit.wikimedia.org/r/781645

DMartin-WMF mentioned this in rMSFS49ff68e2b4e2: Finish replacing Z23s with Z24s in function-schemata.Apr 21 2022, 7:17 PM
gerritbot added a comment.Apr 25 2022, 2:00 PM

Change 785853 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785853

gerritbot added a comment.Apr 25 2022, 2:00 PM

Change 785854 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

gerritbot added a comment.Apr 25 2022, 2:03 PM

Change 785856 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785856

gerritbot added a comment.Apr 25 2022, 4:58 PM

Change 785853 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785853

Jdforrester-WMF mentioned this in rMSFO3d3aad152fd3: Update function-schemata sub-module to HEAD (49ff68e).Apr 25 2022, 4:59 PM
gerritbot added a comment.Apr 25 2022, 5:00 PM

Change 784732 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Use withVoid=true in calls to normalize and canonicalize

https://gerrit.wikimedia.org/r/784732

Jdforrester-WMF mentioned this in rMSFO96a07682d1d6: Use withVoid=true in calls to normalize and canonicalize.Apr 25 2022, 5:03 PM
gerritbot added a comment.May 2 2022, 4:54 PM

Change 785854 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785854

Jdforrester-WMF mentioned this in rMSFE9b1424da84fc: Update function-schemata sub-module to HEAD (49ff68e).May 2 2022, 4:54 PM
gerritbot added a comment.May 3 2022, 3:42 PM

Change 785856 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (49ff68e)

https://gerrit.wikimedia.org/r/785856

Jdforrester-WMF removed a project: Patch-For-Review.May 17 2022, 1:41 PM
gerritbot added a comment.May 25 2022, 4:21 PM

Change 799366 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-schemata@master] Drop validatesAsUnit(), not used anywhere any more

https://gerrit.wikimedia.org/r/799366

gerritbot added a project: Patch-For-Review.May 25 2022, 4:21 PM
gerritbot added a comment.May 26 2022, 7:12 PM

Change 799366 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Drop validatesAsUnit(), not used anywhere any more

https://gerrit.wikimedia.org/r/799366

Jdforrester-WMF mentioned this in rMSFS2d010b5ad3c9: Drop validatesAsUnit(), not used anywhere any more.May 26 2022, 7:14 PM
gerritbot added a comment.May 27 2022, 7:32 PM

Change 800790 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800790

gerritbot added a comment.May 27 2022, 7:32 PM

Change 800791 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800791

gerritbot added a comment.May 27 2022, 7:32 PM

Change 800792 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800792

gerritbot added a comment.May 30 2022, 2:02 PM

Change 800791 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800791

gerritbot added a comment.May 30 2022, 2:06 PM

Change 800790 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800790

Jdforrester-WMF mentioned this in rMSFOff2f5797af70: Update function-schemata sub-module to HEAD (2575d10).May 30 2022, 2:08 PM
Jdforrester-WMF mentioned this in rMSFEe81676b5852b: Update function-schemata sub-module to HEAD (2575d10).May 30 2022, 2:11 PM
gerritbot added a comment.May 31 2022, 2:02 AM

Change 799369 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-schemata@master] Drop makeResultEnvelope and makeUnit

https://gerrit.wikimedia.org/r/799369

gerritbot added a comment.May 31 2022, 4:14 AM

Change 799369 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Drop makeResultEnvelope and makeUnit

https://gerrit.wikimedia.org/r/799369

Jdforrester-WMF mentioned this in rMSFS3e087a5dbf4d: Drop makeResultEnvelope and makeUnit.May 31 2022, 4:14 AM
gerritbot added a comment.Jun 2 2022, 2:56 PM

Change 800792 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (2575d10)

https://gerrit.wikimedia.org/r/800792

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 5:00 PM
gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802800 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802800

gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802801 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802801

gerritbot added a comment.Jun 3 2022, 5:00 PM

Change 802802 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (31f931f)

https://gerrit.wikimedia.org/r/802802

gerritbot added a comment.Jun 3 2022, 6:11 PM

Change 802800 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802800

gerritbot added a comment.Jun 3 2022, 6:12 PM

Change 802801 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802801

Jdforrester-WMF mentioned this in rMSFO5d32b2ce3638: Update function-schemata sub-module to HEAD (5c8c897).Jun 3 2022, 6:12 PM
gerritbot added a comment.Jun 3 2022, 6:17 PM

Change 802802 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (5c8c897)

https://gerrit.wikimedia.org/r/802802

Jdforrester-WMF mentioned this in rMSFE63f288e05d00: Update function-schemata sub-module to HEAD (5c8c897).Jun 3 2022, 6:18 PM
Jdforrester-WMF renamed this task from Replace Z23s with Z21s (instances of Z24) in Orchestrator and Validator to Replace Z23/Nothings with Z24/voids (instances of Z21/Unit) in Orchestrator and Validator.Jun 7 2022, 7:13 PM
Jdforrester-WMF moved this task from Incoming to Blocking launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:33 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 1 2023, 9:08 PM
Jdforrester-WMF closed this task as Resolved.Jun 9 2023, 12:14 PM
CodeReviewBot added a comment.Jun 11 2023, 8:59 AM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/29

Remove remaining references to Z23 in the orchestrator.

CodeReviewBot added a comment.Jun 12 2023, 10:03 AM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/29

Remove remaining references to Z23 in the orchestrator.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits