[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T256238

Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants
Closed, ResolvedPublic
Actions

Description

The “version” has been frozen at “0.5 alpha” for years and years, and nowadays the constants are only used to detect whether the extensions are loaded or not. Do that via ExtensionRegistry instead. (The constants are inconvenient because we can’t set them in the extension JSON file.)

Details

Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedLadsgroupT256228 Convert WikibaseClient to use extension registration
ResolvedLucas_Werkmeister_WMDET256238 Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants
· · ·

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 24 2020, 12:42 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 2:30 PM
Lucas_Werkmeister_WMDE claimed this task.Jun 24 2020, 2:38 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.
gerritbot added a comment.Jun 24 2020, 2:39 PM

Change 607521 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikimediaEvents@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607521

gerritbot added a project: Patch-For-Review.Jun 24 2020, 2:39 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 2:39 PM
gerritbot added a comment.Jun 24 2020, 2:42 PM

Change 607522 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/ArticlePlaceholder@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607522

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 2:42 PM
gerritbot added a comment.Jun 24 2020, 2:49 PM

Change 607526 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/ContentTranslation@master] Stop using WBC_VERSION

https://gerrit.wikimedia.org/r/607526

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 2:50 PM
gerritbot added a comment.Jun 24 2020, 2:53 PM

Change 607527 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/VisualEditor@master] Stop using WBC_VERSION

https://gerrit.wikimedia.org/r/607527

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 2:53 PM
gerritbot added a comment.Jun 24 2020, 3:41 PM

Change 607526 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Stop using WBC_VERSION

https://gerrit.wikimedia.org/r/607526

gerritbot added a comment.Jun 24 2020, 3:45 PM

Change 607527 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Stop using WBC_VERSION

https://gerrit.wikimedia.org/r/607527

gerritbot added a comment.Jun 24 2020, 3:56 PM

Change 607545 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607545

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 3:56 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 4:01 PM
gerritbot added a comment.Jun 24 2020, 4:11 PM

Change 607522 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607522

gerritbot added a comment.Jun 24 2020, 4:11 PM

Change 607521 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607521

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 24 2020, 4:14 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 24 2020, 5:29 PM
Ladsgroup moved this task from Peer Review to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 25 2020, 11:21 AM
gerritbot added a comment.Jun 25 2020, 11:38 AM

Change 607545 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Stop using WB_VERSION

https://gerrit.wikimedia.org/r/607545

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 12:10 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 25 2020, 12:20 PM
Lucas_Werkmeister_WMDE added a comment.Jun 25 2020, 12:45 PM

This snippet in WikibaseClient.example.php is going to be interesting:

// If this wiki also runs the Wikibase repo extension,
// use the automatic defaults for repo-related settings.
// If this wiki isn't running the repo extension,
// configure an example repo.
if ( !defined( 'WB_VERSION' ) ) {

I stepped through it with the debugger to confirm my suspicion – at the point that this file is loaded, the WikibaseRepository extension is not yet loaded (i. e. ExtensionRegistry::getInstance()->isLoaded( 'WikibaseRepository' ) will return false). The extension is queued, which we could detect by finding its JSON file in ExtensionRegistry::getInstance()->getQueue(), but that method is internal and “not intended to be used outside of the installer”. This also touches on task T256252: Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point, I think.

gerritbot added a comment.Jun 25 2020, 1:21 PM

Change 607785 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Stop checking WB[LC]?_VERSION for registration

https://gerrit.wikimedia.org/r/607785

gerritbot added a project: Patch-For-Review.Jun 25 2020, 1:21 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 25 2020, 1:21 PM
gerritbot added a comment.Jun 25 2020, 1:58 PM

Change 607792 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove WBL_VERSION from cache key prefix

https://gerrit.wikimedia.org/r/607792

gerritbot added a comment.Jun 25 2020, 2:38 PM

Change 607792 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove WBL_VERSION from cache key prefix

https://gerrit.wikimedia.org/r/607792

gerritbot added a comment.Jun 25 2020, 5:21 PM

Change 607785 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop checking WB[LC]?_VERSION for registration

https://gerrit.wikimedia.org/r/607785

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2020, 6:10 PM
Ladsgroup moved this task from Peer Review to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 26 2020, 5:10 AM
Lucas_Werkmeister_WMDE added a comment.Jun 29 2020, 10:52 AM

Remaining uses of the constants:

  • To check whether Repo or Client are enabled, in WikibaseSettings. Can be removed once I15020f34b2 has rolled out with the train and we haven’t seen any “used during early initialization” warnings in logstash. (When doing that, also change the comments in WikibaseClient.default.php and ClientDefaultsTest.php, for the thisWikiIsTheRepo setting, to mention ExtensionRegistry rather than WB_VERSION.)
  • To check whether the main PHP entry point was loaded correctly, in Wikibase.example.php and WikibaseClient.example.php – they die() with a message to load the PHP entry point first if the constant isn’t defined. I think this can be replaced with a more general check for the MEDIAWIKI constant (the standard “not an entry point” error pattern in PHP entry points, back before extension.json was a thing): I don’t think it’s necessary to check the Wikibase-specific constants. (Historical note: the first check of a Wikibase-specific constant, rather than the general MEDIAWIKI constant, was added in Iee722e1425, November 2012. Prior to that change, Wikibase.experimental.php had been an alternative entry point that could be used instead of Wikibase.php; with that change, Wikibase.php was the only entry point, and experimental features were enabled with define( 'WB_EXPERIMENTAL_FEATURES', true ) instead. (The whole concept of experimental features was then later dropped in favor of more specific feature flags, in I5fd3c44cc4, October 2015.) So at that point, it actually made sense to check the Wikibase-specific constant and tell users to use the correct PHP entry point instead, because previously they had been told to use Wikibase.experimental.php as the entry point and now they needed to update their LocalSettings.php. Shortly afterwards, in I8313756e94, February 2013, more PHP entry points were added, and they also checked Wikibase-specific constants – here, I assume, this was more or less copy+pasted from the Wikibase.experimental.php check, but I don’t think it was really necessary, since the files in question were completely new, and there was no reason to expect anybody to load them directly without first loading the correct entry points. And now, over seven years later, I think the risk of anybody directly loading the wrong entry point, and therefore needing the detailed error message “you should load this other entry point instead”, is nil.)
  • To check whether an example repository should be configured, in WikibaseClient.example.php. If the current wiki is also a repo, then WikibaseClient uses it by default and needs to special configuration, but if the current wiki is not a repo, then those example settings will configure an example repo (database repo, URL http://repo.example.org, etc.). At some point during the extension registration work, we’ll have to think about the whole settings business anyways; but for now, just to resolve this task and get rid of the WB[CL]?_VERSION constants, I propose to introduce a new constant just for this one use case, which will not be used anywhere else, especially not in other extensions – something like WB_NO_CONFIGURE_EXAMPLE_REPO, defined in the Repo PHP entry point and checked in WikibaseClient.example.php.
gerritbot added a comment.Jun 29 2020, 1:59 PM

Change 608323 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Don’t check WBC?_VERSION constants in example config

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608323

gerritbot added a project: Patch-For-Review.Jun 29 2020, 1:59 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 29 2020, 1:59 PM
gerritbot added a comment.Jun 29 2020, 2:01 PM

Change 608326 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove WBL_VERSION constant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608326

gerritbot added a comment.Jun 29 2020, 2:52 PM

Change 608323 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t check WBC?_VERSION constants in example config

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608323

gerritbot added a comment.Jun 29 2020, 2:52 PM

Change 608326 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove WBL_VERSION constant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608326

Lucas_Werkmeister_WMDE moved this task from Peer Review to Doing on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jun 29 2020, 3:46 PM
gerritbot added a comment.Jul 2 2020, 11:42 AM

Change 609137 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Stop checking WBC?_VERSION for extension registration

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609137

gerritbot added a comment.Jul 2 2020, 11:42 AM

Change 609138 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove WBC_VERSION constant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609138

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 2 2020, 11:43 AM
gerritbot added a comment.Jul 2 2020, 2:22 PM

Change 609166 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Don’t use WB_VERSION in Client example config

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609166

gerritbot added a comment.Jul 2 2020, 3:47 PM

Change 609166 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don’t use WB_VERSION in Client example config

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609166

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.40; 2020-07-07); removed MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jul 2 2020, 4:00 PM
gerritbot added a comment.Jul 2 2020, 4:13 PM

Change 609137 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop checking WBC?_VERSION for extension registration

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609137

gerritbot added a comment.Jul 2 2020, 4:38 PM

Change 609138 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove WBC_VERSION constant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609138

gerritbot added a comment.Jul 2 2020, 4:52 PM

Change 609205 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove WB_VERSION constant

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609205

gerritbot added a comment.Jul 2 2020, 9:48 PM

Change 609205 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove WB_VERSION constant

https://gerrit.wikimedia.org/r/609205

Ladsgroup moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 2) board.Jul 3 2020, 12:31 AM
Ladsgroup subscribed.

All done: https://gerrit.wikimedia.org/r/q/bug:T256238

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 3 2020, 10:01 AM
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 2) board.
gerritbot added a comment.Jul 6 2020, 2:37 PM

Change 609791 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/vagrant@master] Stop using WBL_VERSION constant

https://gerrit.wikimedia.org/r/609791

gerritbot added a comment.Jul 6 2020, 2:40 PM

Change 609791 merged by jenkins-bot:
[mediawiki/vagrant@master] Stop using WBL_VERSION constant

https://gerrit.wikimedia.org/r/609791

Lucas_Werkmeister_WMDE mentioned this in T257449: Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack.Jul 9 2020, 5:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits