Description

This adds unnecessary indirection to a static method and should be added unconditionally to skins using SkinMustache without the skin developer having to think about it.

Acceptance criteria

Update SkinTemplate to call MWDebug::getHTMLDebugLog() directly
Mark Skin::getHTMLDebugLog as deprecated
Update SkinMustache to include the text getHTMLDebugLog in html-printtail

Details

	Subject	Repo	Branch	Lines +/-
	Deprecate Skin::generateDebugHTML()	mediawiki/core	master	+17 -15
	Call MWDebug::getHTMLDebugLog() directly	mediawiki/skins/Vector	master	+2 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ammarpad	T255924 [EPIC] SkinMustache::getTemplateData should return data common to all skins
		Resolved		Ammarpad	T256927 Deprecate Skin::generateDebugHTML

Event Timeline

Jdlrobson created this task.Jul 1 2020, 10:28 PM

Jdlrobson added projects: MediaWiki-User-Interface, MW-1.35-release.Jul 1 2020, 10:31 PM

Jdlrobson mentioned this in T255924: [EPIC] SkinMustache::getTemplateData should return data common to all skins.Jul 1 2020, 10:33 PM

Ammarpad claimed this task.Jul 2 2020, 12:42 PM

Jdlrobson moved this task from Backlog to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jul 2 2020, 4:04 PM

Change 609203 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] T256927

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /609203

gerritbot added a project: Patch-For-Review.Jul 2 2020, 4:29 PM

Change 609203 abandoned by Jdlrobson:
T256927

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /609203

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2020, 5:10 PM

Change 609404 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Vector@master] Call MWDebug::getHTMLDebugLog() directly

https://gerrit.wikimedia.org/r/609404

gerritbot added a project: Patch-For-Review.Jul 3 2020, 9:40 AM

Change 609487 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::generateDebugHTML()

https://gerrit.wikimedia.org/r/609487

Change 609404 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Call MWDebug::getHTMLDebugLog() directly

https://gerrit.wikimedia.org/r/609404

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 6 2020, 5:00 PM

Jdlrobson closed this task as Resolved.Jul 6 2020, 6:26 PM

Jdlrobson updated the task description. (Show Details)

Change 609487 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::generateDebugHTML()

https://gerrit.wikimedia.org/r/609487

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2020, 7:10 PM