[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T256922

{{SUBPAGENAME}} no longer returning the title for pages without subpages
Closed, ResolvedPublic
Actions

Description

As a consequence of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/605185, which was for T229443, the {{SUBPAGENAME}} variable stopped returning the page title if the current page is not a subpage (this was also reported by @Soda at T229443#6272892). Quick comparison table for the value of {{SUBPAGENAME}}:

titlepreviouscurrent
Foo/Bar'Bar''Bar'
Foo'Foo'''

Judging from the task, this was not intentional, and it can (and does) break stuff on wiki (I've witnessed a report of a broken template), so the previous behaviour should be restored.

Details

SubjectRepoBranchLines +/-
Revert "Title: fix subpage split for degenerate cases"mediawiki/coremaster+21 -103
title: Make getSubpageText() return the title text if there's no subpagemediawiki/coremaster+5 -3
Use RejectParserCacheValue to reject parser output from 19:10–22:40 UTCoperations/mediawiki-configmaster+14 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Jul 1 2020, 9:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2020, 9:56 PM
Daimona claimed this task.Jul 1 2020, 9:59 PM
Krinkle triaged this task as High priority.Jul 1 2020, 10:02 PM
Krinkle added a project: Platform Engineering.
Krinkle added a project: MW-1.35-release.
Krinkle added a parent task: T254176: 1.35.0-wmf.39 deployment blockers.
gerritbot added a comment.Jul 1 2020, 10:07 PM

Change 608843 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Revert "Title: fix subpage split for degenerate cases"

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608843

gerritbot added a project: Patch-For-Review.Jul 1 2020, 10:07 PM
Krinkle added a parent task: T256668: 1.35.0-wmf.40 deployment blockers.Jul 1 2020, 10:07 PM
gerritbot added a comment.Jul 1 2020, 10:10 PM

Change 608964 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] title: Make getSubpageText() return the title text if there's no subpage

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608964

gerritbot added a comment.Jul 1 2020, 10:42 PM

Change 608971 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[operations/mediawiki-config@master] Use RejectParserCacheValue to reject parser output from 19:10–22:40 UTC

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608971

gerritbot added a comment.Jul 1 2020, 11:02 PM

Change 608971 merged by jenkins-bot:
[operations/mediawiki-config@master] Use RejectParserCacheValue to reject parser output from 19:10–22:40 UTC

https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/ /608971

Krinkle reassigned this task from Daimona to daniel.Jul 1 2020, 11:21 PM
Krinkle subscribed.

I've reverted the patch in-branch and configured MW to lazily invalidate the 3 hours of bad parser cache entries.

@daniel There's a patch by @Daimona for master that seems to fix this. I'll let you review and beta-verify that. I didn't go with it right away because I wanted to give you some time to look at this from other angles and maybe check if there are other cases we have missed, so that we can land it relaxedly in master ahead of the next branch.

Unblocking this train, speculatively blocking the next.

Krinkle removed a parent task: T254176: 1.35.0-wmf.39 deployment blockers.Jul 1 2020, 11:21 PM
Aklapper added a comment.Jul 2 2020, 8:49 AM

(The dark areas of my brain reminded me of T208181: {{FULLPAGENAME}} no longer works for the Special namespace but had to realize that's a different one.)

Aklapper added a comment.Jul 2 2020, 8:52 AM

Could this also have triggered T256878: Items in bread-crumb trail not shown any longer as GeoCrumbs calls getSubpageText() for the $linkText?

Daimona merged a task: T256878: Items in bread-crumb trail not shown any longer.Jul 2 2020, 9:57 AM
Daimona added subscribers: RolandUnger, Andyrom75.
In T256922#6273884, @Aklapper wrote:

Could this also have triggered T256878: Items in bread-crumb trail not shown any longer as GeoCrumbs calls getSubpageText() for the $linkText?

I'd say yes. In fact, the breadcrumbs are now working as expected (fix was backported yesterday night).

daniel added a comment.Jul 2 2020, 8:35 PM

I got the expected behavior wrong for getSubpageText() when writing the fix for getBaseText(). Sorry about that.

gerritbot added a comment.Jul 2 2020, 8:54 PM

Change 608964 merged by jenkins-bot:
[mediawiki/core@master] title: Make getSubpageText() return the title text if there's no subpage

https://gerrit.wikimedia.org/r/608964

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 2 2020, 9:00 PM
Soda mentioned this in T256763: WikitextLinksExtractor fails tests in ProofreadPage.Jul 3 2020, 6:55 AM
gerritbot added a comment.Jul 3 2020, 10:59 AM

Change 608843 abandoned by Daniel Kinzler:
[mediawiki/core@master] Revert "Title: fix subpage split for degenerate cases"

Reason:
Better fix is merged I0928f85c862d3b2baf49317

https://gerrit.wikimedia.org/r/608843

Aklapper mentioned this in T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle makeTitleSafe via GeoCrumbsHooks).Jul 3 2020, 11:00 AM
Jdforrester-WMF subscribed.Jul 6 2020, 7:21 PM

This is now Resolved, right?

Krinkle closed this task as Resolved.Jul 6 2020, 7:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits