[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T256627

Embedded surveys are incorrectly shown even when embed element is missing
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Due to a bug, when the embedded element is missing, the embedded survey becomes available to show as a randomized survey on the page.

This makes it unsafe to deploy T253112: Create survey for TechWish prototype announcements on dewiki and metawiki configuration-first. We should fix to make it easier to control survey visibility.

Details

SubjectRepoBranchLines +/-
Embedded surveys are hidden when no element is availablemediawiki/extensions/QuickSurveyswmf/1.35.0-wmf.38+4 -4
Embedded surveys are hidden when no element is availablemediawiki/extensions/QuickSurveysmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Jun 29 2020, 11:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2020, 11:11 AM
awight set the point value for this task to 1.Jun 29 2020, 11:11 AM
awight moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Jun 29 2020, 11:42 AM
awight added projects: WMDE-QWERTY-Sprint-2020-06-24, Unplanned-Sprint-Work.

Fixing in the current sprint.

gerritbot added a comment.Jun 29 2020, 11:59 AM

Change 608300 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@master] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608300

gerritbot added a project: Patch-For-Review.Jun 29 2020, 11:59 AM
awight moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-06-24 board.Jun 29 2020, 12:00 PM
awight claimed this task.Jun 29 2020, 12:03 PM
• nray added a project: Web-Team-Backlog (Tracking).Jun 29 2020, 11:16 PM
gerritbot added a comment.Jun 30 2020, 8:58 AM

Change 608300 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608300

gerritbot added a comment.Jun 30 2020, 9:48 AM

Change 608477 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@wmf/1.35.0-wmf.38] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608477

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jun 30 2020, 10:00 AM
gerritbot added a comment.Jun 30 2020, 11:23 AM

Change 608477 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@wmf/1.35.0-wmf.38] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608477

Stashbot added a comment.Jun 30 2020, 11:28 AM

Mentioned in SAL (#wikimedia-operations) [2020-06-30T11:28:31Z] <awight@deploy1001> Synchronized php-1.35.0-wmf.38/extensions/QuickSurveys: BACON: [[gerrit:608477|Embedded surveys are hidden when no element is available (T256627)]] (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.38; 2020-06-23); removed MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jun 30 2020, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 1 2020, 7:00 PM
awight moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-06-24 board.Jul 2 2020, 7:50 AM
Lena_WMDE closed this task as Resolved.Jul 7 2020, 11:41 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-06-24 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits