[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T255309

Remove UserRightsProxy and replace its usages with UserGroupManager (remove in 1.42)
Closed, ResolvedPublic
Actions

Description

The UserRightsProxy was used to get/set groups for the users in foreign wikis. We need to remove all usages of this class, since now the correct way of accessing groups for users in the foreign wikis is to use UserGroupManagerFactory to create a manager pointing to the correct domain.

CodeSearch: https://codesearch.wmcloud.org/search/?q=UserRightsProxy&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Remove UserRightsProxymediawiki/coremaster+101 -631
user: Hard-deprecate UserRightsProxymediawiki/coremaster+45 -5
cross-wiki userrights: Restore hook compatibilitymediawiki/coremaster+12 -11
cross-wiki userrights: Add SpecialUserRights::getDisplayUsernamemediawiki/corewmf/1.41.0-wmf.22+23 -5
cross-wiki userrights: Add SpecialUserRights::getDisplayUsernamemediawiki/coremaster+23 -5
specials: Use cross-wiki aware UserIdentityLookup on Special:UserRightsmediawiki/coremaster+47 -34
Remove cross-wiki user right change support from Special:BatchUserRightsmediawiki/extensions/BatchUserRightsmaster+6 -30
user: Call UserFactory::invalidateCache for user group changesmediawiki/coremaster+4 -2
Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"mediawiki/coremaster+33 -46
maintenance: Remove UserRightsProxy from CreateAndPromote::addLogEntrymediawiki/coremaster+1 -1
Inline calls to CentralAuthGroupMembershipProxy and remove proxymediawiki/extensions/CentralAuthmaster+48 -201
Adjust doc type to UserIdentitymediawiki/extensions/GlobalUserrightsmaster+5 -4
Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"mediawiki/corewmf/1.41.0-wmf.19+33 -46
specials: Use cross-wiki aware UserIdentityLookup on Special:UserRightsmediawiki/coremaster+46 -33
user: Assert wikiId in UserGroupManagermediawiki/coremaster+30 -14
user: Move UserRightsProxy::invalidateCache to UserFactorymediawiki/coremaster+134 -26
Don't mention deprecated UserRightsProxymediawiki/extensions/Echomaster+7 -4
Remove mentions of deprecated UserRightsProxymediawiki/extensions/CentralAuthmaster+3 -4
Formally deprecate UserRightsProxymediawiki/coremaster+3 -0
Make UserRightsProxy implement UserIdentitymediawiki/coremaster+69 -19
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 9 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2021, 5:10 PM
Vlad.shapik claimed this task.Nov 1 2021, 12:46 PM
Vlad.shapik removed Vlad.shapik as the assignee of this task.Nov 19 2021, 9:10 AM
Vlad.shapik subscribed.
gerritbot added a comment.Feb 12 2022, 2:38 PM

Change 762064 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Formally deprecate UserRightsProxy

https://gerrit.wikimedia.org/r/762064

gerritbot added a project: Patch-For-Review.Feb 12 2022, 2:38 PM
Daimona mentioned this in T88510: Create common interface for User, UserRightsProxy, and CentralAuthGroupMembershipProxy.Feb 13 2022, 7:03 PM
gerritbot added a comment.Feb 13 2022, 7:21 PM

Change 762064 merged by jenkins-bot:

[mediawiki/core@master] Formally deprecate UserRightsProxy

https://gerrit.wikimedia.org/r/762064

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 13 2022, 8:00 PM
Daimona subscribed.Feb 13 2022, 8:15 PM

Something interesting came out while grepping usages: T301642. That needs to be fixed somehow. Making it not use UserrightsPage at all would be nice.

Zabe removed a project: Patch-For-Review.Mar 31 2022, 3:24 PM
Simetrical subscribed.Apr 13 2022, 3:58 PM

What should be used for invalidateCache? Should UserRightsManager have something that can do that, or should it go elsewhere?

Zabe added a comment.Apr 14 2022, 7:34 PM
In T255309#7852087, @Simetrical wrote:

What should be used for invalidateCache? Should UserRightsManager have something that can do that, or should it go elsewhere?

UserRightsProxy is only there for changing user rights cross-wiki. There is UserGroupManager::clearCache(), which cleans cached group memberships for some user identity. I don't think more is needed since changing the user rights cross-wiki doesn't actually touch the user table.

Simetrical added a comment.Apr 14 2022, 7:58 PM

It changes the user table for the other wiki, right? Surely that's why UserRightsProxy::invalidateCache exists to begin with?

Simetrical added a comment.Apr 24 2022, 12:53 PM

@daniel, ping?

daniel added a subscriber: Urbanecm.Apr 25 2022, 10:03 AM

I'll try to give my two cents, but @Zabe and @Urbanecm probably have a better understanding of the intended and current semantics.

So here's my current take:

  • historically, SpecialGlobalGroupMembership used to extend UserrightsPage. It used to override fetchUser, and returned a CentralAuthGroupMembershipProxy instead of the UserrightsProxy that the base class would return. CentralAuthGroupMembershipProxy was made to be duck-type compatible with UserrightsProxy, and everything relied on that fact.
  • Zabe fixed this recently, in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/738574. Now, SpecialGlobalGroupMembership is independent of UserrightsPage, and CentralAuthGroupMembershipProxy is independent of UserrightsProxy. That should make this task here a whole lot simpler!
  • This means that UserrightsPage no longer needs to support cross-wiki functionality at all. (Is that correct? Please let me know if I am mistaking here!)
  • Methods like saveSettings() and invalidateCache() can become private methods in UserrightsPage.

One more thing for context, because I saw it discussed elsewhere and now I can't find it: Title and WikiPage are guaranteed to be local. Making them support non-local pages would break that guarantee and violate LSP!

taavi added a comment.Apr 25 2022, 10:06 AM
In T255309#7876300, @daniel wrote:
  • This means that UserrightsPage no longer needs to support cross-wiki functionality at all. (Is that correct? Please let me know if I am mistaking here!)

Core still needs to support the raw interwiki rights syntax (Username@dbnamewiki).

daniel added a comment.EditedApr 25 2022, 10:18 AM
In T255309#7876308, @Majavah wrote:

Core still needs to support the raw interwiki rights syntax (Username@dbnamewiki).

Darn. Ok then.

I think it should be still possible to do the following:

  • create a getUserIdentity() method, and use it instead of fetchUser().
  • change all code in UserrightsPage that currently operates on a User or UserrightsProxy to operate on a UserIdentity. Move all logic from UserrightsProxy into UserrightsPage. Make sure to use the correct DB connection (and the correct UserGroupManager) per UserIdentity::getWikiId().
  • deprecate fetchUser, and make UserrightsProxy a stub. It can have the UserrightsPage injected, and delegate all calls back to UserrightsPage (the relevant methods on UserrightsPage should be tagged @internal).

Note the following code in the constructor of UserrightsdPage:

		// TODO don't hard code false, use interwiki domains. See T14518
		$this->userGroupManager = ( $userGroupManagerFactory ?? $services->getUserGroupManagerFactory() )
			->getUserGroupManager( false );

My suggestion above should fix that, I hope.

Daimona added a comment.Apr 25 2022, 10:52 AM

FTR, I made an attempt at removing usages of UserRightsProxy: r762507. I remember having a few doubts as to how to proceed, though. One of those questions was whether it would be better/easier to do something like r762118 (ChangeUserGroups command) first, or the other way around.

Simetrical renamed this task from Remove UserRightsProxy and replace it's usages with UserGroupManager to Remove UserRightsProxy and replace its usages with UserGroupManager.Apr 26 2022, 3:03 PM
Simetrical added a comment.Apr 26 2022, 3:05 PM

So a basic question: if I have the ID of a non-local wiki, how do I find out the corresponding database domain? This is necessary to implement UserRightsProxy::invalidateCache as a method of UserrightsPage.

daniel added a comment.EditedApr 26 2022, 4:29 PM
In T255309#7881270, @Simetrical wrote:

So a basic question: if I have the ID of a non-local wiki, how do I find out the corresponding database domain? This is necessary to implement UserRightsProxy::invalidateCache as a method of UserrightsPage.

For now we can assume that the wiki ID *is* the database domain. Or at least we can assume that the LoadBalancer will treat it as an alias.

gerritbot added a comment.Apr 28 2022, 12:54 PM

Change 786318 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/core@master] Remove UserRightsProxy

https://gerrit.wikimedia.org/r/786318

gerritbot added a project: Patch-For-Review.Apr 28 2022, 12:54 PM
gerritbot added a comment.May 1 2022, 2:45 PM

Change 787917 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/extensions/CentralAuth@master] Try converting special page to UserIdentity

https://gerrit.wikimedia.org/r/787917

gerritbot added a comment.May 1 2022, 3:19 PM

Change 787920 had a related patch set uploaded (by Simetrical; author: Simetrical):

[mediawiki/extensions/Echo@master] Don't mention deprecated UserRightsProxy

https://gerrit.wikimedia.org/r/787920

gerritbot added a comment.May 1 2022, 7:39 PM

Change 787920 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Don't mention deprecated UserRightsProxy

https://gerrit.wikimedia.org/r/787920

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 1 2022, 8:00 PM
gerritbot added a comment.May 3 2022, 10:48 AM

Change 787917 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove mentions of deprecated UserRightsProxy

https://gerrit.wikimedia.org/r/787917

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.12; 2022-05-16); removed MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 3 2022, 11:00 AM
gerritbot added a comment.Feb 20 2023, 10:58 PM

Change 890510 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] [DNM] PoC: Create a UserIdentityCacheUpdater service

https://gerrit.wikimedia.org/r/890510

Umherirrender subscribed.Feb 20 2023, 11:00 PM
gerritbot added a comment.Apr 30 2023, 10:34 PM

Change 890510 merged by jenkins-bot:

[mediawiki/core@master] user: Move UserRightsProxy::invalidateCache to UserFactory

https://gerrit.wikimedia.org/r/890510

gerritbot added a comment.May 3 2023, 10:23 PM

Change 914900 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Assert wikiId in UserGroupManager

https://gerrit.wikimedia.org/r/914900

gerritbot added a comment.May 21 2023, 10:09 AM

Change 914900 merged by jenkins-bot:

[mediawiki/core@master] user: Assert wikiId in UserGroupManager

https://gerrit.wikimedia.org/r/914900

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 21 2023, 11:00 AM
Umherirrender added a subtask: T337590: Assert correct wiki for the user identity in UserGroupManager for cross-wiki group changes/reading.May 26 2023, 8:42 PM
gerritbot added a comment.May 26 2023, 10:55 PM

Change 923706 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights

https://gerrit.wikimedia.org/r/923706

Umherirrender closed subtask T337590: Assert correct wiki for the user identity in UserGroupManager for cross-wiki group changes/reading as Resolved.Jul 13 2023, 9:07 PM
gerritbot added a comment.Jul 24 2023, 10:31 PM

Change 923706 merged by jenkins-bot:

[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights

https://gerrit.wikimedia.org/r/923706

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.19; 2023-07-25); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jul 24 2023, 11:00 PM
gerritbot added a comment.Jul 25 2023, 8:19 PM

Change 941516 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GlobalUserrights@master] Adjust doc type to UserIdentity

https://gerrit.wikimedia.org/r/941516

gerritbot added a comment.Jul 25 2023, 8:34 PM

Change 941519 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BatchUserRights@master] Use cross-wiki aware UserIdentityLookup on Special:BatchUserRights

https://gerrit.wikimedia.org/r/941519

Umherirrender mentioned this in T302408: Argument 1 passed to HAWelcomeHooks::onUserGroupsChanged() must be an instance of User, instance of CentralAuthGroupMembershipProxy given, called in /srv/mediawiki/w/includes/HookContainer/HookContainer.php on line 338.Jul 25 2023, 9:10 PM
gerritbot added a comment.Jul 25 2023, 9:12 PM

Change 941522 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] Inline calls to CentralAuthGroupMembershipProxy and remove proxy

https://gerrit.wikimedia.org/r/941522

gerritbot added a comment.Jul 26 2023, 1:40 PM

Change 941876 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"

https://gerrit.wikimedia.org/r/941876

gerritbot added a comment.Jul 26 2023, 1:42 PM

Change 941877 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.41.0-wmf.19] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"

https://gerrit.wikimedia.org/r/941877

gerritbot added a comment.Jul 26 2023, 1:59 PM

Change 941877 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.19] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"

https://gerrit.wikimedia.org/r/941877

Stashbot added a comment.Jul 26 2023, 2:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:00:51Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]]

Stashbot mentioned this in T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki'.Jul 26 2023, 2:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:02:29Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Jul 26 2023, 2:13 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:13:25Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]] (duration: 12m 33s)

gerritbot added a comment.Jul 26 2023, 4:50 PM

Change 941968 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Call UserFactory::invalidateCache for user group changes

https://gerrit.wikimedia.org/r/941968

gerritbot added a comment.Jul 26 2023, 4:51 PM

Change 941516 merged by Umherirrender:

[mediawiki/extensions/GlobalUserrights@master] Adjust doc type to UserIdentity

https://gerrit.wikimedia.org/r/941516

gerritbot added a comment.Jul 26 2023, 5:38 PM

Change 941876 merged by jenkins-bot:

[mediawiki/core@master] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"

https://gerrit.wikimedia.org/r/941876

gerritbot added a comment.Jul 26 2023, 6:06 PM

Change 941513 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] maintenance: Remove UserRightsProxy from CreateAndPromote::addLogEntry

https://gerrit.wikimedia.org/r/941513

gerritbot added a comment.Jul 26 2023, 7:24 PM

Change 941522 abandoned by Umherirrender:

[mediawiki/extensions/CentralAuth@master] Inline calls to CentralAuthGroupMembershipProxy and remove proxy

Reason:

I am go with If2722377dcce5349b4ed8dc2507f9e7a1dcaa9a5

https://gerrit.wikimedia.org/r/941522

gerritbot added a comment.Jul 27 2023, 7:34 AM

Change 941513 merged by jenkins-bot:

[mediawiki/core@master] maintenance: Remove UserRightsProxy from CreateAndPromote::addLogEntry

https://gerrit.wikimedia.org/r/941513

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 27 2023, 8:00 AM
gerritbot added a comment.Aug 1 2023, 10:29 AM

Change 944188 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights

https://gerrit.wikimedia.org/r/944188

gerritbot added a comment.Aug 1 2023, 10:29 AM

Change 941968 abandoned by Umherirrender:

[mediawiki/core@master] user: Call UserFactory::invalidateCache for user group changes

Reason:

Moved to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/944188

https://gerrit.wikimedia.org/r/941968

gerritbot added a comment.Aug 1 2023, 11:14 AM

Change 941519 merged by jenkins-bot:

[mediawiki/extensions/BatchUserRights@master] Remove cross-wiki user right change support from Special:BatchUserRights

https://gerrit.wikimedia.org/r/941519

gerritbot added a comment.Aug 7 2023, 2:55 PM

Change 944188 merged by jenkins-bot:

[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights

https://gerrit.wikimedia.org/r/944188

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 7 2023, 2:55 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 7 2023, 3:00 PM
Umherirrender mentioned this in T343724: 1.41.0-wmf.22 deployment blockers.Aug 7 2023, 5:01 PM
Umherirrender updated the task description. (Show Details)
Krinkle edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Platform Team Workboards (MW Expedition), Core Platform Team Initiatives (Decoupling (CDP2)).Aug 17 2023, 3:47 AM
gerritbot added a comment.Aug 17 2023, 10:57 AM

Change 949939 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayName

https://gerrit.wikimedia.org/r/949939

gerritbot added a comment.Aug 17 2023, 12:27 PM

Change 949582 had a related patch set uploaded (by Urbanecm; author: Umherirrender):

[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949582

gerritbot added a comment.Aug 17 2023, 12:41 PM

Change 949939 merged by jenkins-bot:

[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949939

gerritbot added a comment.Aug 17 2023, 1:21 PM

Change 949582 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949582

Stashbot mentioned this in T316079: Bump threshold for confidence score on link recommendation service suggestions.Aug 17 2023, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:05Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]]

Stashbot mentioned this in T344391: Interwiki user rights changes not being logged correctly.Aug 17 2023, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:55Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.c

Stashbot added a comment.Aug 17 2023, 1:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:28:52Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] (duration: 05m 46s)

gerritbot added a comment.Aug 17 2023, 6:05 PM

Change 950003 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] cross-wiki userrights: Restore hook compatibility

https://gerrit.wikimedia.org/r/950003

gerritbot added a comment.Aug 22 2023, 8:47 PM

Change 950003 merged by jenkins-bot:

[mediawiki/core@master] cross-wiki userrights: Restore hook compatibility

https://gerrit.wikimedia.org/r/950003

gerritbot added a comment.Aug 29 2023, 6:57 PM

Change 953329 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Hard-deprecate UserRightsProxy

https://gerrit.wikimedia.org/r/953329

gerritbot added a comment.Aug 29 2023, 7:29 PM

Change 953329 merged by jenkins-bot:

[mediawiki/core@master] user: Hard-deprecate UserRightsProxy

https://gerrit.wikimedia.org/r/953329

Umherirrender renamed this task from Remove UserRightsProxy and replace its usages with UserGroupManager to Remove UserRightsProxy and replace its usages with UserGroupManager (remove in 1.42).Aug 29 2023, 7:34 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 29 2023, 8:01 PM
Jdforrester-WMF added a project: MW-1.42-release.Sep 22 2023, 12:20 PM
Umherirrender changed the task status from Stalled to Open.Oct 13 2023, 3:47 PM
gerritbot added a comment.Oct 19 2023, 1:41 PM

Change 966656 had a related patch set uploaded (by Daniel Kinzler; author: Tim Starling):

[mediawiki/core@master] Remove UserRightsProxy

https://gerrit.wikimedia.org/r/966656

gerritbot added a project: Patch-For-Review.Oct 19 2023, 1:41 PM
Umherirrender closed this task as Resolved.Oct 20 2023, 4:45 PM
Umherirrender removed a project: Patch-For-Review.
In T255309#9264918, @gerritbot wrote:

Change 966656 had a related patch set uploaded (by Daniel Kinzler; author: Tim Starling):

[mediawiki/core@master] Remove UserRightsProxy

https://gerrit.wikimedia.org/r/966656

Now merged

gerritbot added a comment.Oct 20 2023, 4:46 PM

Change 786318 abandoned by Umherirrender:

[mediawiki/core@master] Remove UserRightsProxy

Reason:

It's done, the class was now removed with Icb3395dfc53a4441b667f001ac1227f36d1f2e8d

https://gerrit.wikimedia.org/r/786318

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits