[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Newcomer tasks: UI fixes to the text elements on the Post-edit dialog
Closed, ResolvedPublic

Description

Actual desktop
image.png (449×564 px, 64 KB)
Expected desktop
image.png (300×500 px, 47 KB)
Actual mobile
image.png (224×682 px, 17 KB)
Expected mobile
image.png (640×360 px, 58 KB)

This task addresses a number of minor style issues related to the text inside of the post-edit dialog suggested edit card.

Specific issues :
i. "Next suggestion" header
Expected: Header style uses the OOUI Fieldset header style which is font-size:~18.2px on Mobile, and font-size:16px on Desktop
Actual: font-size is larger on both desktop and mobile

image.png (328×442 px, 42 KB)

ii. Next suggestion font-color on Desktop
Expected: Should use standard Progressive Button style which is color #36c
Actual: Using a blue not in the standard colour palette

image.png (262×486 px, 49 KB)

iii. Task difficulty text font-size
Expected: Task difficulty text font-style uses the Wikipedia hatnote thumbcaption style which is font-size:13px on Mobile, and font-size:12.4px on Desktop
Actual: On mobile the font-size is larger than expected at ~14.17px
(Note that the Task difficulty icon and text is also not vertically centered, but this was filed separately as T255613)

image.png (472×676 px, 45 KB)

iv. Icon and text spacing
Expected: Spacing between icon and text (for visits and task type) is 8px
Actual: margin set to 10px

image.png (362×1 px, 133 KB)

v. Remove the right and bottom padding from .mw-ge-help-panel-postedit-main .mw-ge-help-panel-postedit-card-text-container

Actual
image.png (512×638 px, 126 KB)
Expected:
image.png (214×686 px, 26 KB)

vi. Task type element on Mobile and desktop should be right aligned and anchored to the bottom of the ‘card’ “text container”.

vii. Page views stat is shown on the same row as the task type, taking maximum 50% of the flex-box space before text overflows

Event Timeline

@RHo do you have an example of the hatnote style somewhere else on the site? I want to check if it is something reusable.

vi. Task type element on Mobile and desktop should be right aligned and anchored to the bottom of the ‘card’ “text container”.
vii. Page views stat is shown on the same row as the task type, taking maximum 50% of the flex-box space before text overflows

They do that, showing them in separate rows is flex behavior for when they don't fit on the same line. Do we want to fit them in the same row even at the cost of truncating the text? That's visually nicer but feels less useful to me.

@RHo do you have an example of the hatnote style somewhere else on the site? I want to check if it is something reusable.

Sorry this should actually be the thumbcaption style which is used on image captions on articles:

Desktop example
image.png (768×658 px, 350 KB)
Mobile version
image.png (728×668 px, 265 KB)

vi. Task type element on Mobile and desktop should be right aligned and anchored to the bottom of the ‘card’ “text container”.
vii. Page views stat is shown on the same row as the task type, taking maximum 50% of the flex-box space before text overflows

They do that, showing them in separate rows is flex behavior for when they don't fit on the same line. Do we want to fit them in the same row even at the cost of truncating the text? That's visually nicer but feels less useful to me.

  • I think it is worth doing for the nicer visual here since users should now have familiarity with the SE (after having completed a task) to know what the two bits of data refer to even if the text is partially truncated.

Change 608972 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: UI fixes to the text elements on the post-edit dialog

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /608972

Change 608972 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: UI fixes to the text elements on the post-edit dialog

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /608972

Checked in betalabs -

i. "Next suggestion" header
Expected: Header style uses the OOUI Fieldset header style which is font-size:~18.2px on Mobile, and font-size:16px on Desktop

Desktop

betalabsproduciton
Screen Shot 2020-07-02 at 4.38.03 PM.png (475×563 px, 72 KB)
Screen Shot 2020-07-02 at 4.37.25 PM.png (472×556 px, 76 KB)
Screen Shot 2020-07-02 at 4.38.24 PM.png (391×505 px, 45 KB)
Screen Shot 2020-07-02 at 4.58.32 PM.png (391×502 px, 39 KB)

Mobile

betalabsproduciton
Screen Shot 2020-07-02 at 4.44.33 PM.png (509×385 px, 60 KB)
Screen Shot 2020-07-02 at 4.42.43 PM.png (679×393 px, 79 KB)

Seems that on mobile color #36c was in place.

ii. Next suggestion font-color on Desktop
Expected: Should use standard Progressive Button style which is color #36c

betalabsproduction
Desktop
Screen Shot 2020-07-02 at 4.39.38 PM.png (420×512 px, 62 KB)
Screen Shot 2020-07-02 at 4.39.51 PM.png (387×512 px, 53 KB)
Mobile
Screen Shot 2020-07-02 at 4.44.42 PM.png (501×422 px, 69 KB)
Screen Shot 2020-07-02 at 4.42.58 PM.png (690×401 px, 86 KB)

iii. Task difficulty text font-size
Expected: Task difficulty text font-style uses the Wikipedia hatnote thumbcaption style which is font-size:13px on Mobile, and font size:12.4px on Desktop

the font size on mobile is 11.5 vs 13 specified.

betalabsproduction
Desktop
Screen Shot 2020-07-02 at 5.24.16 PM.png (465×672 px, 91 KB)
Screen Shot 2020-07-02 at 5.25.24 PM.png (457×664 px, 78 KB)
Mobile
Screen Shot 2020-07-02 at 4.45.01 PM.png (450×395 px, 59 KB)
Screen Shot 2020-07-02 at 4.43.17 PM.png (353×382 px, 45 KB)

iv. Icon and text spacing
Expected: Spacing between icon and text (for visits and task type) is 8px

spacing between icon and visits is still 10px.

Screen Shot 2020-07-02 at 5.53.29 PM.png (260×514 px, 33 KB)
Screen Shot 2020-07-02 at 5.53.42 PM.png (216×757 px, 39 KB)

v. Remove the right and bottom padding from .mw-ge-help-panel-postedit-main .mw-ge-help-panel-postedit-card-text-container

Screen Shot 2020-07-02 at 5.58.41 PM.png (405×510 px, 56 KB)

vi. Task type element on Mobile and desktop should be right aligned and anchored to the bottom of the ‘card’ “text container”.

vii. Page views stat is shown on the same row as the task type, taking maximum 50% of the flex-box space before text overflows

.mw-ge-help-panel-postedit-main .mw-ge-help-panel-postedit-card-tasktype {
    flex: 1 0 0;
    justify-self: flex-end;
    text-align: right;
    text-overflow: ellipsis;
    overflow: hidden;
    white-space: nowrap;

Screen Shot 2020-07-02 at 6.06.44 PM.png (398×501 px, 50 KB)

Moving back so @Tgr can adjust the two minor items (iii) and (iv) that @Etonkovidova found. Thanks both!

iii. Task difficulty text font-size
Expected: Task difficulty text font-style uses the Wikipedia hatnote thumbcaption style which is font-size:13px on Mobile, and font size:12.4px on Desktop

the font size on mobile is 11.5 vs 13 specified.

betalabsproduction
Desktop
Screen Shot 2020-07-02 at 5.24.16 PM.png (465×672 px, 91 KB)
Screen Shot 2020-07-02 at 5.25.24 PM.png (457×664 px, 78 KB)
Mobile
Screen Shot 2020-07-02 at 4.45.01 PM.png (450×395 px, 59 KB)
Screen Shot 2020-07-02 at 4.43.17 PM.png (353×382 px, 45 KB)

iv. Icon and text spacing
Expected: Spacing between icon and text (for visits and task type) is 8px

spacing between icon and visits is still 10px.

Screen Shot 2020-07-02 at 5.53.29 PM.png (260×514 px, 33 KB)
Screen Shot 2020-07-02 at 5.53.42 PM.png (216×757 px, 39 KB)

Change 609777 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Post-edit panel style fixes

https://gerrit.wikimedia.org/r/609777

Change 609777 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Post-edit panel style fixes

https://gerrit.wikimedia.org/r/609777

  • the font size on mobile is 13 as specified.
Mobile before fix
Screen Shot 2020-07-02 at 4.45.01 PM.png (450×395 px, 59 KB)
Mobile after fix
Screen Shot 2020-07-07 at 2.44.48 PM.png (684×383 px, 94 KB)
  • spacing between icon and visits is fixed - 8px

iv. Icon and text spacing
Expected: Spacing between icon and text (for visits and task type) is 8px

before fix
Screen Shot 2020-07-02 at 5.53.29 PM.png (260×514 px, 33 KB)
after fix
Screen Shot 2020-07-07 at 3.53.54 PM.png (357×501 px, 46 KB)

Thanks, LGTM

  • the font size on mobile is 13 as specified.
Mobile before fix
Screen Shot 2020-07-02 at 4.45.01 PM.png (450×395 px, 59 KB)
Mobile after fix
Screen Shot 2020-07-07 at 2.44.48 PM.png (684×383 px, 94 KB)
  • spacing between icon and visits is fixed - 8px

iv. Icon and text spacing
Expected: Spacing between icon and text (for visits and task type) is 8px

before fix
Screen Shot 2020-07-02 at 5.53.29 PM.png (260×514 px, 33 KB)
after fix
Screen Shot 2020-07-07 at 3.53.54 PM.png (357×501 px, 46 KB)