[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Newcomer tasks: UI fixes to the Mobile footer buttons in the Post-edit dialog
Closed, ResolvedPublic

Description

Button styling should be as per the mobile peek drawer’s CTA button.

Actual
image.png (324×472 px, 40 KB)
Expected
image.png (640×360 px, 58 KB)

Specific issues:
i. Text color should be #36c
ii. Font-size should be 16px (per standard mobile button widget size)
iii. Reduce height of button to be 48px
iv. Buttons should be flush to the bottom of the screen - remove the 16px space between the bottom-most button and the bottom of the screen.

Event Timeline

Change 608975 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: UI fixes to the mobile footer buttons in the post-edit dialog

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /608975

Change 608975 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: UI fixes to the mobile footer buttons in the post-edit dialog

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/ /608975

Etonkovidova subscribed.

Checked in betalabs - all specs seem to be in place:

i. Text color should be #36c
ii. Font-size should be 16px (per standard mobile button widget size)
iii. Reduce height of button to be 48px
iv. Buttons should be flush to the bottom of the screen - remove the 16px space between the bottom-most button and the bottom of the screen.

overall lookText color #36c; Font-size should be 16pxthe height of button 48px
Screen Shot 2020-07-06 at 8.18.30 PM.png (694×412 px, 61 KB)
Screen Shot 2020-07-06 at 8.27.14 PM.png (305×419 px, 40 KB)
Screen Shot 2020-07-06 at 8.27.25 PM.png (471×405 px, 47 KB)
Screen Shot 2020-07-06 at 8.16.57 PM.png (692×370 px, 60 KB)
Screen Shot 2020-07-06 at 8.16.02 PM.png (283×392 px, 37 KB)
Screen Shot 2020-07-06 at 8.16.49 PM.png (706×425 px, 78 KB)

Checked in betalabs - all specs seem to be in place:

Agreed, thanks!

image.png (1×758 px, 143 KB)