The mockup in T238661: Step 1: nicer formatting of reference snaks (impact: high) shows an “external link” icon after the reference link, but we currently don’t include that, at least not in Vector.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: don’t remove default wrap output class | mediawiki/extensions/Wikibase | master | +12 -9 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Lydia_Pintscher | T238661 Step 1: nicer formatting of reference snaks (impact: high) | |||
| Resolved | Lucas_Werkmeister_WMDE | T248479 Add external link icon after links in references |
Event Timeline
Comment Actions
Tech note: the link is already marked as class="external" by the PHP Parser, but at least Vector only adds that icon after links matching .mw-parser-output .external, and we don’t have any element with that outer class. (I dimly seem to remember some other skin not caring about that, and adding that icon to any class="external" link, but I can’t be bothered to check right now.)
Since the reference HTML is parser output (as in, the API we use gets it from a Parser), I think it would be well within our rights to simply add that class and then let the skin add the icon, rather than doing it ourselves. I’m not yet sure if we should do that in JS or if the wbformatreference API response should already include that.
Such an icon would be smaller than the one seen in the T238661 screenshot, though (see below). @Charlie_WMDE or @Sarai-WMDE – is that acceptable?
Comment Actions
I think it would be well within our rights to simply add that class and then let the skin add the icon, rather than doing it ourselves."
I agree, sounds fair.
Such an icon would be smaller than the one seen in the T238661 screenshot, though (see below). @Charlie_WMDE or @Sarai-WMDE – is that acceptable?"
I believe it is perfectly acceptable (and even adds extra consistency) to let each skin add its default icon, @LucasWerkmeister.
Comment Actions
I believe it is perfectly acceptable (and even adds extra consistency) to let each skin add its default icon
The dimension of skins was mentioned more than once as a blind spot when discussing design of a potential component library. This is a very pragmatic decision (a tiny representative of a whole class of similar challenges) in the absence of conceptual decisions.
Case in point: there is no storybook to showcase how different components look like in different skins.
Comment Actions
Change 583577 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: don’t remove default wrap output class
Comment Actions
Change 583577 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: don’t remove default wrap output class