Wire up wrapper EntityWritingRepository
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 25 2020, 1:57 PM

Description

Update the service registration to use the new implementation from T248474, and adjust the integration/e2e tests. If the wiring change doesn’t break the tests on its own, then make sure to expand the tests so that we actually assert that unnecessary data is being removed.

Details

	Subject	Repo	Branch	Lines +/-
	bridge: wire up TrimmingWritingRepository	mediawiki/extensions/Wikibase	master	+248 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T230343 Step 1: Only send incremental changes through the API (impact: medium)
		Resolved		Lucas_Werkmeister_WMDE	T248475 Wire up wrapper EntityWritingRepository

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 25 2020, 1:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2020, 1:57 PM

Lucas_Werkmeister_WMDE mentioned this in T230343: Step 1: Only send incremental changes through the API (impact: medium).Mar 25 2020, 2:13 PM

Lucas_Werkmeister_WMDE claimed this task.Mar 30 2020, 12:37 PM

Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-17 board.

Change 584597 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: wire up DiffingWritingRepository

https://gerrit.wikimedia.org/r/584597

gerritbot added a project: Patch-For-Review.Mar 30 2020, 1:15 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-17 board.Mar 30 2020, 5:42 PM

Change 584597 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: wire up TrimmingWritingRepository

https://gerrit.wikimedia.org/r/584597

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 31 2020, 3:57 PM

Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-17 board.

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.26; 2020-03-31).Mar 31 2020, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 31 2020, 4:10 PM