[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T247155

Replace IP class with IPUtils (General)
Closed, ResolvedPublic
Actions

Description

The IP class in MW core is deprecated since 1.35, it should be replaced with IPUtils

This will require an use Wikimedia\IPUtils;, and also the required MW version bumping to >= 1.35 (which might cause codesniffer errors for other deprecated variables/classes)

This task is for non-Wikimedia deployed extensions. Extensions needing this change can be found in this code search.

  • examknow / CentralCheckUser
  • extensions / ArticleFeedbackv5
  • extensions / GlobalContributions
  • extensions / RegexBlock -- T248060
  • extensions / DonationInterface -- T248059
  • extensions / AnonPrivacy
  • extensions / BlueSpiceEditNotifyConnector
  • extensions / CookieWarning
  • extensions / DeviceMapLogCapture
  • extensions / GlobalBlocking
  • extensions / GlobalContribs
  • extensions / NetworkAuth
  • extensions / SecureSessions
  • femiwiki / Sanctions

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Ammarpad created this task.Mar 7 2020, 6:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2020, 6:49 AM
Reedy added a project: archived-IPUtils.Mar 7 2020, 11:33 AM
Reedy added a project: MediaWiki-extensions-General.Mar 8 2020, 11:22 PM
Soda subscribed.Mar 10 2020, 7:06 PM

@Ammarpad Can I try and work on this? (cause it says lk non-Wikimedia deployed extensions...)

Aklapper added a comment.Mar 11 2020, 9:10 AM

@Soda: Hi, no need to ask. :)

srishakatux updated the task description. (Show Details)Mar 12 2020, 1:00 AM
srishakatux subscribed.Mar 12 2020, 1:11 AM

In addition to @Soda's question, I've two more questions that probably others can help answer:

  • Is the scope not too big for a good first task. I'm wondering if there should be separate tasks for separate extensions?
  • Who will be reviewing the submitted patches? Should the submitter try to find the authors/maintainers of the extension from the extension page on MediaWiki.org and add them as reviewers when they submit the patch in Gerrit? (for example: you could possibly add Werdna as a reviewer in Gerrit for a patch related to https://www.mediawiki.org/wiki/Extension:GlobalBlocking)
Ammarpad added a comment.Mar 12 2020, 4:35 PM
In T247155#5957605, @Soda wrote:

@Ammarpad Can I try and work on this? (cause it says lk non-Wikimedia deployed extensions...)

As Aklapper said, you should feel free to work on any. I divided the task into two, extensions deployed on Wikimedia wikis have been taken care of at T242556 , this other task is for the remaining extensions which are not in that set but hosted on Gerrit.

In T247155#5962636, @srishakatux wrote:

In addition to @Soda's question, I've two more questions that probably others can help answer:

  • Is the scope not too big for a good first task. I'm wondering if there should be separate tasks for separate extensions?

I think it will be fine either way, but I have not got time to create individual tasks. If anyone can help do that that will be fine.

  • Who will be reviewing the submitted patches? Should the submitter try to find the authors/maintainers of the extension from the extension page on MediaWiki.org and add them as reviewers when they submit the patch in Gerrit? (for example: you could possibly add Werdna as a reviewer in Gerrit for a patch related to https://www.mediawiki.org/wiki/Extension:GlobalBlocking)

If the submitter knows how to find and add authors/maintainers then that's fine. Otherwise I will endeavor to help them get it reviewed.

gerritbot added a comment.Mar 12 2020, 11:09 PM

Change 579431 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/GlobalBlocking@master] Use IPUtils instead of deprecated IP class

https://gerrit.wikimedia.org/r/579431

gerritbot added a project: Patch-For-Review.Mar 12 2020, 11:09 PM
srishakatux removed a project: Patch-For-Review.Mar 13 2020, 12:10 AM
srishakatux updated the task description. (Show Details)
srishakatux added a subscriber: DannyS712.Mar 13 2020, 12:14 AM

Thanks @Ammarpad! I've added a list of extensions that needs work to the Phabricator task for easy tracking. Except for the GlobalBlocking extension (for which @DannyS712 submitted a patch recently) by, others can still be worked on.

gerritbot added a comment.Mar 13 2020, 1:41 AM

Change 579431 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Use IPUtils instead of deprecated IP class

https://gerrit.wikimedia.org/r/579431

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 13 2020, 2:00 AM
edwardspec subscribed.Mar 13 2020, 2:31 AM

Note: Extension:Moderation uses "master" compatibility policy (its master branch is backward compatible with MW 1.31), so it doesn't need this change yet. (not until hard deprecation of IP class)

QEDK updated the task description. (Show Details)Mar 13 2020, 9:47 AM
gerritbot added a comment.Mar 13 2020, 10:09 AM

Change 579524 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/GlobalContributions@master] Use IPUtils instead of deprecated IP class

https://gerrit.wikimedia.org/r/579524

gerritbot added a project: Patch-For-Review.Mar 13 2020, 10:09 AM
QEDK updated the task description. (Show Details)Mar 13 2020, 10:12 AM
edwardspec unsubscribed.Mar 13 2020, 10:39 AM
Ammarpad added a subscriber: edwardspec.Mar 13 2020, 10:45 AM
In T247155#5966377, @srishakatux wrote:

Thanks @Ammarpad! I've added a list of extensions that needs work to the Phabricator task for easy tracking. Except for the GlobalBlocking extension (for which @DannyS712 submitted a patch recently) by, others can still be worked on.

In T247155#5966507, @edwardspec wrote:

Note: Extension:Moderation uses "master" compatibility policy (its master branch is backward compatible with MW 1.31), so it doesn't need this change yet. (not until hard deprecation of IP class)

Thanks, noted both.

QEDK updated the task description. (Show Details)Mar 13 2020, 12:31 PM
Ammarpad updated the task description. (Show Details)Mar 13 2020, 12:42 PM
gerritbot added a comment.Mar 13 2020, 12:42 PM

Change 579556 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/GlobalContribs@master] Bump MW version, use IPUtils instead of deprecated IP class

https://gerrit.wikimedia.org/r/579556

QEDK updated the task description. (Show Details)Mar 13 2020, 12:44 PM
gerritbot added a comment.Mar 13 2020, 4:39 PM

Change 579524 merged by jenkins-bot:
[mediawiki/extensions/GlobalContributions@master] Bump MW version, use IPUtils instead of deprecated IP class

https://gerrit.wikimedia.org/r/579524

gerritbot added a comment.Mar 13 2020, 8:16 PM

Change 579618 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/GlobalContribs@master] Bump MW version, remove deprecated $wgContLang() and IP class

https://gerrit.wikimedia.org/r/579618

gerritbot added a comment.Mar 13 2020, 8:17 PM

Change 579556 abandoned by QEDK:
Bump MW version, use IPUtils instead of deprecated IP class

Reason:
See <https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalContribs/ /579618>

https://gerrit.wikimedia.org/r/579556

QEDK updated the task description. (Show Details)Mar 13 2020, 8:21 PM
edwardspec unsubscribed.Mar 13 2020, 9:01 PM
srishakatux removed a project: Patch-For-Review.Mar 13 2020, 10:35 PM
DannyS712 added a project: Patch-For-Review.Mar 13 2020, 10:44 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalContribs/+/579618/ is still pending

srishakatux added a comment.Mar 13 2020, 11:13 PM

The only reason I removed the tag was that it wouldn't show up in the list of latest tasks linked from https://www.mediawiki.org/wiki/Good_first_bugs (the way that Phabricator query works). It is fine though! I can maybe file subtasks for the remaining extensions sometime later.

QEDK added a project: patch-welcome.Mar 14 2020, 8:44 AM
gerritbot added a comment.Mar 14 2020, 9:04 AM

Change 579685 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/CookieWarning@master] Bump MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579685

QEDK updated the task description. (Show Details)Mar 14 2020, 10:39 AM
gerritbot added a comment.Mar 14 2020, 2:52 PM

Change 579736 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/SecureSessions@master] Bump MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579736

QEDK updated the task description. (Show Details)Mar 14 2020, 2:54 PM
gerritbot added a comment.Mar 14 2020, 3:03 PM

Change 579738 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/DonationInterface@master] Bump MV version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579738

QEDK updated the task description. (Show Details)Mar 14 2020, 3:06 PM
QEDK updated the task description. (Show Details)Mar 14 2020, 3:57 PM
gerritbot added a comment.Mar 14 2020, 4:00 PM

Change 579685 merged by jenkins-bot:
[mediawiki/extensions/CookieWarning@master] Bump MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579685

gerritbot added a comment.Mar 14 2020, 4:00 PM

Change 579736 merged by jenkins-bot:
[mediawiki/extensions/SecureSessions@master] Bump MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579736

DannyS712 moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.Mar 15 2020, 12:50 AM
gerritbot added a comment.Mar 15 2020, 11:56 AM

Change 579854 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/RegexBlock@master] Bump MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/579854

gerritbot added a comment.Mar 15 2020, 12:00 PM

Change 579855 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/AnonPrivacy@master] Include MW version, remove deprecated IP class

https://gerrit.wikimedia.org/r/579855

QEDK updated the task description. (Show Details)Mar 15 2020, 1:01 PM
gerritbot added a comment.Mar 15 2020, 1:02 PM

Change 579855 merged by jenkins-bot:
[mediawiki/extensions/AnonPrivacy@master] Include MW version, remove deprecated IP class

https://gerrit.wikimedia.org/r/579855

QEDK updated the task description. (Show Details)Mar 16 2020, 6:44 PM
gerritbot added a comment.Mar 16 2020, 7:01 PM

Change 580116 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/BlueSpiceEditNotifyConnector@master] Remove deprecated IP class with IPUtils, update .gitignore

https://gerrit.wikimedia.org/r/580116

gerritbot added a comment.Mar 16 2020, 7:09 PM

Change 580118 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/DeviceMapLogCapture@master] Require MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/580118

gerritbot added a comment.Mar 16 2020, 7:18 PM

Change 580118 merged by jenkins-bot:
[mediawiki/extensions/DeviceMapLogCapture@master] Require MW version, remove deprecated IP class, update .gitignore

https://gerrit.wikimedia.org/r/580118

QEDK updated the task description. (Show Details)Mar 16 2020, 7:26 PM
gerritbot added a comment.Mar 17 2020, 7:20 AM

Change 580116 merged by Pwirth:
[mediawiki/extensions/BlueSpiceEditNotifyConnector@master] Remove deprecated IP class with IPUtils, update .gitignore

https://gerrit.wikimedia.org/r/580116

gerritbot added a comment.Mar 17 2020, 1:25 PM

Change 580321 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/NetworkAuth@master] Remove deprecated IP class with IPUtils, update .gitignore

https://gerrit.wikimedia.org/r/580321

gerritbot added a comment.Mar 17 2020, 1:31 PM

Change 580322 had a related patch set uploaded (by QEDK; owner: QEDK):
[mediawiki/extensions/ArticleFeedbackv5@master] Bump MW version, remove deprecated IP class, update gitignore

https://gerrit.wikimedia.org/r/580322

QEDK updated the task description. (Show Details)Mar 17 2020, 1:31 PM
gerritbot added a comment.Mar 17 2020, 2:42 PM

Change 580322 merged by jenkins-bot:
[mediawiki/extensions/ArticleFeedbackv5@master] Bump MW version, remove deprecated IP class, update gitignore

https://gerrit.wikimedia.org/r/580322

gerritbot added a comment.Mar 17 2020, 2:42 PM

Change 580321 merged by jenkins-bot:
[mediawiki/extensions/NetworkAuth@master] Remove deprecated IP class with IPUtils, update .gitignore

https://gerrit.wikimedia.org/r/580321

QEDK mentioned this in rENAU21b5652cd6d4: Remove deprecated IP class with IPUtils, update .gitignore.Mar 17 2020, 5:46 PM
QEDK changed the task status from Open to Stalled.Mar 18 2020, 7:35 PM
QEDK removed projects: patch-welcome, good first task.
QEDK updated the task description. (Show Details)
gerritbot added a comment.Mar 18 2020, 8:25 PM

Change 579618 merged by GeorgeBarnick:
[mediawiki/extensions/GlobalContribs@master] Bump MW version, remove deprecated $wgContLang() and IP class

https://gerrit.wikimedia.org/r/579618

Ammarpad added projects: patch-welcome, good first task.Mar 19 2020, 7:03 AM

These should remain I think. It's good for searching resolved tasks with the tag

Ammarpad closed this task as Resolved.Mar 19 2020, 7:11 AM
Ammarpad assigned this task to QEDK.

Also there's nothing more to do here. I have created separate tasks for DI and RegexBlock so they can be in their backlogs and addressed once they can take it. Thanks all.

Ammarpad updated the task description. (Show Details)Mar 19 2020, 7:51 AM
QEDK added subtasks: T248060: Remove use of IP class in RegexBlock, T248059: Remove use of IP class in DonationInterface.Mar 20 2020, 2:29 PM
Ammarpad closed subtask T248059: Remove use of IP class in DonationInterface as Resolved.Nov 5 2020, 9:09 AM
Kizule closed subtask T248060: Remove use of IP class in RegexBlock as Resolved.Aug 21 2021, 12:13 AM
Kizule removed a project: Patch-For-Review.Aug 21 2021, 12:31 AM
Kizule updated the task description. (Show Details)
gerritbot added a comment.Sep 4 2021, 11:11 AM

Change 579854 abandoned by Jack Phoenix:

[mediawiki/extensions/RegexBlock@master] Bump MW version, remove deprecated IP class, update .gitignore

Reason:

https://gerrit.wikimedia.org/r/579854

Zabe mentioned this in T291008: Remove deprecated IP class.Sep 25 2021, 11:40 PM
Krinkle edited projects, added mediawiki-libs-IPUtils; removed archived-IPUtils.Jan 3 2024, 3:05 PM
Restricted Application added a subscriber: Lens0021. · View Herald TranscriptJan 3 2024, 3:05 PM
gerritbot added a comment.Jun 4 2024, 10:11 AM

Change #579738 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/DonationInterface@master] Bump MW version, remove deprecated IP class, update .gitignore

Reason:

Already done in other patches.

https://gerrit.wikimedia.org/r/579738

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits