[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T247067

Decouple SearchEntities from PropertyDataTypeLookup
Closed, ResolvedPublic
Actions

Description

SearchEntities currently has knowledge about what to do for properties.
This knowledge and extra meta data that is added to the result should somehow be included in the search helper instead.

Details

SubjectRepoBranchLines +/-
Remove unused SearchEntities constructor paramsmediawiki/extensions/Wikibasemaster+0 -10
Remove SearchEntities constructor argsmediawiki/extensions/WikibaseCirrusSearchmaster+0 -2
Decouple SearchEntities from PropertyDataTypeLookupmediawiki/extensions/Wikibasemaster+209 -48
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Mar 6 2020, 11:19 AM
Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.
gerritbot added a comment.Mar 6 2020, 11:52 AM

Change 577318 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Decouple SearchEntities from PropertyDataTypeLookup

https://gerrit.wikimedia.org/r/577318

gerritbot added a project: Patch-For-Review.Mar 6 2020, 11:52 AM
gerritbot added a comment.Mar 6 2020, 12:41 PM

Change 577306 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove SearchEntities constructor args

https://gerrit.wikimedia.org/r/577306

gerritbot added a comment.Mar 6 2020, 12:45 PM

Change 577549 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Remove unused SearchEntities constructor params

https://gerrit.wikimedia.org/r/577549

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.Mar 6 2020, 1:12 PM
gerritbot added a comment.Mar 9 2020, 1:15 PM

Change 577318 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Decouple SearchEntities from PropertyDataTypeLookup

https://gerrit.wikimedia.org/r/577318

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 9 2020, 2:00 PM
gerritbot added a comment.Mar 11 2020, 9:40 AM

Change 577306 merged by Addshore:
[mediawiki/extensions/WikibaseCirrusSearch@master] Remove SearchEntities constructor args

https://gerrit.wikimedia.org/r/577306

gerritbot added a comment.Mar 11 2020, 9:40 AM

Change 577549 merged by Addshore:
[mediawiki/extensions/Wikibase@master] Remove unused SearchEntities constructor params

https://gerrit.wikimedia.org/r/577549

Addshore moved this task from Peer Review to Verification on the Wikibase - Federated Properties (Sprint 1/6 (Hike 1)) board.Mar 11 2020, 9:40 AM
Addshore mentioned this in rEWCSbe12c8cb1ac1: Remove SearchEntities constructor args.Mar 11 2020, 9:41 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.24; 2020-03-17); removed MW-1.35-notes (1.35.0-wmf.23; 2020-03-10).Mar 11 2020, 10:01 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 11 2020, 10:10 AM
Addshore closed this task as Resolved.Apr 3 2020, 11:05 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits