After the bridge has been saved (and we are showing the ThankYouScreen), the “close” button should emit a “saved” event (causing the init module to reload the page) rather than the usual “cancel” event.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Charlie_WMDE | T240333 Step 1: give users a path to add/edit references on Wikidata (impact: high) | |||
| Resolved | • Tonina_Zhelyazkova_WMDE | T247954 Make “close” button emit either “cancel” or “saved” event depending on state |
Event Timeline
Comment Actions
Change 583933 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: distinguish between “close” and “cancel”
Comment Actions
Change 583933 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: distinguish between “close” and “cancel”
Comment Actions
Change 584810 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/Wikibase@master] bridge: Emit cancel or save depending on app state
Comment Actions
Change 585001 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: use “close” button to trigger reload in browser test
Comment Actions
Change 584810 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Emit cancel or save depending on app state
Comment Actions
No, wait, now I remember why I hadn’t closed this yet yesterday evening :D browser test update is still up for review.
Comment Actions
Change 585001 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: use “close” button to trigger reload in browser test