[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T247771

Line height in drawers is tight (viewing references on mobile)
Closed, ResolvedPublic
Actions

Assigned To
• alexhollender_WMF
Authored By
Esanders
Mar 16 2020, 4:36 PM
Tags
Referenced Files
F31700550: image.png
Mar 24 2020, 9:42 PM
F31700548: image.png
Mar 24 2020, 9:42 PM
F31700309: en.m.wikipedia.org_wiki_%C3%89tude_Op._25,_No._1_(Chopin)(iPhone 6_7_8).png
Mar 24 2020, 5:22 PM
F31700307: en.m.wikipedia.beta.wmflabs.org_wiki_Uganda_Martyrs(iPhone 6_7_8).png
Mar 24 2020, 5:22 PM
F31685101: image.png
Mar 16 2020, 4:36 PM
F31685099: image.png
Mar 16 2020, 4:36 PM
Subscribers
Aklapper
• alexhollender_WMF
Esanders
Jdlrobson
JTannerWMF
matmarex
ovasileva
thiemowmde

Description

For example, references:

image.png (640×358 px, 64 KB)

The line height is overridden to 100%, instead of using the skin default of 140%.

Even on a small screen, there appears to be enough room for this more comfortable line height:

image.png (637×357 px, 60 KB)

Details

SubjectRepoBranchLines +/-
ReferencesDrawer: Remove unused styles for .reference-textmediawiki/extensions/MobileFrontendmaster+0 -4
Remove line-height overrides for drawersmediawiki/extensions/MobileFrontendmaster+0 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 16 2020, 4:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2020, 4:36 PM
gerritbot added a comment.Mar 16 2020, 4:50 PM

Change 580080 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Remove line-height overrides for drawers

https://gerrit.wikimedia.org/r/580080

gerritbot added a project: Patch-For-Review.Mar 16 2020, 4:50 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2019-20-Q3).Mar 16 2020, 8:42 PM
Jdlrobson added a subscriber: • alexhollender_WMF.

Cc @alexhollender. Pulling into sprint as we'll want to verify all the other drawers in storybook.

Jdlrobson moved this task from Needs Analysis to Needs Code Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Mar 16 2020, 8:42 PM
Esanders added a comment.Mar 17 2020, 2:17 PM

Looking at the storybook, only the reference drawer uses the affected selectors (.drawer.text and .drawer p) so this should have no effect on other drawers.

Esanders added a comment.Mar 17 2020, 2:25 PM

Actually the AMC drawer uses the .drawer p selector, but it already inherits 1.4 line height from the body.

Note that in the storybook not all the Minerva classes are present (for example the 1.4 line height on the body).

JTannerWMF added a project: Editing-team (Tracking).Mar 17 2020, 5:25 PM
JTannerWMF moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.Mar 17 2020, 6:26 PM
JTannerWMF subscribed.

This task is waiting on code review from the web team.

Jdlrobson assigned this task to • alexhollender_WMF.Mar 18 2020, 5:17 PM
Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.
Jdlrobson moved this task from Needs Design Review to Needs QA on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Mar 18 2020, 5:19 PM

Chatted about this in standup and @alexhollender says this works for him.

gerritbot added a comment.Mar 18 2020, 5:32 PM

Change 580080 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove line-height overrides for drawers

https://gerrit.wikimedia.org/r/580080

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2020, 6:10 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 19 2020, 8:47 PM
ovasileva subscribed.Mar 24 2020, 5:19 PM

@JTannerWMF - review is done. Should we send this back to the Editing team for QA?

• alexhollender_WMF added a comment.Mar 24 2020, 5:22 PM

Just did a quick QA on the beta cluster. The change looks good:

beta (link)production (link)
en.m.wikipedia.beta.wmflabs.org_wiki_Uganda_Martyrs(iPhone 6_7_8).png (1×750 px, 225 KB)
en.m.wikipedia.org_wiki_%C3%89tude_Op._25,_No._1_(Chopin)(iPhone 6_7_8).png (1×750 px, 180 KB)
Esanders added a subscriber: matmarex.Mar 24 2020, 8:30 PM

Going by the screenshots in T244510 this appears to be a recent regression, which suggests that whatever is generating the HTML of the references, started stripping the paragraph tags? CC @matmarex

matmarex added a subscriber: thiemowmde.Mar 24 2020, 9:42 PM

I looked at wmf/1.35.0-wmf.15 to see how it was rendering there. There were never paragraph tags, but there was a wrapper with the reference-text class, and that has line-height: 1.4; defined here: ReferencesDrawer.less#L38

Comparison of the DOM structure before and after:

wmf/1.35.0-wmf.15master
image.png (891×2 px, 149 KB)
image.png (891×2 px, 143 KB)

I think change rEMFR0da51be80f02: Fix ReferencesHtmlScraperGateway showing child references is the reason.

Now that you fixed it differently, I think we should just remove the styling for .reference-text in ReferencesDrawer.less.

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-03-18.Mar 25 2020, 7:39 AM

Oh dear. I believe our mistake in the patch https://gerrit.wikimedia.org/r/570090 (done as part of T242899) was that we only tested 1-line references. Thanks a lot for fixing this mistake!

Yes, the .reference-text { line-height: 1.4; } can now be removed.

thiemowmde moved this task from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-03-18 board.Mar 25 2020, 7:39 AM
ovasileva moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.Mar 25 2020, 10:20 AM
ovasileva edited projects, added Editing QA; removed Web-Team-Backlog (Kanbanana-2019-20-Q3).Mar 25 2020, 5:26 PM

Moving to editing QA and untagging Readers Web - feel free to add again if there's anything else we can do to help here

gerritbot added a comment.Mar 25 2020, 8:06 PM

Change 583434 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] ReferencesDrawer: Remove unused styles for .reference-text

https://gerrit.wikimedia.org/r/583434

gerritbot added a project: Patch-For-Review.Mar 25 2020, 8:06 PM
gerritbot added a comment.Mar 25 2020, 9:48 PM

Change 583434 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] ReferencesDrawer: Remove unused styles for .reference-text

https://gerrit.wikimedia.org/r/583434

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.26; 2020-03-31); removed MW-1.35-notes (1.35.0-wmf.25; 2020-03-24).Mar 25 2020, 10:00 PM
Jdlrobson edited projects, added MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Web-Team-Backlog (Tracking); removed MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Patch-For-Review.Mar 26 2020, 4:20 PM

@Esanders I assume somebody in editing will QA/resolve this?

WMDE-Fisch moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-03-18 board.Mar 31 2020, 11:42 AM
Esanders closed this task as Resolved.Apr 6 2020, 7:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits