[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T242899

Make MobileFrontend and MinervaNeue compatible with BookReferencing
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To
WMDE-Fisch
Authored By
thiemowmde
Jan 15 2020, 6:45 PM
Tags
Referenced Files
F31622579: Reference Preview Mobile.png
Feb 19 2020, 12:53 PM
F31607914: Screen Shot 2020-02-11 at 5.01.42 PM.png
Feb 11 2020, 9:04 AM
F31607915: Screen Shot 2020-02-11 at 5.01.04 PM.png
Feb 11 2020, 9:04 AM
F31536581: 1) Sub Book References with Existing Style Mobile.png
Jan 28 2020, 12:00 PM
F31519418: Screenshot_20200121-123743_Browser.png
Jan 21 2020, 11:42 AM
Subscribers
Aklapper
• alexhollender_WMF
awight
Erdinc_Ciftci_WMDE
Jdlrobson
Lena_WMDE
Masumrezarock100
View All 11 Subscribers
Tokens
"Love" token, awarded by thiemowmde.

Description

The idea is to show the parent along with the sub-reference, so the user can understand the structure. This is the same issue and proposed solution as T239228: Make the ReferencePreviews feature compatible with sub-references (Cite Extends) for the Reference Previews feature.

Here's an example screenshot of a test page with an opened preview popup for a subreference:

Screenshot_20200121-123743_Browser.png (1×1 px, 248 KB)

Things to be done

  • Identify sub-references when scraping the preview text from the wiki page
  • Identify the parent reference
  • Scrape content of the parent reference
  • Combine both in the preview (TBD by design) see also T239228

Details

SubjectRepoBranchLines +/-
Include parent text on extended referencesmediawiki/extensions/MobileFrontendmaster+27 -6
Fix ReferencesHtmlScraperGateway showing child referencesmediawiki/extensions/MobileFrontendmaster+8 -10
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Jan 15 2020, 6:45 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJan 15 2020, 6:45 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MobileFrontend, MinervaNeue.Jan 15 2020, 10:59 PM
Jdlrobson added a project: Reference Previews.
awight updated the task description. (Show Details)Jan 21 2020, 11:42 AM
WMDE-Fisch moved this task from Backlog to Tickets in preparation/investigation on the Cite-Extends board.Jan 21 2020, 1:34 PM
WMDE-Fisch updated the task description. (Show Details)
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2020-01-21.Jan 21 2020, 2:07 PM
Tobi_WMDE_SW set the point value for this task to 8.
Tobi_WMDE_SW subscribed.

We'll work on points 1-3 and wait for design feedback for point 4.

Tobi_WMDE_SW changed the point value for this task from 8 to 5.Jan 21 2020, 2:08 PM
WMDE-Fisch moved this task from Tickets in preparation/investigation to Tickets in sprint on the Cite-Extends board.Jan 21 2020, 3:07 PM
WMDE-Fisch added a comment.Jan 23 2020, 11:46 AM

For implementing this, please also see how it's done in the patch for the same issue with Reference Previews in https://gerrit.wikimedia.org/r/566710/

WMDE-Fisch claimed this task.Jan 27 2020, 12:59 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-01-21 board.
gerritbot added a comment.Jan 27 2020, 2:26 PM

Change 567458 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/MobileFrontend@master] [WIP] Include parent text on extended references

https://gerrit.wikimedia.org/r/567458

gerritbot added a project: Patch-For-Review.Jan 27 2020, 2:26 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-01-21 board.Jan 28 2020, 10:32 AM
Erdinc_Ciftci_WMDE subscribed.Jan 28 2020, 12:00 PM

1) Sub Book References with Existing Style Mobile.png (667×375 px, 103 KB)
Here is the screenshot of the prototype design with a sub reference (It's not reviewed with Hanna, sharing as a follow up to our daily.)

thiemowmde removed a project: Reference Previews.Jan 28 2020, 1:08 PM
WMDE-Fisch mentioned this in T243840: Make the Android App compatible with BookReferencing.Jan 28 2020, 2:57 PM
WMDE-Fisch mentioned this in T243839: Make the iOS App compatible with BookReferencing.
gerritbot added a comment.Feb 4 2020, 4:45 PM

Change 570090 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/MobileFrontend@master] Fix ReferencesHtmlScraperGateway showing child references

https://gerrit.wikimedia.org/r/570090

Lena_WMDE subscribed.Feb 5 2020, 8:59 AM
Jdlrobson subscribed.Feb 11 2020, 9:04 AM

I'm seeing a UI regression with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/570090/ on [[:en:Yeomanry_Cavalry]]

Screen Shot 2020-02-11 at 5.01.42 PM.png (252×884 px, 40 KB)

Screen Shot 2020-02-11 at 5.01.04 PM.png (406×1 px, 98 KB)

note the lack of space after [3]

Jdlrobson added a project: Web-Team-Backlog (Kanbanana-2019-20-Q3).Feb 11 2020, 9:04 AM
Jdlrobson added subscribers: • alexhollender_WMF, ovasileva.

Adding to our kanbanan for visibility since proposed changes impact Minerva look and feel (cc @ovasileva and @alexhollender)

Jdlrobson reassigned this task from WMDE-Fisch to • alexhollender_WMF.Feb 11 2020, 9:05 AM
Jdlrobson reassigned this task from • alexhollender_WMF to WMDE-Fisch.
Jdlrobson moved this task from Needs Analysis to Needs Design Review on the Web-Team-Backlog (Kanbanana-2019-20-Q3) board.
ovasileva added a comment.Feb 18 2020, 11:46 AM
In T242899#5871490, @Jdlrobson wrote:

Adding to our kanbanan for visibility since proposed changes impact Minerva look and feel (cc @ovasileva and @alexhollender)

Is this for code review or product & design review for the changes proposed?

Jdlrobson added a comment.Feb 18 2020, 7:45 PM

I just want to give @alexhollender the chance to see the mock on T242899#5836008 before taking care of the code review of the changes proposed.

Erdinc_Ciftci_WMDE added a comment.Feb 19 2020, 12:53 PM

We've iterated the prototype in the latest UX Meeting so this is up to date:

Reference Preview Mobile.png (188×392 px, 18 KB)

thiemowmde awarded a token.Feb 19 2020, 2:48 PM
ovasileva added a comment.Feb 19 2020, 6:14 PM

Noting that our board is a bit full at the moment, but we will be reviewing this once @alexhollender has some time

• alexhollender_WMF removed a project: Web-Team-Backlog (Kanbanana-2019-20-Q3).Feb 24 2020, 5:56 PM

I've been in communication with @Erdinc_Ciftci_WMDE — the proposed design for mobile looks good. Removing this from our board.

gerritbot added a comment.Feb 24 2020, 10:01 PM

Change 570090 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix ReferencesHtmlScraperGateway showing child references

https://gerrit.wikimedia.org/r/570090

thiemowmde mentioned this in T247771: Line height in drawers is tight (viewing references on mobile).Mar 25 2020, 7:39 AM
gerritbot added a comment.Jul 2 2020, 9:43 PM

Change 567458 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Include parent text on extended references

https://gerrit.wikimedia.org/r/567458

Maintenance_bot removed a project: Patch-For-Review.Jul 2 2020, 10:10 PM
awight closed this task as Resolved.Oct 6 2020, 12:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits