[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T247674

Remove $wgContLanguageCode
Closed, ResolvedPublic
Actions

Description

Prior to 2004, the site language was configured via $wgContLanguageCode, derived from that were $wgContLang (object). $wgLanguageCode was just a cached copy of $wgUser->getOption('language').

In 2004 (r5492, 5537c5b85e, MW 1.3), $wgContLanguageCode ceased to be supported as a configuration variable. Instead, the site language would now be configured via $wgLanguageCode instead and the confusion started. Its value was copied to $wgContLanguageCode for back-compat, and also because $wgLanguageCode was still also used to store User::getOption('language') right after initialising $wgContLang.

Sometime between 2004 and 2006, $wgLanguageCode was relieved of this secondary purpose, as documented in r5492 (5537c5b85, MW 1.8), leaving it as just a configuration variable for the site language.

Let's remove any uses of it and then remove it from Setup.php.

Details

SubjectRepoBranchLines +/-
Remove $wgContLanguageCodemediawiki/coremaster+3 -4
Replace $wgContLanguageCode with $wgLanguageCodemediawiki/extensions/Mathmaster+2 -2
cache: Remove use of $wgContLanguageCode in MessageCacheTestmediawiki/coremaster+3 -3
Replace $wgContLanguageCode with $wgLanguageCodemediawiki/extensions/CiteThisPagemaster+2 -2
Replace $wgContLanguageCode with $wgLanguageCodemediawiki/extensions/DoubleWikimaster+2 -2
Replace $wgContLanguageCode with $wgLanguageCodemediawiki/extensions/FlaggedRevsmaster+4 -4
Remove outdated use of $wgContLanguageCodemediawiki/extensions/SiteSettingsmaster+3 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Mar 14 2020, 7:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 14 2020, 7:29 PM
gerritbot added a comment.Mar 14 2020, 7:31 PM

Change 579774 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Math@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579774

gerritbot added a project: Patch-For-Review.Mar 14 2020, 7:31 PM

Change 579775 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/FlaggedRevs@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579775

gerritbot added a comment.Mar 14 2020, 7:33 PM

Change 579776 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/CiteThisPage@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579776

gerritbot added a comment.Mar 14 2020, 7:42 PM

Change 579777 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/DoubleWiki@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579777

gerritbot added a comment.Mar 14 2020, 7:44 PM

Change 579778 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/SiteSettings@master] Remove outdated use of $wgContLanguageCode

https://gerrit.wikimedia.org/r/579778

gerritbot added a comment.Mar 14 2020, 7:48 PM

Change 579780 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] cache: Remove use of $wgContLanguageCode in MessageCacheTest

https://gerrit.wikimedia.org/r/579780

gerritbot added a comment.Mar 14 2020, 7:49 PM

Change 579781 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Remove $wgContLanguageCode

https://gerrit.wikimedia.org/r/579781

gerritbot added a comment.Mar 14 2020, 11:24 PM

Change 579778 merged by jenkins-bot:
[mediawiki/extensions/SiteSettings@master] Remove outdated use of $wgContLanguageCode

https://gerrit.wikimedia.org/r/579778

gerritbot added a comment.Mar 14 2020, 11:30 PM

Change 579775 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579775

gerritbot added a comment.Mar 14 2020, 11:30 PM

Change 579777 merged by jenkins-bot:
[mediawiki/extensions/DoubleWiki@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579777

gerritbot added a comment.Mar 14 2020, 11:37 PM

Change 579776 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579776

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 15 2020, 12:00 AM
gerritbot added a comment.Mar 15 2020, 12:00 PM

Change 579780 merged by jenkins-bot:
[mediawiki/core@master] cache: Remove use of $wgContLanguageCode in MessageCacheTest

https://gerrit.wikimedia.org/r/579780

gerritbot added a comment.Mar 15 2020, 5:34 PM

Change 579774 merged by Krinkle:
[mediawiki/extensions/Math@master] Replace $wgContLanguageCode with $wgLanguageCode

https://gerrit.wikimedia.org/r/579774

gerritbot added a comment.Mar 18 2020, 4:31 PM

Change 579781 merged by jenkins-bot:
[mediawiki/core@master] Remove $wgContLanguageCode

https://gerrit.wikimedia.org/r/579781

Jdforrester-WMF closed this task as Resolved.Mar 18 2020, 4:57 PM
Jdforrester-WMF assigned this task to Krinkle.
Jdforrester-WMF added a project: Projects-Cleanup.
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2020, 5:10 PM
Aklapper removed a project: Projects-Cleanup.Mar 19 2020, 10:47 AM
Aklapper added a subscriber: Jdforrester-WMF.

@Jdforrester-WMF: Removing Projects-Cleanup as that is for repositories - Technical-Debt might apply?

Jdforrester-WMF added a project: Technical-Debt (Deprecation process).Mar 19 2020, 8:09 PM
In T247674#5983411, @Aklapper wrote:

@Jdforrester-WMF: Removing Projects-Cleanup as that is for repositories - Technical-Debt might apply?

"An umbrella project for tracking efforts to clean and/or reorganize Phabricator tasks and projects."

Should probably be renamed to "Phabricator-clean-up" or similar then.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits