vue was introduced into core as ResourceLoader module - we should depend (e.g.) on it instead of the (now redundant) wikibase equivalent.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: depend on 'vue' ResourceLoader module from core | mediawiki/extensions/Wikibase | master | +54 -58 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | guergana.tzatchkova | T247520 Use "vue" ResourceLoader module from core | |||
| Resolved | • Pablo-WMDE | T247519 Bridge: Use "vue" ResourceLoader module from core |
Event Timeline
Comment Actions
Change 579292 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: depend on 'vue' ResourceLoader module from core
Comment Actions
Change 579292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: depend on 'vue' ResourceLoader module from core
Comment Actions
Unfortunately, the vuejs dev-tools still don't seem to work with debug=true appended to the url. I guess the reason is that "our" code is still compiled for production?
Comment Actions
Unfortunately, the vuejs dev-tools still don't seem to work with debug=true appended to the url
Yes, I consider this a challenge tracked in T228857: Step 1: minification of common.js (formerly: Investigate common.js bundle content/size) though (also see T246456: Performance review of Wikidata Bridge's "potential optimisations that haven't been performed yet").
Comment Actions
I don't see how "enable dev-tools when debug=true" is an AC in those tickets. That being said, it is not an AC for this task either, therefore this task can be resolved.