[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T247479

All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11
Closed, ResolvedPublic
Actions

Assigned To
• Mholloway
Authored By
Bugreporter
Mar 11 2020, 11:49 PM
Tags
Referenced Files
F31678573: Commons revisions mistagged with apps-suggested-edits (T247479)
Mar 13 2020, 12:17 AM
F31678574: Wikidata revisions mistagged with apps-suggested-edits (T247479)
Mar 13 2020, 12:17 AM
Subscribers
Aklapper
Bugreporter
Liuxinyu970226
• Mholloway

Description

See:
https://www.wikidata.org/w/index.php?title=Special:RecentChanges&tagfilter=apps-suggested-edits
https://commons.wikimedia.org/w/index.php?title=Special:RecentChanges&tagfilter=apps-suggested-edits

Details

SubjectRepoBranchLines +/-
Revert "Fix revert counting for non-language-specific counters"mediawiki/extensions/WikimediaEditorTaskswmf/1.35.0-wmf.22+38 -228
Revert "Fix revert counting for non-language-specific counters"mediawiki/extensions/WikimediaEditorTaskswmf/1.35.0-wmf.23+38 -228
Revert "Fix revert counting for non-language-specific counters"mediawiki/extensions/WikimediaEditorTasksmaster+38 -228
Customize query in gerrit

Related Objects

Event Timeline

Bugreporter created this task.Mar 11 2020, 11:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2020, 11:49 PM
Bugreporter triaged this task as Unbreak Now! priority.Mar 11 2020, 11:51 PM

Since about 23:40 UTC

Permalink: https://archive.is/aS8Nl

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 11 2020, 11:51 PM
Bugreporter added a project: WikimediaEditorTasks.Mar 11 2020, 11:52 PM
Restricted Application added a project: Product-Infrastructure-Team-Backlog-Deprecated. · View Herald TranscriptMar 11 2020, 11:52 PM
Restricted Application added a subscriber: • Mholloway. · View Herald Transcript
• Mholloway claimed this task.Mar 11 2020, 11:53 PM
gerritbot added a comment.Mar 11 2020, 11:55 PM

Change 579092 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/WikimediaEditorTasks@master] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579092

gerritbot added a project: Patch-For-Review.Mar 11 2020, 11:55 PM

Change 579092 merged by Mholloway:
[mediawiki/extensions/WikimediaEditorTasks@master] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579092

• Mholloway mentioned this in rEWET71be189ab268: Revert "Fix revert counting for non-language-specific counters".Mar 11 2020, 11:57 PM
gerritbot added a comment.Mar 11 2020, 11:57 PM

Change 579093 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.23] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579093

gerritbot added a comment.Mar 11 2020, 11:57 PM

Change 579093 merged by Mholloway:
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.23] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579093

• Mholloway mentioned this in rEWET63ddd08a28bf: Revert "Fix revert counting for non-language-specific counters".Mar 11 2020, 11:58 PM
Stashbot added a comment.Mar 12 2020, 12:00 AM

Mentioned in SAL (#wikimedia-operations) [2020-03-12T00:00:24Z] <mholloway-shell@deploy1001> Synchronized php-1.35.0-wmf.23/extensions/WikimediaEditorTasks: Revert 'Fix revert counting for non-language-specific counters' (T247479) (duration: 01m 07s)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 12 2020, 12:01 AM
• Mholloway added a comment.Mar 12 2020, 12:02 AM

Should be fixed by the above, can someone verify?

Bugreporter added a comment.Mar 12 2020, 12:03 AM

This no longer happens. But is it a proper fix? or a workaround?

• Mholloway added a comment.Mar 12 2020, 12:07 AM

The code that caused the issue was reverted. Some additional cleanup will be needed.

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2020, 12:10 AM
gerritbot added a comment.Mar 12 2020, 12:17 AM

Change 579096 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.22] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579096

gerritbot added a project: Patch-For-Review.Mar 12 2020, 12:17 AM
• Mholloway lowered the priority of this task from Unbreak Now! to High.Mar 12 2020, 12:26 AM

Lowering the priority since this is no longer happening.

• Mholloway renamed this task from All edits in Wikidata are tagged as "suggested edits" to All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11.Mar 12 2020, 12:28 AM
• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Product-Infrastructure-Team-Backlog-Deprecated.
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
• Mholloway renamed this task from All edits in Wikidata tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11 to All edits on Wikidata and Commons tagged as "suggested edits" between approx. 23:40 and 00:00 UTC on 2020-03-11.Mar 12 2020, 12:37 AM
• Mholloway updated the task description. (Show Details)
gerritbot added a comment.Mar 12 2020, 1:32 AM

Change 579096 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.35.0-wmf.22] Revert "Fix revert counting for non-language-specific counters"

https://gerrit.wikimedia.org/r/579096

• Mholloway mentioned this in rEWETe5736ec73862: Revert "Fix revert counting for non-language-specific counters".Mar 12 2020, 1:33 AM
Stashbot added a comment.Mar 12 2020, 1:51 AM

Mentioned in SAL (#wikimedia-operations) [2020-03-12T01:51:32Z] <mholloway-shell@deploy1001> Synchronized php-1.35.0-wmf.22/extensions/WikimediaEditorTasks: Revert 'Fix revert counting for non-language-specific counters' (T247479) (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.22; 2020-03-03); removed MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 12 2020, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2020, 2:10 AM
• Mholloway closed this task as Resolved.Mar 13 2020, 12:17 AM

After some discussion, it's probably best just to let the affected revisions be. There were 11,903 affected revisions on Wikidata, and 3,579 on Commons. I've uploaded lists of affected revision IDs as F31678573 and F31678574.

• Mholloway added a comment.Mar 13 2020, 12:20 AM

Forgot to add: thanks very much @Bugreporter for quickly noticing and reporting this!

• Mholloway mentioned this in rEWET000d4e430664: Fix revert counting for non-language-specific counters, take 2.Mar 17 2020, 12:48 AM
• Mholloway mentioned this in rEWET1a465e01c485: Fix revert counting for non-language-specific counters, take 2.Mar 17 2020, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits