| Tchanders | |
| Mar 11 2020, 5:49 PM |
| F31676757: image.png | |
| Mar 11 2020, 5:49 PM |
| F31676762: image.png | |
| Mar 11 2020, 5:49 PM |
The HTMLUserTextField on Special:EmailUser has the config required = false.
That means it's possible to submit the empty field, but it fails validation (because it also has exists = true), and the following error is shown:
Instead, it should have required = true, so that a more helpful error is shown on attempting to submit the empty field:
(It should still have exists = true for when it is submitted with a non-empty value.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| SpecialEmailUser: Set user text field to required | mediawiki/core | master | +1 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | dbarratt | T247279 Filters on Special:Investigate should validate users | |||
| Resolved | dbarratt | T246958 HTMLUsersMultiselectField fails validation when exists is true, but required is false | |||
| Resolved | Tchanders | T247430 The user text field on Special:EmailUser should be required |
Change 579012 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] SpecialEmailUser: Set user text field to required
Change 579012 merged by jenkins-bot:
[mediawiki/core@master] SpecialEmailUser: Set user text field to required