[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator

Send references to API for formatting and store result
Closed, ResolvedPublic

Description

This delays the completion of the “loading” state – after the initial requests to load the entity data, we now have another API request to send it to the formatting API and save the result in the store, probably in the root module.

Conceptually, this isn’t very nice – the formatted reference is hardly “state” in its own right, and the store doesn’t really care about it afterwards – but this seems like the most straightforward implementation given our current architecture. Moving this logic into the ReferenceSection component, which is where it’s actually needed, would not be trivial (how would we know when to stop showing the loading bar?).

Event Timeline

Change 581048 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: send references to API for formatting and store result

https://gerrit.wikimedia.org/r/581048

Change 581048 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: send references to API for formatting and store result

https://gerrit.wikimedia.org/r/581048