[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Page MenuHomePhabricator
Create Task
Maniphest T246236

Add License component
Closed, ResolvedPublic
Actions

Description

  • Create a License component which looks like the mock in the parent task (minus the checkbox).
  • Create the necessary messages.
  • The component should emit a cancel event when the cancel button is clicked,
  • The “main body” of the text is probably one interface message (possibly two, one per paragraph), with parameters for the “publish changes” message name, the terms of use URL, the license name, and the license URL.
  • The “heading” may or may not be a separate interface message.

Figma Screenshot:

image.png (639×921 px, 74 KB)

Details

SubjectRepoBranchLines +/-
bridge: Add license componentmediawiki/extensions/Wikibasemaster+156 -1
bridge: add messages for license dialogmediawiki/extensions/Wikibasemaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Feb 26 2020, 3:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2020, 3:28 PM
• Tonina_Zhelyazkova_WMDE merged a task: T246229: Add component for dialog with semi-opaque overlay.Feb 26 2020, 3:29 PM
• Tonina_Zhelyazkova_WMDE merged a task: T246228: Define contents of dialog.
• Tonina_Zhelyazkova_WMDE added a subscriber: Lucas_Werkmeister_WMDE.
• Tonina_Zhelyazkova_WMDE edited projects, added Wikidata-Bridge; removed Wikidata-Bridge-Sprint-15.Feb 26 2020, 3:35 PM
Michael moved this task from Incoming to Task overflow on the Wikidata-Bridge board.Feb 26 2020, 3:38 PM
• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-15; removed Wikidata-Bridge.Mar 6 2020, 11:45 AM
Lucas_Werkmeister_WMDE added a comment.Mar 9 2020, 2:54 PM

Since T246229: Add component for dialog with semi-opaque overlay was merged into this task, I assume its scope also includes the overlay part?

Lucas_Werkmeister_WMDE claimed this task.Mar 9 2020, 3:20 PM
Lucas_Werkmeister_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-15 board.

Claiming the messages part for now.

gerritbot added a comment.Mar 9 2020, 4:04 PM

Change 578350 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add messages for license dialog

https://gerrit.wikimedia.org/r/578350

gerritbot added a project: Patch-For-Review.Mar 9 2020, 4:04 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 9 2020, 4:07 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-15 board.

Unassigning myself, anyone is free to continue. (That includes me, of course, it just doesn’t have to be me.)

Michael claimed this task.Mar 10 2020, 11:34 AM
Michael moved this task from Peer Review to Doing on the Wikidata-Bridge-Sprint-15 board.
Michael added a project: User-Michael.
darthmon_wmde added a project: Wikidata-Bridge-Sprint-16.Mar 11 2020, 9:47 AM
darthmon_wmde moved this task from To do to Doing on the Wikidata-Bridge-Sprint-16 board.
Michael updated the task description. (Show Details)Mar 12 2020, 10:49 AM
gerritbot added a comment.Mar 12 2020, 10:55 AM

Change 578350 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add messages for license dialog

https://gerrit.wikimedia.org/r/578350

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.24; 2020-03-17).Mar 12 2020, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2020, 11:10 AM
gerritbot added a comment.Mar 12 2020, 3:26 PM

Change 578565 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Add license component

https://gerrit.wikimedia.org/r/578565

gerritbot added a project: Patch-For-Review.Mar 12 2020, 3:26 PM
Michael moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-16 board.Mar 12 2020, 3:47 PM
Lucas_Werkmeister_WMDE added a comment.Mar 13 2020, 3:31 PM
In T246236#5953946, @Lucas_Werkmeister_WMDE wrote:

Since T246229: Add component for dialog with semi-opaque overlay was merged into this task, I assume its scope also includes the overlay part?

@Michael the semi-transparent overlay isn’t part of your change, right? Or did I miss it?

Lucas_Werkmeister_WMDE added a comment.Mar 13 2020, 3:36 PM

@Michael the semi-transparent overlay isn’t part of your change, right? Or did I miss it?

Nevermind, I see it in the wire-up change now – I guess it makes sense there, too, since the app already knows how to “blur” itself during saving.

gerritbot added a comment.Mar 13 2020, 4:20 PM

Change 578565 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Add license component

https://gerrit.wikimedia.org/r/578565

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2020, 5:10 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 13 2020, 5:12 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Bridge-Sprint-16 board.

I think we can close this then, verification is probably better as part of the overall task.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits